Re: [Intel-xe] [PATCH 2/3] drm/xe: Add wrapper function for VGA decode setup

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 18 Sep 2023, Uma Shankar <uma.shankar@intel.com> wrote:
> Some of the VGA functionality is not needed by the Intel
> Xe driver. Adding a wrapper function for VGA decode setup.
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
>  drivers/gpu/drm/xe/display/ext/i915_utils.c | 5 +++++
>  drivers/gpu/drm/xe/xe_display.h             | 1 +
>  2 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/display/ext/i915_utils.c b/drivers/gpu/drm/xe/display/ext/i915_utils.c
> index 981edc2788bc..aa3e9ad718c3 100644
> --- a/drivers/gpu/drm/xe/display/ext/i915_utils.c
> +++ b/drivers/gpu/drm/xe/display/ext/i915_utils.c
> @@ -20,3 +20,8 @@ int __i915_inject_probe_error(struct drm_i915_private *i915, int err,
>  {
>  	return 0;
>  }
> +
> +unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
> +{
> +	return -EIO;
> +}

We don't really want to add anything new to i915_utils.c. It's just
temporary cruft that had to be taken from i915 to make the rest compile.

> diff --git a/drivers/gpu/drm/xe/xe_display.h b/drivers/gpu/drm/xe/xe_display.h
> index 03b7ea9268d4..d7a200e6ec30 100644
> --- a/drivers/gpu/drm/xe/xe_display.h
> +++ b/drivers/gpu/drm/xe/xe_display.h
> @@ -38,6 +38,7 @@ void xe_display_pm_suspend(struct xe_device *xe);
>  void xe_display_pm_suspend_late(struct xe_device *xe);
>  void xe_display_pm_resume_early(struct xe_device *xe);
>  void xe_display_pm_resume(struct xe_device *xe);
> +unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode);

We also don't want to add random declarations in xe_display.h either...

BR,
Jani.

>  
>  #else

-- 
Jani Nikula, Intel