From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB05BEDE990 for ; Thu, 14 Sep 2023 08:36:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A085E10E51E; Thu, 14 Sep 2023 08:36:05 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67FE710E51D for ; Thu, 14 Sep 2023 08:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694680563; x=1726216563; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=gWOcQnMLjQBbuILzhhQbs5MgqleT1El/Cr3S92U5gig=; b=i86bbaC2RAVkoHk1vAQ99BUCs6lD7qSAj5dVvuny1RouN+wl1cicOLfa /W771y/q+Btnw0ijKVBiKHR1hu0C4jPGbN0oahLbc3p6xvRACpBdP2Ehm BYC4aMx16iMzkZ+Y11/UsrTz8S/ZRaJwhExplK6YcvxJWHp8W+vE8hDZX h1k09HciGbxkUQPVkcmpfIEykHUfRgKYgtZN/wbgFiYDUun4oY7YMQQRE bqGrC4bZtSm7PTLMXuwXarPI2Mgu73s8uL+CT581OQeGZH6lisXZvisAx FKdf9i4uGKJ4rlYY5lHoSuNiXKRqMjiZomWMvl7okYlbmS4mktxDDGYDg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="445317285" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="445317285" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 01:36:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="773811742" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="773811742" Received: from haslam-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.49.56]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 01:36:01 -0700 From: Jani Nikula To: Ofir Bitton , Matt Roper In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230907193515.7-1-francois.dugast@intel.com> <20230912002541.GD2706891@mdroper-desk1.amr.corp.intel.com> <23515ffe-c397-21a9-94b5-e28f5b26fd64@habana.ai> <87v8cfd4t7.fsf@intel.com> Date: Thu, 14 Sep 2023 11:35:58 +0300 Message-ID: <87h6nxw3rl.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-xe] [PATCH] drm/xe/uapi: Remove MMIO ioctl X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francois Dugast , Lucas De Marchi , "intel-xe@lists.freedesktop.org" Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 12 Sep 2023, Ofir Bitton wrote: > On 12/09/2023 14:11, Jani Nikula wrote: >> On Tue, 12 Sep 2023, Ofir Bitton wrote: >>> On 12/09/2023 3:25, Matt Roper wrote: >>> Hey Matt, I totally undesrstand your concern, I might have another >>> suggestion. We can create another FD in debugfs and move this ioctl >>> there (I can take ownership on this), This way ABI is not an issue. >> >> FD or ioctl in debugfs? Or do you just mean adding a debugfs file for >> register access? >> >> BR, >> Jani. >> > > Add a new file in debugfs to which we will send debug ioctls such as the > mmio ioctl. It's so rare to do ioctl on debugfs files that I first had to check it's possible, and then try to find examples in the kernel. I found one so far, though there are probably more. If it's that rare, usually the question is, does it make sense? BR, Jani. -- Jani Nikula, Intel