From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D379C02194 for ; Mon, 3 Feb 2025 14:46:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 065D410E510; Mon, 3 Feb 2025 14:46:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="iGrxU8yF"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE3E110E510; Mon, 3 Feb 2025 14:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738593994; x=1770129994; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=YpO1v529RKKL3vHoxGSx62bSIEbYwmYgE0YlW2dyMV4=; b=iGrxU8yFRVG1wwJXgy7R/2tX7X2meKjHreQ27kncxORr28SLk3utxOVr 4eHZZha+pIR3qUm5miXrWbwq5oW1Fat2oO8RjtaObXUjw8TvNTSd7efTH ePztsGrg1ZCASuQoJc0j7H8/gwYnotndaYLbWM/VXe3yVXpABuUrsplXj 7wpOzWubCTeyZijyGZLumNXM8nDBIfw4ICpEZmw2BFPf7gJsC7lxYGU32 EOTe4NuI85uLL8iFpuZFI8TE9Pdo0PduTNGWCerDOQjDIOnNz0vgqZaYs 7KW9uqsp27b1ilB+sLhomGToZIS3Q8VkWt5ywdvRVZxxFSxY5shtGhyE6 A==; X-CSE-ConnectionGUID: CqRHMySKTzulcnOovkBIBg== X-CSE-MsgGUID: fMI+rQGRQVirjxpdTwQdlQ== X-IronPort-AV: E=McAfee;i="6700,10204,11335"; a="49742703" X-IronPort-AV: E=Sophos;i="6.13,256,1732608000"; d="scan'208";a="49742703" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2025 06:46:33 -0800 X-CSE-ConnectionGUID: T9qOx0TzRWW25SZjUc4I5A== X-CSE-MsgGUID: iUVBEVtMRBq7tzZArjaNIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,256,1732608000"; d="scan'208";a="115302792" Received: from lfiedoro-mobl.ger.corp.intel.com (HELO localhost) ([10.245.246.71]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2025 06:46:31 -0800 From: Jani Nikula To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Ankit Nautiyal , stable@vger.kernel.org Subject: Re: [PATCH 01/14] drm/i915/dp: Iterate DSC BPP from high to low on all platforms In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <3bba67923cbcd13a59d26ef5fa4bb042b13c8a9b.1738327620.git.jani.nikula@intel.com> Date: Mon, 03 Feb 2025 16:46:28 +0200 Message-ID: <87ikpr6q7v.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 31 Jan 2025, Imre Deak wrote: > On Fri, Jan 31, 2025 at 02:49:54PM +0200, Jani Nikula wrote: >> Commit 1c56e9a39833 ("drm/i915/dp: Get optimal link config to have best >> compressed bpp") tries to find the best compressed bpp for the >> link. However, it iterates from max to min bpp on display 13+, and from >> min to max on other platforms. This presumably leads to minimum >> compressed bpp always being chosen on display 11-12. >> >> Iterate from high to low on all platforms to actually use the best >> possible compressed bpp. >> >> Fixes: 1c56e9a39833 ("drm/i915/dp: Get optimal link config to have best compressed bpp") >> Cc: Ankit Nautiyal >> Cc: Imre Deak >> Cc: # v6.7+ >> Signed-off-by: Jani Nikula > > Reviewed-by: Imre Deak Thanks for the swift reviews! Pushed the lot to drm-intel-next. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_dp.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c >> index d1b4fd542a1f..ecf192262eb9 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >> @@ -2073,11 +2073,10 @@ icl_dsc_compute_link_config(struct intel_dp *intel_dp, >> /* Compressed BPP should be less than the Input DSC bpp */ >> dsc_max_bpp = min(dsc_max_bpp, output_bpp - 1); >> >> - for (i = 0; i < ARRAY_SIZE(valid_dsc_bpp); i++) { >> - if (valid_dsc_bpp[i] < dsc_min_bpp) >> + for (i = ARRAY_SIZE(valid_dsc_bpp) - 1; i >= 0; i--) { >> + if (valid_dsc_bpp[i] < dsc_min_bpp || >> + valid_dsc_bpp[i] > dsc_max_bpp) >> continue; >> - if (valid_dsc_bpp[i] > dsc_max_bpp) >> - break; >> >> ret = dsc_compute_link_config(intel_dp, >> pipe_config, >> -- >> 2.39.5 >> -- Jani Nikula, Intel