From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A06DC3DA4A for ; Tue, 20 Aug 2024 01:26:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E06110E38C; Tue, 20 Aug 2024 01:26:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="buo+ZtGT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id B42C110E38C for ; Tue, 20 Aug 2024 01:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724117209; x=1755653209; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Hcbyw2oPnulI56A9gRT0sUP58xwudAiO33VhFP6QYhA=; b=buo+ZtGTQz6LBQC/1QOG4KR7WIyLHmG5BWBBiatMRg6gosc/LEskqLds RaP3Ai20yDIoGTRhma9eYqHsyzxEWgGgnHMMZsHiU1EvlTtE32/LlywzB 2Y2EQ+wwqCXBs1fol4zqxTBOxHz/091wXNsmJzeZxS47t1amARY0QOIMp ChDJ3cfb4eZmLsFLwG1MGuvgs9evBxFAqkYPXA5pR/y+ECmqTB1pa7MG4 L/alBQ74JEBsV1A0Pwt85JTzAztXwE4PfUpYg3h9sMzzkMlIeg3hr6wQs aRfsl1fr8lyjE6D7JO5iS6p2omzffNBbKdqWpwgE+Q3UGORjL+wFi7Pin A==; X-CSE-ConnectionGUID: LtpKiF4ESnuQvcBdTniurA== X-CSE-MsgGUID: sOJNteoaSgyuZPgsk1s4CA== X-IronPort-AV: E=McAfee;i="6700,10204,11169"; a="22535697" X-IronPort-AV: E=Sophos;i="6.10,160,1719903600"; d="scan'208";a="22535697" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 18:26:49 -0700 X-CSE-ConnectionGUID: gnipR3hGSWeUOZp5gDAA7A== X-CSE-MsgGUID: Mv8BN6uoRXC3QdRSdNOr7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,160,1719903600"; d="scan'208";a="98018341" Received: from peterval-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.124.114.37]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 18:26:49 -0700 Date: Mon, 19 Aug 2024 18:06:35 -0700 Message-ID: <87ikvwdmuc.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matthew Brost Cc: intel-xe@lists.freedesktop.org, Umesh Nerlige Ramappa , Jose Souza , Lionel Landwerlin Subject: Re: [PATCH 4/8] drm/xe/oa: Add input fence dependencies In-Reply-To: References: <20240808174139.4027534-1-ashutosh.dixit@intel.com> <20240808174139.4027534-5-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 08 Aug 2024 16:25:31 -0700, Matthew Brost wrote: > Hi Matt, > On Thu, Aug 08, 2024 at 10:41:35AM -0700, Ashutosh Dixit wrote: > > Add input fence dependencies which will make OA configuration wait till > > these dependencies are met (till input fences signal). > > > > Signed-off-by: Ashutosh Dixit > > --- > > drivers/gpu/drm/xe/xe_oa.c | 24 +++++++++++++++++++----- > > 1 file changed, 19 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c > > index ba8f2e9d95b7f..416e031ac454b 100644 > > --- a/drivers/gpu/drm/xe/xe_oa.c > > +++ b/drivers/gpu/drm/xe/xe_oa.c > > @@ -578,10 +578,10 @@ static __poll_t xe_oa_poll(struct file *file, poll_table *wait) > > } > > > > static int xe_oa_submit_bb(struct xe_oa_stream *stream, struct xe_bb *bb, > > - struct dma_fence **fence) > > + bool add_deps, struct dma_fence **fence) > > Bools are highly frowned upon [1] (one of many example of this). How > about passing in 'stream->num_syncs' or 0? > > i.e. s/bool add_deps/u32 num_syncs/ > > Maybe even add stream->syncs as argument then too. I don't like this because this function is called from 3 places, 2 of which set the arg to false and only one to true, even if stream->num_syncs > 0. So it will not be clear why we are setting num_syncs to 0 from those 2 places and we will have to add comments pointing that out. Whereas it is clear with the bool and no comments are needed. But I understand the concerns about bool so I have instead converted it into an enum in v2. That I think should take care of most of the objections against bool. Let me know if this is ok or any other ideas regarding this? Thanks. -- Ashutosh > > Matt > > [1] https://patchwork.freedesktop.org/patch/607408/?series=135265&rev=6#comment_1103868 > > > { > > struct xe_sched_job *job; > > - int err = 0; > > + int i, err = 0; > > > > /* Kernel configuration is issued on stream->k_exec_q, not stream->exec_q */ > > job = xe_bb_create_job(stream->k_exec_q, bb); > > @@ -590,9 +590,23 @@ static int xe_oa_submit_bb(struct xe_oa_stream *stream, struct xe_bb *bb, > > goto exit; > > } > > > > + if (add_deps) { > > + for (i = 0; i < stream->num_syncs && !err; i++) > > + err = xe_sync_entry_add_deps(&stream->syncs[i], job); > > + if (err) { > > + drm_dbg(&stream->oa->xe->drm, "xe_sync_entry_add_deps err %d\n", err); > > + goto err_put_job; > > + } > > + } > > + > > xe_sched_job_arm(job); > > *fence = dma_fence_get(&job->drm.s_fence->finished); > > xe_sched_job_push(job); > > + > > + return 0; > > + > > +err_put_job: > > + xe_sched_job_put(job); > > exit: > > return err; > > } > > @@ -670,7 +684,7 @@ static int xe_oa_modify_ctx_image(struct xe_oa_stream *stream, struct xe_lrc *lr > > > > xe_oa_store_flex(stream, lrc, bb, flex, count); > > > > - err = xe_oa_submit_bb(stream, bb, &fence); > > + err = xe_oa_submit_bb(stream, bb, false, &fence); > > xe_bb_free(bb, fence); > > dma_fence_put(fence); > > exit: > > @@ -691,7 +705,7 @@ static int xe_oa_load_with_lri(struct xe_oa_stream *stream, struct xe_oa_reg *re > > > > write_cs_mi_lri(bb, reg_lri, 1); > > > > - err = xe_oa_submit_bb(stream, bb, &fence); > > + err = xe_oa_submit_bb(stream, bb, false, &fence); > > xe_bb_free(bb, fence); > > dma_fence_put(fence); > > exit: > > @@ -971,7 +985,7 @@ static int xe_oa_emit_oa_config(struct xe_oa_stream *stream, struct xe_oa_config > > goto exit; > > } > > > > - err = xe_oa_submit_bb(stream, oa_bo->bb, &fence); > > + err = xe_oa_submit_bb(stream, oa_bo->bb, true, &fence); > > if (err) > > goto exit; > > > > -- > > 2.41.0 > >