From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BD9FC531D0 for ; Mon, 27 Jul 2026 17:27:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B18710E483; Mon, 27 Jul 2026 17:27:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="J5Q4KZME"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7511210E483 for ; Mon, 27 Jul 2026 17:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1785173263; x=1816709263; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=RF+wUYwuIXBVx+XHbJYkn7260jP2NqnS1k69RJ0Vq+4=; b=J5Q4KZME8L3Q9X/5221fP96SQLbEVVOd95VA4lZjxYa6JUqEZjfM7c+s oxiEXYmRdM0hMGxlhHZyXb4u8tOUqcIZ97DZFQTKfdfJ+KVFlqnHxiBv4 JnNZqv6h4bW7HIyn8cyyzSKA2uIaeXKvzRl3Svb54uBt/8ZGSljeyH9nI iN91bb1LQuMUpX5+XWX/X9xz6e9eZn+gLffOF2zeseWPpJZ0DVzM5teEW GKBBgU9rajVDXbeV0djuaBZ7/irm1I6MpCxd8/+Q+iCezDRBniZozzTlU PP3GmhUaGIh3/njm5OJ5zcMO5wWqs17uE7UIoVZZ5DVlVu96P7JqAZYzU g==; X-CSE-ConnectionGUID: tnqu8VORRnek0EyOXMLgyw== X-CSE-MsgGUID: 6mVwwa8uRzmIUJlGGo0bqw== X-IronPort-AV: E=McAfee;i="6800,10657,11858"; a="96410164" X-IronPort-AV: E=Sophos;i="6.25,188,1779174000"; d="scan'208";a="96410164" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2026 10:27:43 -0700 X-CSE-ConnectionGUID: yCeSbwQ4QvOUkVa6+9L1LQ== X-CSE-MsgGUID: ikOfM/DLQAutUX7j45kHSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,188,1779174000"; d="scan'208";a="262955916" Received: from mcapezzu-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.38.25]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2026 10:27:43 -0700 Date: Mon, 27 Jul 2026 10:27:42 -0700 Message-ID: <87jyqg7375.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matt Roper Cc: , Gustavo Sousa Subject: Re: [PATCH 1/2] drm/xe/mcr: Take vcs1/vecs1 into account for first media slice In-Reply-To: <20260724211859.GH2327163@mdroper-desk1.amr.corp.intel.com> References: <20260724201129.2814030-1-ashutosh.dixit@intel.com> <20260724201129.2814030-2-ashutosh.dixit@intel.com> <20260724211859.GH2327163@mdroper-desk1.amr.corp.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 24 Jul 2026 14:18:59 -0700, Matt Roper wrote: > > On Fri, Jul 24, 2026 at 01:11:28PM -0700, Ashutosh Dixit wrote: > > vcs1 and vecs1 may also be present on the first media slice, so take > > vcs1/vecs1 also into account when determining if the first media slice is > > absent. > > > > Bspec: 77977 > > > > Cc: Gustavo Sousa > > Cc: Matt Roper > > Signed-off-by: Ashutosh Dixit > > --- > > drivers/gpu/drm/xe/xe_gt_mcr.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c > > index 9799ffadf85d2..d069d141b54d6 100644 > > --- a/drivers/gpu/drm/xe/xe_gt_mcr.c > > +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c > > @@ -454,9 +454,10 @@ static void init_steering_oaddrm(struct xe_gt *gt) > > { > > /* > > * First instance is only terminated if the entire first media slice > > - * is absent (i.e., no VCS0 or VECS0). > > + * is absent (i.e., no VCS0, VCS1, VECS0 or VECS1). > > */ > > - if (gt->info.engine_mask & (XE_HW_ENGINE_VCS0 | XE_HW_ENGINE_VECS0)) > > + if (gt->info.engine_mask & (XE_HW_ENGINE_VCS0 | XE_HW_ENGINE_VCS1 | > > + XE_HW_ENGINE_VECS0 | XE_HW_ENGINE_VECS0)) > > gt->steering[OADDRM].group_target = 0; > > This change could break other platforms. E.g., a BMG card with VCS1 and > no VCS0 would steer to SCMI 0 based on this, but on BMG each VCS/VECS is > in its own SCMI so we might be steering to a fused off instance. > > We may need to add details about how many engines are grouped into each > SCMI to xe_media_desc and then use that value here. E.g., Xe2_HPM is > 1/1/1 per SCMI (bspec 67103) whereas Xe3p_HPM is 2/2/2 per SCMI (bspec > 77977). Sorry, I missed that, you are right, but I think the problem is only with vecs's not vcs's. Anyway, I believe I have a simple solution in v3, please take a look at that and see if that is sufficient. Thanks. > > > else > > gt->steering[OADDRM].group_target = 1; > > -- > > 2.54.0 > > > > -- > Matt Roper > Graphics Software Engineer > Linux GPU Platform Enablement > Intel Corporation