From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59D3BD5B87E for ; Tue, 16 Dec 2025 01:25:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE54D10E18A; Tue, 16 Dec 2025 01:25:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QMmUF3px"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26C3E10E18A for ; Tue, 16 Dec 2025 01:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765848348; x=1797384348; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=sYgs4np+2Nm+eB5aTAHmMpVw2g1TTpqK16jexsyoXZs=; b=QMmUF3pxlt2fT0J2ln4C4ONNSifluc73huVHDLbkUGRLQ4+6OL9rKCfX wgOpPBCFMFd8EzUu06ppyc5QO9iYIRu3p6LJqO9si7lqRfyA5Ox3V1FMq VGDc6byAnFSEZBfFDmR/NcJhzg9txMTzhJsLE1aehj+4VgKlTKtgsA5uQ BrFk1P/oAZb6+sgznDimxb4Xrke/LueNNebvB/1BSb9e5ipz9jaOi20K9 9SolG26E2Jdd420827fUhgWbWC3fiYcJcJk+SR5N7XsU6FKPfhiO0cVy+ ziuNQhBHr+vMKXUIVNtk/kCekVis2sV0Az2xnIh+JXJT17NuLoJEg2aWR g==; X-CSE-ConnectionGUID: vKUBb8quQEW8sSwQYhynUw== X-CSE-MsgGUID: 06JOdKhKQCSsruRXjeboKA== X-IronPort-AV: E=McAfee;i="6800,10657,11643"; a="70340971" X-IronPort-AV: E=Sophos;i="6.21,152,1763452800"; d="scan'208";a="70340971" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2025 17:25:47 -0800 X-CSE-ConnectionGUID: X3DRAr0HRf+fpU0zVIKs8Q== X-CSE-MsgGUID: qxOcHxeFRjOOMS9l2nJ72w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,152,1763452800"; d="scan'208";a="198367806" Received: from panf-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.48.50]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2025 17:25:47 -0800 Date: Mon, 15 Dec 2025 17:25:45 -0800 Message-ID: <87jyynw73a.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: , Umesh Nerlige Ramappa , Subject: Re: [PATCH 3/3] drm/xe/eustall: Disallow 0 EU stall property values In-Reply-To: <9335d8a0-8d06-4fbd-b855-48dfc2966330@intel.com> References: <20251212061850.1565459-1-ashutosh.dixit@intel.com> <20251212061850.1565459-4-ashutosh.dixit@intel.com> <9335d8a0-8d06-4fbd-b855-48dfc2966330@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 15 Dec 2025 17:18:58 -0800, Harish Chegondi wrote: > > [1 ] > [2 ] > Hi Ashutosh, > > On 12/11/25 22:18, Ashutosh Dixit wrote: > > An EU stall property value of 0 is invalid and will cause a NPD. > > Reported-by: Peter Senna Tschudin > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6453 > > Is this the correct URL? I am unable to access this issue. Likely you will need to log into gitlab to see it. > > Fixes: 1537ec85ebd7 ("drm/xe/uapi: Introduce API for EU stall sampling") > Signed-off-by: Ashutosh Dixit > --- > drivers/gpu/drm/xe/xe_eu_stall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_eu_stall.c b/drivers/gpu/drm/xe/xe_eu_stall.c > index 97dfb7945b7ac..a5c36a317a707 100644 > --- a/drivers/gpu/drm/xe/xe_eu_stall.c > +++ b/drivers/gpu/drm/xe/xe_eu_stall.c > @@ -315,7 +315,7 @@ static int xe_eu_stall_user_ext_set_property(struct xe_device *xe, u64 extension > return -EFAULT; > > if (XE_IOCTL_DBG(xe, ext.property >= ARRAY_SIZE(xe_set_eu_stall_property_funcs)) || > - XE_IOCTL_DBG(xe, ext.pad)) > + XE_IOCTL_DBG(xe, !ext.property) || XE_IOCTL_DBG(xe, ext.pad)) > return -EINVAL; > > idx = array_index_nospec(ext.property, ARRAY_SIZE(xe_set_eu_stall_property_funcs));