From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA1F3C021B5 for ; Mon, 24 Feb 2025 13:44:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 043A810E509; Mon, 24 Feb 2025 13:42:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Dzfj4jNe"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8C4E10E242; Mon, 24 Feb 2025 10:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740394551; x=1771930551; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=IBJgut0mkXcJ9MkV/cWrwLoygn2wW+q0yvQkAW13wrI=; b=Dzfj4jNeZJbp7ltawYa3pnJrxlDzR3i0IFDKwdBTjbepbqDva+X458t/ w9SB9lMlk4D6UhiBk4Bbs4dJKZAuulbGX3gZZExl0JeJWJLCmma46DTYS WXEa781Lq4tRwPYpjgt8oXl54hk+VLEenGrTdQ+Y9PkaY2VkYGc/QUJ3k N0wibu8g2uWtpcrmIWSfZcOaAHlKxVPLhbRguURl9xfuoD9OaAllQvnha V84bFTEInE+avQ0+0cFp5jyj2GfHpjug/oCn8rWgUFAIfcQ1gu1mCaUO8 HtQLLdlG8nKH57LU9vLrVRMwRHvhHqgQt6idXskNdBVMK8Kt+KCcPrryG A==; X-CSE-ConnectionGUID: Kjh/Zfo/RPeTXuwUTLxebw== X-CSE-MsgGUID: qRprBF8PSiytvvBwhhe0Tg== X-IronPort-AV: E=McAfee;i="6700,10204,11354"; a="51771575" X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="51771575" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 02:55:50 -0800 X-CSE-ConnectionGUID: EL8AKFoMSsWr0eetGJC2rQ== X-CSE-MsgGUID: Cmjf1F50SK2arnldMmpq7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="116528671" Received: from mwiniars-desk2.ger.corp.intel.com (HELO localhost) ([10.245.246.133]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 02:55:48 -0800 From: Jani Nikula To: Animesh Manna , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: jouni.hogander@intel.com, jeevan.b@intel.com, Animesh Manna Subject: Re: [PATCH v4 5/8] drm/i915/lobf: Add debug interface for lobf In-Reply-To: <20250224080847.326350-6-animesh.manna@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250224080847.326350-1-animesh.manna@intel.com> <20250224080847.326350-6-animesh.manna@intel.com> Date: Mon, 24 Feb 2025 12:55:44 +0200 Message-ID: <87jz9f7gsv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 24 Feb 2025, Animesh Manna wrote: > Add an interface in debugfs which will help in debugging LOBF > feature. > > v1: Initial version. > v2: > - Remove FORCE_EN flag. [Jouni] > - Change prefix from I915 to INTEL. [Jani] > - Use u8 instead of bool for lobf-debug flag. [Jani] > > Signed-off-by: Animesh Manna > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 51 +++++++++++++++++++ > .../drm/i915/display/intel_display_types.h | 5 ++ > 2 files changed, 56 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c > index 83719ee1721c..5c70677ac3c0 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > @@ -276,6 +276,9 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp, > int waketime_in_lines, first_sdp_position; > int context_latency, guardband; > > + if (intel_dp->alpm_parameters.lobf_debug & INTEL_LOBF_DEBUG_DISABLE) > + return; > + > if (!intel_dp_is_edp(intel_dp)) > return; > > @@ -449,6 +452,51 @@ static int i915_edp_lobf_info_show(struct seq_file *m, void *data) > > DEFINE_SHOW_ATTRIBUTE(i915_edp_lobf_info); > > +static int > +i915_edp_lobf_debug_get(void *data, u64 *val) > +{ > + struct intel_display *display = data; Where do you pass display as data? It's connector? > + struct intel_encoder *encoder; > + int ret = -ENODEV; > + > + for_each_intel_dp(display->drm, encoder) { > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > + > + if (!intel_dp_is_edp(intel_dp)) > + return ret; What is this supposed to do? > + > + // TODO: split to each edp transcoder. What does this mean? > + *val = READ_ONCE(intel_dp->alpm_parameters.lobf_debug); You read this from all intel_dp and combine into one? What? > + ret = 0; > + } > + > + return ret; > +} > + > +static int > +i915_edp_lobf_debug_set(void *data, u64 val) > +{ > + struct intel_display *display = data; > + struct intel_encoder *encoder; > + int ret = -ENODEV; > + > + for_each_intel_dp(display->drm, encoder) { > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > + > + if (!intel_dp_is_edp(intel_dp)) > + return ret; > + > + // TODO: split to each edp transcoder. > + intel_dp->alpm_parameters.lobf_debug = val; > + } > + > + return ret; So this always returns failure? > +} > + > +DEFINE_SIMPLE_ATTRIBUTE(i915_edp_lobf_debug_fops, > + i915_edp_lobf_debug_get, i915_edp_lobf_debug_set, > + "%llu\n"); > + > void intel_alpm_lobf_debugfs_add(struct intel_connector *connector) > { > struct intel_display *display = to_intel_display(connector); > @@ -458,6 +506,9 @@ void intel_alpm_lobf_debugfs_add(struct intel_connector *connector) > connector->base.connector_type != DRM_MODE_CONNECTOR_eDP) > return; > > + debugfs_create_file("i915_edp_lobf_debug", 0644, root, > + connector, &i915_edp_lobf_debug_fops); > + > debugfs_create_file("i915_edp_lobf_info", 0444, root, > connector, &i915_edp_lobf_info_fops); > } > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h > index b78721c451b8..b6ec9a8fadd9 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1808,6 +1808,11 @@ struct intel_dp { > u8 aux_less_wake_lines; > u8 silence_period_sym_clocks; > u8 lfps_half_cycle_num_of_syms; > + > +#define INTEL_LOBF_DEBUG_MODE_MASK 0x0f > +#define INTEL_LOBF_DEBUG_DEFAULT 0x00 > +#define INTEL_LOBF_DEBUG_DISABLE 0x01 > + u8 lobf_debug; Just overly complex still. > } alpm_parameters; > > u8 alpm_dpcd; -- Jani Nikula, Intel