From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61DFCD5CCA5 for ; Wed, 30 Oct 2024 12:25:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E73CC10E08D; Wed, 30 Oct 2024 12:25:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MjzzEr2a"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id EAF9410E051; Wed, 30 Oct 2024 12:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730291130; x=1761827130; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=6BoHKOnCklHPGtYZtFjwPZb1kaUp9/UCaK2WHzvG+rc=; b=MjzzEr2avr86BmT0Xp7Zuy8AZavDjbXBVhQYrXKx1pKW7peDOjbfKCcH IV4JtVPiqkAqyV5uR6ZU9zg7+40j/uE1qtYszkWcKz1HM1VoQx7tcACTh lqucUie37JohtBaFJci9IVz4gArKV43SCtnrRiBHT2m+9sbnSfS48g+m2 V1sReVZ7CoTPnL0hwos+osU2wEtAM9Ah6rvTpIX07ACKwfi/l2DwpAR7A k4gDBrKMcwzgtQ4AtjN7Yh0oO+TsS95t64tDnTAQmCUhhdNaWb2ijT38N ew/wBLVw8cz2YZVIHLI5YPpaPop6fpDe/nR9it+HqoT3mVB/gFuUzd8Ix w==; X-CSE-ConnectionGUID: qEi2HkxxRlaH01GKLM6ngA== X-CSE-MsgGUID: yXq/z1PwQpiCMsi7rBzEnQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="52545778" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="52545778" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2024 05:25:29 -0700 X-CSE-ConnectionGUID: +f3TicRJTZq2NjAptPqMFg== X-CSE-MsgGUID: VkB/78qRQWa3Inerqq6zaA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,245,1725346800"; d="scan'208";a="82405310" Received: from lfiedoro-mobl.ger.corp.intel.com (HELO localhost) ([10.245.246.122]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2024 05:25:26 -0700 From: Jani Nikula To: "Kandpal, Suraj" , "intel-gfx@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" Cc: "ville.syrjala@linux.intel.com" , "Roper, Matthew D" , "De Marchi, Lucas" Subject: RE: [PATCH v3] drm/i915/display: use x100 version for full version and release In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241029155536.753413-1-jani.nikula@intel.com> Date: Wed, 30 Oct 2024 14:25:24 +0200 Message-ID: <87jzdplqvf.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 30 Oct 2024, "Kandpal, Suraj" wrote: >> -----Original Message----- >> From: Intel-gfx On Behalf Of J= ani >> Nikula >> Sent: Tuesday, October 29, 2024 9:26 PM >> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org >> Cc: Nikula, Jani ; ville.syrjala@linux.intel.com;= Roper, >> Matthew D ; De Marchi, Lucas >> >> Subject: [PATCH v3] drm/i915/display: use x100 version for full version = and >> release >> >> Use x100, or ver * 100 + rel, versions for full IP version checks, simil= ar to what >> xe driver does: >> >> - Replace IP_VER(14, 1) inline with 1401, etc. >> >> - Convert DISPLAY_VER_FULL() to DISPLAY_VERx100() >> >> - Convert IS_DISPLAY_VER_FULL() to IS_DISPLAY_VERx100() >> >> - Convert IS_DISPLAY_VER_STEP() to IS_DISPLAY_VERx100_STEP() >> >> This makes ver.rel versions easier to use, follows the xe driver pattern= , and >> drops the dependency on the IP_VER() macro. >> >> v2: Rebase, drop IP_VER() from xe compat headers >> >> v3: Rebase >> >> Cc: Ville Syrj=C3=A4l=C3=A4 >> Acked-by: Matt Roper >> Signed-off-by: Jani Nikula > > LGTM, > Reviewed-by: Suraj Kandpal Thanks for the review, pushed to din. BR, Jani. --=20 Jani Nikula, Intel