Re: [PATCH v3 3/9] drm/i915/pps: only touch the vlv_ members on VLV/CHV

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 18 Sep 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Sep 18, 2024 at 08:47:43PM +0300, Jani Nikula wrote:
>> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
>> index 2d8d911988ab..649dc6ad2278 100644
>> --- a/drivers/gpu/drm/i915/display/intel_pps.c
>> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
>> @@ -472,16 +472,17 @@ void intel_pps_reset_all(struct intel_display *display)
>>  	for_each_intel_dp(display->drm, encoder) {
>>  		struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
>>  
>> -		drm_WARN_ON(display->drm,
>> -			    intel_dp->pps.vlv_active_pipe != INVALID_PIPE);
>> +		if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
>> +			drm_WARN_ON(display->drm,
>> +				    intel_dp->pps.vlv_active_pipe != INVALID_PIPE);
>
> Might make sense to just split this whole function
> into vlv/chv vs. bxt/glk versions. It's called from
> platform specific code only so each caller knows
> which one it wants.

Agreed. Patch on the list [1].

> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Many thanks, pushed to din.

BR,
Jani.


[1] https://lore.kernel.org/r/20240919090427.1859032-1-jani.nikula@intel.com


-- 
Jani Nikula, Intel