From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D285FEE499C for ; Wed, 11 Sep 2024 18:48:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9837610EA7B; Wed, 11 Sep 2024 18:48:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="bgJM56bZ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 94CF810EA7C for ; Wed, 11 Sep 2024 18:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726080532; x=1757616532; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=PQXcBB0vPxos60FP+d8nv3t+9RWTqVHDeQMu5aCILbI=; b=bgJM56bZA+U7uY1GVt2LWiwEidZKho5EyZlO2CFsQxSc2wOW4Ok3WquD AuQ3XxjHVI+dOcNAK859EppmyV396CDEgiUutF4dd+nRl0VRo6+yXpF/+ 436cWYR0cxjTztaKuoFdMMjK8TFRSvPDwxLZrrXYSH3HdkP7LZS53Mo+L rkSQ7nawQF5irovXUNp6iX2//w4L0Y7dsbJKprOu4q5MhA4s2GjoOu+yR 0e/QJq4JcU4RJ1goNJW7G4UTA3qPxYGmmugGGkfPiF/h/eomNjfc4oNH5 drFS/5e+eIL/YfFKikKJpzeoRqTYh5w7WNS/+l8fQus+QepQsS9w5Fwtv A==; X-CSE-ConnectionGUID: IaTzZ6+nSWa2vwrqRPgmNQ== X-CSE-MsgGUID: 4vU9Zn1HSdavCT6IOM/SRQ== X-IronPort-AV: E=McAfee;i="6700,10204,11192"; a="28635706" X-IronPort-AV: E=Sophos;i="6.10,220,1719903600"; d="scan'208";a="28635706" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2024 11:48:51 -0700 X-CSE-ConnectionGUID: pqJa4fSKQNW9Cp09MnmmSw== X-CSE-MsgGUID: Fr57fS9XQrqh4/DmwLfmvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,220,1719903600"; d="scan'208";a="71841308" Received: from soc-pf4jgv8l.clients.intel.com (HELO adixit-arch.intel.com) ([10.24.12.97]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2024 11:48:49 -0700 Date: Wed, 11 Sep 2024 11:48:47 -0700 Message-ID: <87jzfic9gw.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Lucas De Marchi Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH] drm/xe/oa: Enable Xe2+ PES disaggregation In-Reply-To: References: <20240909165933.2638765-1-ashutosh.dixit@intel.com> <87wmjjyqe5.wl-ashutosh.dixit@intel.com> <87ttemzsqr.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 11 Sep 2024 08:58:30 -0700, Lucas De Marchi wrote: > > On Tue, Sep 10, 2024 at 10:03:56PM GMT, Ashutosh Dixit wrote: > > On Tue, 10 Sep 2024 17:57:59 -0700, Lucas De Marchi wrote: > >> > >> On Tue, Sep 10, 2024 at 05:40:02PM GMT, Ashutosh Dixit wrote: > >> > On Tue, 10 Sep 2024 10:04:32 -0700, Lucas De Marchi wrote: > >> >> > >> > > >> > Hi Lucas, > >> > > >> > We had a whole email thread to figure this out :/ > >> > > >> >> On Mon, Sep 09, 2024 at 09:59:33AM GMT, Ashutosh Dixit wrote: > >> >> > Xe2+ PES disaggregation for OAG needs to be enabled to obtain disaggregated > >> >> > metrics when disaggregated data is needed. There is no uapi impact of this > >> >> > >> >> it looks like the *control* for disaggregated data is only available on > >> >> xe2 > >> > > >> > Correct, that is why the check below (also this is available only for OAG, > >> > not say for OAM): > >> > > >> > if (GRAPHICS_VER(stream->oa->xe) >= 20 && > >> > stream->hwe->oa_unit->type == DRM_XE_OA_UNIT_TYPE_OAG) > >> > > >> >> and we always use disaggregated, right? > >> > > >> > No we don't, please see below. > >> > > >> >> > >> >> > change. > >> >> > > >> >> > v2: Minor change to commit message > >> >> > > >> >> > Bspec: 61101 > >> >> > >> >> "Note: After enabling desired disaggregation mode/s using this control > >> >> field, PES MODE_SELECT field is used to configure appropriate > >> >> disaggregation mode of corresponding PEC." > >> >> > >> >> Apparently MODE_SELECT == Aggregated is the hw default for xe2. Don't > >> >> we need to program anything else? > >> > > >> > So the code in this patch only enables disaggregation, this additional step > >> > (PES_MODE_SELECT) is still needed to actually use disaggregation. However > >> > this second step is done via OA configurations which come in from userspace > >> > (using add_config observation stream op). So userspace can request either > >> > aggregated or disaggregated data depending on the OA config it programs. > >> > > >> > The goal of this patch is only to enable disaggregation so userspace can > >> > use it if they want, otherwise they can't, they can only use > >> > aggregated. > >> > >> can you add a paragraph to the commit message stating something like > >> above? Because it was not clear it was intentional to enable it in the > >> control and not in the PES_MODE_SELECT. > > > > I have changed the commit message to the following: > > > > " > > Enable Xe2+ PES disaggregation (for OAG) to retrieve disaggregated metrics > > when disaggregated data is needed. Userspace can select whether to receive > > aggregated or disaggregated metrics via the particular OA configuration it > > uses (programmed via DRM_XE_OBSERVATION_OP_ADD_CONFIG). > > " > > looks good to me. Thanks, patch is now merged to drm-xe-next. Ashutosh