From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8A61C4167B for ; Sat, 9 Dec 2023 22:58:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D88E10E2F1; Sat, 9 Dec 2023 22:58:28 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E37A10E2F1 for ; Sat, 9 Dec 2023 22:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702162707; x=1733698707; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=VOicg/QlLO+iNW1yLJ4NHX9Rv8fP9epBk2O3DLkUjdU=; b=Ds7KR7lfU6HDTsQ1aILdWOPa6LT56PLtlMt3yQeoaH+zQvVHEsZKy6p9 OnnuT0wNLPiFQ5T0PohR+lulp2VAOjtrj6XvfaYTpkqJne+gypl4BtQEc sSRnn/ozIL6HE77N+pW9eCVKpBwWlcT3ARDkoa2RfVKJK7yec9p36GdUK L8QELe6px3j7A2DF2Z7ihm+arqMY63tWsrJELtJUPjqI5RRHZ0GNOoRbJ psV6hXRt8fGAa1AnWnAmovoE8EBd3CCCGEmFCE+GAwJBrGDOe/6MVTB6x Q4DK4oGtYsa0zcV5rIuD+6bAKk4qvZBryb7eLjQTmhLeIKQDh3EK2Eq+r Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="393393349" X-IronPort-AV: E=Sophos;i="6.04,264,1695711600"; d="scan'208";a="393393349" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2023 14:58:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="748739082" X-IronPort-AV: E=Sophos;i="6.04,264,1695711600"; d="scan'208";a="748739082" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.219.31]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2023 14:58:26 -0800 Date: Sat, 09 Dec 2023 14:58:26 -0800 Message-ID: <87jzpnhtkd.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-xe@lists.freedesktop.org Subject: Re: [PATCH] drm/xe/pmu/uapi: Remove PMU group busyness events from uapi In-Reply-To: <87o7f0i2hs.wl-ashutosh.dixit@intel.com> References: <20231209000233.2577418-1-ashutosh.dixit@intel.com> <87o7f0i2hs.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: francois.dugast@intel.com, Lucas De Marchi , Rodrigo Vivi Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 08 Dec 2023 17:33:19 -0800, Dixit, Ashutosh wrote: > > On Fri, 08 Dec 2023 16:02:33 -0800, Ashutosh Dixit wrote: > > > > PMU group busyness uapi is likely to change in the future. Till the uapi is > > decided remove the uapi from xe_drm.h. To not break the build retain the > > events internally in xe_pmu.c for now. > > This gets the job done of getting the PMU stuff out of the uapi, but not > sure if moving the defines in xe_pmu.c is ugly? The other easy option is to > just delete everything (maybe drop all PMU patches in a rebase). Later add > it back when some valid PMU stuff is added again. > > Deleting the uapi but retaining the PMU infrastructure is a chore. I'd say > do something like this patch, or delete everything and start over. Deleting everything is done here: https://patchwork.freedesktop.org/series/127598/