Re: [PATCH 1/2] drm/xe/tests: Fix default subplatform selection

[Gustavo Sousa <gustavo.sousa@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> writes:

> If a test does not specify details about the fake device it wants
> to create, our helper selects the device descriptor from the first
> entry from the pciidlist and uses NULL for the subplatform descriptor.
> While this works fine today, as the first device is a TGL which does
> not have any subplatforms, it will be broken if we reorder pciidlist.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
>  drivers/gpu/drm/xe/tests/xe_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
> index bb0393475524..a82cab7a2b86 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci.c
> +++ b/drivers/gpu/drm/xe/tests/xe_pci.c
> @@ -351,7 +351,7 @@ int xe_pci_fake_device_init(struct xe_device *xe)
>  
>  	if (!data) {
>  		desc = (const void *)ent->driver_data;

Should we add a comment here that subplatform_desc will be either NULL
or the first declared subplatform?

In any case,

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

> -		subplatform_desc = NULL;
> +		subplatform_desc = desc->subplatforms;
>  		goto done;
>  	}
>  
> -- 
> 2.47.1