From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-xe@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v3] drm/xe: Document nested struct members according to guidelines
Date: Tue, 23 Jan 2024 19:46:28 +0200 [thread overview]
Message-ID: <87le8glz7v.fsf@intel.com> (raw)
In-Reply-To: <20240123153147.27305-1-thomas.hellstrom@linux.intel.com>
On Tue, 23 Jan 2024, Thomas Hellström <thomas.hellstrom@linux.intel.com> wrote:
> Document nested struct members with full names as described in
> Documentation/doc-guide/kernel-doc.rst.
...
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 7eda86bd4c2a..eb2b806a1d23 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -143,10 +143,10 @@ struct xe_tile {
> * * 8MB-16MB: global GTT
> */
> struct {
> - /** @size: size of tile's MMIO space */
> + /** @mmio.size: size of tile's MMIO space */
> size_t size;
>
> - /** @regs: pointer to tile's MMIO space (starting with registers) */
> + /** @mmio.regs: pointer to tile's MMIO space (starting with registers) */
> void __iomem *regs;
> } mmio;
>
I really wish you could just do:
/** Documentation of foo member */
int foo;
to document the following member, instead of having to repeat every
single member name everywhere. kernel-doc has all the info to do this,
but I never want to touch that perl script again...
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2024-01-23 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 15:31 [PATCH v3] drm/xe: Document nested struct members according to guidelines Thomas Hellström
2024-01-23 16:13 ` ✗ CI.Patch_applied: failure for drm/xe: Document nested struct members according to guidelines (rev3) Patchwork
2024-01-23 17:46 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le8glz7v.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox