From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/xe: drop display/ subdir from include directories
Date: Mon, 22 Jan 2024 19:39:56 +0200 [thread overview]
Message-ID: <87le8hnu6r.fsf@intel.com> (raw)
In-Reply-To: <47hzp5ya6cwdcidq7cwid5ykpkn6wavxtf3ynjf3xgirbgulsc@afsk7pgae3lx>
On Mon, 22 Jan 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> the downside of patch 1 is now that core xe code can include any of the
> display/ headers, but only xe_display.h is acceptable to keep the
> interface sane.
I'd say xe_display.h remains the only interface towards xe core, I don't
think this patch changes that, and its location doesn't really give any
guarantees. It's been a matter of sticking display/ in the include
anyway, and enforcing that is a matter of maintainer vigilance.
> Or are you thinking about changing the interface?
I agree the interface should be in one file only, but changing the
interface is an orthogonal matter (I have no plans atm).
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-01-22 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 10:14 [PATCH 1/2] drm/xe: move xe_display.[ch] under display/ Jani Nikula
2024-01-22 10:14 ` [PATCH 2/2] drm/xe: drop display/ subdir from include directories Jani Nikula
2024-01-22 16:58 ` Rodrigo Vivi
2024-01-22 17:19 ` Lucas De Marchi
2024-01-22 17:39 ` Jani Nikula [this message]
2024-01-23 16:49 ` Lucas De Marchi
2024-01-23 17:13 ` Jani Nikula
2024-01-30 9:19 ` Jani Nikula
2024-01-30 17:32 ` Lucas De Marchi
2024-01-31 13:47 ` Jani Nikula
2024-01-22 16:59 ` [PATCH 1/2] drm/xe: move xe_display.[ch] under display/ Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le8hnu6r.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox