From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FA02C4167B for ; Sat, 9 Dec 2023 22:53:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F337A10E0E4; Sat, 9 Dec 2023 22:53:14 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id D37BA10E0E4 for ; Sat, 9 Dec 2023 22:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702162394; x=1733698394; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=qKPS63iWORggREqlR3gUbNujzgrnYjhEzLwgGpUTL5g=; b=kNM325Ju3X3hiNYP/dErMDzG3kAX0rXBUueUQ1JnCSnI42uFysWIylZv xoQir/9L4h3KZ5hDgKnJ9KorOeJcjtpI4Ea9uDkLUCX6dGPQuhVxLQZ2M 8batqeatzNFgWkoXVYx5jGuseB6TnCz93OdrMfl6CGun/Fl96mXzdoLqO KiwXUAFyNojXqECFRY9zNjscOGMO8eQY3B/TpVLkPA69ofm1mjT878Fpa SjL6tCwM4Tbz+rfbTq4I6gNbUezuciPiSC/8pyzbUgnyXNLnFpVLRM3hB qHP4LdgwNh0QMShBe5KowhDXEctZYEESMmEKMvbUWAFQNhN+G/QirdWd+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="1651262" X-IronPort-AV: E=Sophos;i="6.04,264,1695711600"; d="scan'208";a="1651262" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2023 14:53:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10919"; a="916345941" X-IronPort-AV: E=Sophos;i="6.04,264,1695711600"; d="scan'208";a="916345941" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.219.31]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2023 14:53:13 -0800 Date: Sat, 09 Dec 2023 14:53:12 -0800 Message-ID: <87lea3htt3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 07/17] drm/xe/oa/uapi: Define and parse OA stream properties In-Reply-To: <20231208064329.2387604-8-ashutosh.dixit@intel.com> References: <20231208064329.2387604-1-ashutosh.dixit@intel.com> <20231208064329.2387604-8-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Harish Chegondi Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 07 Dec 2023 22:43:19 -0800, Ashutosh Dixit wrote: > > +/** > + * struct drm_xe_oa_open_param - Params for opening an OA stream > + * > + * Stream params are specified as a chain of @drm_xe_ext_set_property > + * struct's, with @property values from enum @drm_xe_oa_property_id and > + * @xe_user_extension base.name set to @DRM_XE_OA_EXTENSION_SET_PROPERTY > + */ > +struct drm_xe_oa_open_param { > +#define DRM_XE_OA_EXTENSION_SET_PROPERTY 0 > + /** @extensions: Pointer to the first extension struct */ > + __u64 extensions; > +}; Harish pointed out that this struct is not really needed. We might as well point the @param field in struct @drm_xe_perf_param to the first @drm_xe_ext_set_property struct. I'll make this change in the next revision. Thanks Harish.