From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 754BCCDB466 for ; Wed, 11 Oct 2023 17:34:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B2F710E00B; Wed, 11 Oct 2023 17:34:20 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AAE610E00B for ; Wed, 11 Oct 2023 17:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697045657; x=1728581657; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=uKhoGwQe1Mvfa+IivZja7y9InrkbzdTmQQCnSIdCTo0=; b=MTehHhMNjL2TlnXwTPjGG8iIs+MBv/H7dMY7PAHF7C0EF93UtRklbXd6 6HUTBYxFcmNxMVus+7GoO9MhjWpkVm5NKDjdLUQBAe0Boeiobu9bvThrY kZnWueBDnpnClW8jZVfhUk5Af+3QyAD8YZLqpwsxdmIGdeLvCJBJUUm3w kn5Ge0sW4poP1ll+48rzlfQInOGMoqUYzq+wO/GQnxlZvuhf0+33QeJMH 4ecqELZQqrgUycN3Hv3i8RkGFH1QqXFxd3hhBAyePS/WJ1VAd8pCCQ95o HGS9SvQZ2Kyzc4/8lA4myFHbOfOeRp1O8qB5t42Y+u/aMeMiFzWD3nUVB Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="388590961" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="388590961" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 10:34:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="1001221467" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="1001221467" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.86.151]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 10:34:06 -0700 Date: Wed, 11 Oct 2023 10:33:32 -0700 Message-ID: <87lec9t66r.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Guy Zadicario In-Reply-To: References: <20231009222409.620443-1-ashutosh.dixit@intel.com> <20231009222409.620443-3-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-xe] [PATCH 2/2] drm/xe/uapi: Multiplex PERF ops through a single PERF ioctl X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 11 Oct 2023 04:24:21 -0700, Guy Zadicario wrote: > Hi Guy, > > Replying to you only since I do not have access to my mailbox from > text-based email client (trying to get there but IT guys runs me crazy = =E2=98=B9) > I wasn't sure if reply from outlook work ok, is it? Once in a while is ok, but if you are going to respond regularly on the mailing list, a text based email client is preferable. > > The only comment I have is that enum @drm_xe_perf_op includes operations > on a perf stream fd only and not operations on the main perf ioctl. Do > we want to merge both types of operations in the same enum? If so, you > need to add to that enum operations for OPEN,ADD_CONFIG,REMOVE_CONFIG. You are absolutely right, I missed out on adding 'enum drm_xe_perf_op' which was there in the original OA series. I've added it in v2 and also cleaned up the naming and some other minor changes. The perf fd ioct's are in a separate 'enum drm_xe_perf_ioctls'. https://patchwork.freedesktop.org/series/124994/ Thanks so much. -- Ashutosh