From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20C35C77B75 for ; Fri, 5 May 2023 18:04:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4BBA10E654; Fri, 5 May 2023 18:04:09 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9092110E654 for ; Fri, 5 May 2023 18:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683309846; x=1714845846; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=qdrWHeFdTkTH64NCpGoKGpyeX4Y1dPXYMVBi38E6CEg=; b=miFvT7gyr3IA/7nyCmy6zcn7d0W2tq23IZBgWs+XHyDvDcTWyz/SSRO1 t6NsYDLstvxiM/A4FpkhLVrHnhJR3JGi1j18Ji5T9MsoriXsRtcBXyVii aJyzYRe5x/TMGGyBCTIXDTCzz3BtBCmmSbFZjcRkWIiZ3ceMyDkoa105g 8POL2FMCFikrIcD2DYypqacIvwTWelB5YBprRos6Zra6I9Sjsk5/H+6Hh yJGLNtaukausP8Afz8Y+2JQHY9cIwlrA2L9S/bLz6Pcc57JN+9RJpPtX6 OZ+lfs9G1+e3UvPzl6Ot2D5zhDxUGxpMEQrG8KNRli8yEt6s6ABo4Qy3e g==; X-IronPort-AV: E=McAfee;i="6600,9927,10701"; a="333697284" X-IronPort-AV: E=Sophos;i="5.99,252,1677571200"; d="scan'208";a="333697284" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2023 11:03:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10701"; a="675185345" X-IronPort-AV: E=Sophos;i="5.99,252,1677571200"; d="scan'208";a="675185345" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.109.254]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2023 11:03:44 -0700 Date: Fri, 05 May 2023 11:03:46 -0700 Message-ID: <87lei2y7st.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: References: <20230504112020.300498-1-tejas.upadhyay@intel.com> <20230504112020.300498-4-tejas.upadhyay@intel.com> <7aa6147f-752b-27b1-9f4c-667a3d457b51@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH 3/3] drm/xe: Add sysfs entry to report per gt memory size X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Upadhyay, Tejas" , "intel-xe@lists.freedesktop.org" , "Vivi, Rodrigo" Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 05 May 2023 07:40:33 -0700, Rodrigo Vivi wrote: > > > > > @@ -50,9 +114,15 @@ int xe_gt_sysfs_init(struct xe_gt *gt) > > > > > > > > gt->sysfs = &kg->base; > > > > > > > > + gt->sysfs_defaults = kobject_create_and_add(".defaults", gt->sysfs); > > > > > > what is the use of defaults?? > > > > No use. There is no use I saw in i915 as well. But may be for some > > future use it is kept. Or I missed something. If want to remove, can be > > removed on objections. > > Cc: Ashutosh > > The defaults is used in i915 so Level-0/Sysman can perform the > restore_defaults operation. > > I believe it is a useful feature... Yeah for RW sysfs attributes, i915 had the convention of exposing default values in /sys/class/.../.defaults (look at intel_gt_sysfs.c and sysfs_engines.c) so userland can restore default values if sysfs attributes had been previously modified. Level 0 was doing this in some cases. For xe, we can do the same or something different I guess. Also, are we going to re-create sysfs as done in this series or use something like hwmon (it was being debated)? Thanks. -- Ashutosh