From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEEC4C43458 for ; Tue, 7 Jul 2026 22:31:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77A0010E394; Tue, 7 Jul 2026 22:31:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GAnof9qN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDE9F10E394 for ; Tue, 7 Jul 2026 22:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783463494; x=1814999494; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=GloIx2Dzc7UX/jNXTMW3gu0+7caihL/zaVYSboFTVY0=; b=GAnof9qNaIZ1Ou54kh/nCnFWbqkE46AWRRAP62GpkqwKQkLwclebR+iQ kzivDvdjXAf7rqwNndgl8LRma12Qq8E4qK+M6vxB+1W8om5WV8C01ypqh 69w9t3a3Ht8E6zw09x/e+u726YgNPAf7bXRBieU/2J6mh8H3+aWtYCeu0 wrqh7p13PVEa2YSguBViaZ96cV1pczweRycTIR5dJPel2M4z0oVl9XWIA yH/XCmocd1JRxoBNsEi9UIPaNSkXrgE9WVlehlXUd2ifHOjx9O3B6uOlk O+kpGlKA5mGYJEPl8/BbvuFWC5Frs5jt6iMuxRFh8pQl8TZfhdUcw/4rs Q==; X-CSE-ConnectionGUID: 9ldIx0+BTra1/CyRkZ4Olw== X-CSE-MsgGUID: tlxu8oYFRbK/R09AUGC9Xw== X-IronPort-AV: E=McAfee;i="6800,10657,11840"; a="87943745" X-IronPort-AV: E=Sophos;i="6.25,153,1779174000"; d="scan'208";a="87943745" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2026 15:31:33 -0700 X-CSE-ConnectionGUID: ZB/zy772SH2oOsodsr4kGw== X-CSE-MsgGUID: RHmLAD9zT2meiuSW+im58A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,153,1779174000"; d="scan'208";a="277321221" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.241.243.134]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2026 15:31:33 -0700 Date: Tue, 07 Jul 2026 15:31:28 -0700 Message-ID: <87mrw2whxb.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matt Roper Cc: Umesh Nerlige Ramappa , Subject: Re: [PATCH v2 2/4] drm/xe/oa: Fix offset alignment for MERT WHITELIST_OA_MERT_MMIO_TRG In-Reply-To: <20260707221525.GA80957@mdroper-desk1.amr.corp.intel.com> References: <20260617015422.226177-1-ashutosh.dixit@intel.com> <20260617015422.226177-3-ashutosh.dixit@intel.com> <87fr25jore.wl-ashutosh.dixit@intel.com> <85mrwdqmos.wl-ashutosh.dixit@intel.com> <20260707221525.GA80957@mdroper-desk1.amr.corp.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 07 Jul 2026 15:15:25 -0700, Matt Roper wrote: > > On Mon, Jun 29, 2026 at 10:30:11AM -0700, Dixit, Ashutosh wrote: > > On Mon, 29 Jun 2026 09:27:17 -0700, Dixit, Ashutosh wrote: > > > > > > On Thu, 25 Jun 2026 16:10:31 -0700, Umesh Nerlige Ramappa wrote: > > > > > > > > On Tue, Jun 16, 2026 at 06:54:20PM -0700, Ashutosh Dixit wrote: > > > > > 'tail_buf' argument for WHITELIST_OA_MERT_MMIO_TRG was previously > > > > > wrong (not multiple of 16). Fix this. > > > > > > > > > > Fixes: ec02e49f21bc ("drm/xe/rtp: Whitelist OAMERT MMIO trigger registers") > > > > > Signed-off-by: Ashutosh Dixit > > > > > > > > Note that the SW whitelist needs to be documented in the relevant spec > > > > sections here: BSpec 53688. Can you please have something to track that? > > > > > > Sure I will do this. > > > > > > > With that this is: > > > > > > > > Reviewed-by: Umesh Nerlige Ramappa > > > > > > Thanks! > > > > I have separated this patch out, since this is a bug-fix which also needs > > to be propagated to previous kernels: > > This should not have been propagated to previous kernels. OAMERT does > not exist on any platforms until CRI, and CRI is still in the process of > being enabled behind force_probe protection so we should not be creating > unwanted churn by backporting changes like this that don't do anything. Ok, though the patch will only apply to 7.0 and later. But it's an obvious bug fix so I thought might as well. > > https://patchwork.freedesktop.org/series/169445/ > > > > We can continue to review the remaining patches here, since they are not as > > urgent. > > > > Thanks. > > -- > > Ashutosh > > > > > > > > > > > > > > > > > > --- > > > > > drivers/gpu/drm/xe/xe_reg_whitelist.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/xe/xe_reg_whitelist.c > > > > > index a17ebacc1455b..880079473c26b 100644 > > > > > --- a/drivers/gpu/drm/xe/xe_reg_whitelist.c > > > > > +++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c > > > > > @@ -124,7 +124,7 @@ static const struct xe_rtp_table_sr register_whitelist = XE_RTP_TABLE_SR( > > > > > OAM_HEAD_POINTER(XE_OAM_SCMI_1_BASE_ADJ)) > > > > > > > > > > #define WHITELIST_OA_MERT_MMIO_TRG \ > > > > > - WHITELIST_OA_MMIO_TRG(OAMERT_MMIO_TRG, OAMERT_STATUS, OAMERT_HEAD_POINTER) > > > > > + WHITELIST_OA_MMIO_TRG(OAMERT_MMIO_TRG, OAMERT_STATUS, OAMERT_TAIL_POINTER) > > > > > > > > > > { XE_RTP_NAME("oag_mmio_trg_rcs"), > > > > > XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, XE_RTP_END_VERSION_UNDEFINED), > > > > > -- > > > > > 2.54.0 > > > > > > > -- > Matt Roper > Graphics Software Engineer > Linux GPU Platform Enablement > Intel Corporation