Re: [PATCH] drm/xe/oa: Fix exec_queue leak on width check in stream open

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 14 May 2026 13:32:10 -0700, Shuicheng Lin wrote:
>
> In xe_oa_stream_open_ioctl(), when param.exec_q->width > 1 the
> function returns -EOPNOTSUPP directly, skipping the existing
> err_exec_q cleanup path. The exec_queue reference obtained by
> xe_exec_queue_lookup() is leaked.
>
> The exec queue holds a reference on the xe_file, which is only
> dropped during queue teardown. The leaked lookup ref is not on
> the file's exec_queue xarray, so file close cannot release it.
> This keeps both the exec queue and the file private state pinned
> indefinitely.
>
> Jump to err_exec_q instead of returning directly so the reference
> is released.
>
> Fixes: f0ed39830e60 ("xe/oa: Fix query mode of operation for OAR/OAC")
> Assisted-by: Claude:claude-opus-4.6
> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> ---
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_oa.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index 7c9071abb44f..4bf4b1f65929 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -2051,8 +2051,10 @@ int xe_oa_stream_open_ioctl(struct drm_device *dev, u64 data, struct drm_file *f
>		if (XE_IOCTL_DBG(oa->xe, !param.exec_q))
>			return -ENOENT;
>
> -		if (XE_IOCTL_DBG(oa->xe, param.exec_q->width > 1))
> -			return -EOPNOTSUPP;
> +		if (XE_IOCTL_DBG(oa->xe, param.exec_q->width > 1)) {
> +			ret = -EOPNOTSUPP;
> +			goto err_exec_q;
> +		}
>	}
>
>	/*
> --
> 2.43.0
>