From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F5EFC3ABD8 for ; Sat, 17 May 2025 00:11:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B4AB610EBC0; Sat, 17 May 2025 00:11:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HuTDIV0Y"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AD1C10EBBD for ; Sat, 17 May 2025 00:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747440662; x=1778976662; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=1Rf8ym2n5/UvLk9B02dbB8D+cPnM3KmL3PloKcvGDlA=; b=HuTDIV0YQnplpOmUUQ4spT1NHmi/2DfBIuRZKFSZiJ8NSiD83ZSN7Akk fQrYgXB/ndn3Cud17sfZBte+ZxffX7I2zjwy3tfgpMPJHBiNtdnlTd6fo e9sPvtVjrylkAsOP6J8dR8H92S2aviV7pwe7LpC0yzxdcZIGpbc+099oX ZxBJllSlEgwlHIPUAV+gCtOLm3gydVbQ/oFy/w0dvVXFnl6tVvqe6xHH+ glUvIYd33F/Qm3CNyVpou4Mxahj/7YwiYNvEbJy0dFVZHg5OJjDDm+cBv Aw7/tgY4QLQlLVRhTIGfggxsMmJIYjJfhVL9Hr/9HA077T5A76vdUSKkm g==; X-CSE-ConnectionGUID: NQqrJV6MSiqNmOv7S0fNxA== X-CSE-MsgGUID: KZS6wS8FTAunDCMAMBn2rA== X-IronPort-AV: E=McAfee;i="6700,10204,11435"; a="66832993" X-IronPort-AV: E=Sophos;i="6.15,295,1739865600"; d="scan'208";a="66832993" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2025 17:10:59 -0700 X-CSE-ConnectionGUID: y8MKbnXqRQmLmKQfkibcIA== X-CSE-MsgGUID: VYSPMysRRoK+Kk0XECuTrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,295,1739865600"; d="scan'208";a="139852433" Received: from hhitiham-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.89.146]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2025 17:10:59 -0700 Date: Fri, 16 May 2025 17:10:58 -0700 Message-ID: <87msbc6qr1.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-xe@lists.freedesktop.org Cc: Umesh Nerlige Ramappa Subject: Re: [PATCH v2] drm/xe/oa: Expose media OA units In-Reply-To: <20250516204750.2135983-2-ashutosh.dixit@intel.com> References: <20250516204750.2135983-2-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 16 May 2025 13:47:51 -0700, Ashutosh Dixit wrote: > > static u32 __hwe_oam_unit(struct xe_hw_engine *hwe) > { > - if (GRAPHICS_VERx100(gt_to_xe(hwe->gt)) >= 1270) { > - /* > - * There's 1 SAMEDIA gt and 1 OAM per SAMEDIA gt. All media slices > - * within the gt use the same OAM. All MTL/LNL SKUs list 1 SA MEDIA > - */ > - xe_gt_WARN_ON(hwe->gt, hwe->gt->info.type != XE_GT_TYPE_MEDIA); > + if (GRAPHICS_VERx100(gt_to_xe(hwe->gt)) < 1270) > + return 0; Will change this to 'return XE_OA_UNIT_INVALID;' in the next revision. > static int xe_oa_init_oa_units(struct xe_oa *oa) > { > struct xe_gt *gt; > int i, ret; > > + /* Needed for OAM implemenation here */ Will also fix the implementation spelling flagged by checkpatch in the next revision. Thanks. -- Ashutosh