From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 598CFC27C79 for ; Thu, 20 Jun 2024 18:03:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D25F610E161; Thu, 20 Jun 2024 18:03:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SDsfm+T0"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD75610E161 for ; Thu, 20 Jun 2024 18:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718906604; x=1750442604; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=BmlZwDxU1vhhovnwj/BzoK4CQJTEs+JSaipoTgw1oYc=; b=SDsfm+T0I0yAadkZP0f5DW77OAgUu19omCViDh+qiZ3WlkL9xF3QB/hU 35d8tyMqCa+7b2cqDt5IcMb7tqKSQkwq3/mUA1YrU8UEorack9uuJ/RO/ ZQcaGiAMESScIYqK+MdMecsH0kXs3LNS/SWmgD3HS7k0xxftiBodqkeS+ FUtY4L6dtROIoomJFR5mgofDSBJosDFNVRYC1NmQ0e/5KCUtXypvH3Yif hI2sGh+xE6T5ZsdAMK1xQYZlep2fptNIP0dBrRiZPOivzluZMtu4iswjD GWE7UlqzvxJg77/u9/snuobyq6Tq69uXliIrNC+Mqo2UfhdFFibMriC+b Q==; X-CSE-ConnectionGUID: wgDiSJF4Qpmrb8Vumc3jwg== X-CSE-MsgGUID: nVcoYCpRRDCJslgf4d1zCg== X-IronPort-AV: E=McAfee;i="6700,10204,11109"; a="27318360" X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="27318360" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 11:03:02 -0700 X-CSE-ConnectionGUID: WYk5M4DvSoiJ2D2tHsHXmA== X-CSE-MsgGUID: XpomSPzzTOC3m0V2DXC0pA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="42430986" Received: from vishrutm-mobl11.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.97.201]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 11:03:02 -0700 Date: Thu, 20 Jun 2024 10:57:17 -0700 Message-ID: <87msnfqyyq.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matt Roper Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 03/17] drm/xe/oa/uapi: Add OA data formats In-Reply-To: <20240620172846.GM2906448@mdroper-desk1.amr.corp.intel.com> References: <20240527014333.603914-1-ashutosh.dixit@intel.com> <20240527014333.603914-4-ashutosh.dixit@intel.com> <20240620172846.GM2906448@mdroper-desk1.amr.corp.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 20 Jun 2024 10:28:46 -0700, Matt Roper wrote: > > > @@ -636,10 +637,14 @@ int xe_device_probe(struct xe_device *xe) > > > > xe_heci_gsc_init(xe); > > > > - err = xe_display_init(xe); > > + err = xe_oa_init(xe); > > if (err) > > goto err_irq_shutdown; > > > > + err = xe_display_init(xe); > > + if (err) > > + goto err_oa_fini; > > + > > err = drm_dev_register(&xe->drm, 0); > > if (err) > > goto err_fini_display; > > I didn't really look at this series earlier, but it seems odd to me that > we're sticking a bunch of OA code at the device level. Isn't OA a > GT-specific concept? As far as I know, there's no observability > functionality in the soci/sgunit/display. That's correct, there is no OA HW at device level and a GT can potentially have multiple OA units. But OA configuration information (which perf counters to capture) and format information (format of the OA data) is applicable to multiple OA units spread across GT's and is maintained at device level. Look at OA data struct's in xe_oa_types.h, specially 'struct xe_oa' which contains OA device level information. Ashutosh