Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Shuicheng Lin <shuicheng.lin@intel.com>, linux-doc@vger.kernel.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v4] scripts/kernel-doc: Detect mismatched inline member documentation tags
Date: Fri, 15 May 2026 08:42:18 -0600	[thread overview]
Message-ID: <87o6igpwdx.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260507023232.4108680-1-shuicheng.lin@intel.com>

Shuicheng Lin <shuicheng.lin@intel.com> writes:

> Add validation in check_sections() to verify that inline member
> documentation tags (/** @member: description */) match actual struct/union
> member names. Previously, kernel-doc only validated section headers against
> the parameter list, but inline doc tags stored in parameterdescs were never
> cross-checked, allowing stale or mistyped member names to go undetected.
>
> The new check iterates over parameterdescs keys and warns about any that
> don't appear in the parameter list, catching issues like renamed struct
> members where the documentation tag was not updated to match.
>
> This catches real issues such as:
>   - xe_bo_types.h: @atomic_access (missing struct prefix, should be
>     @attr.atomic_access)
>   - xe_device_types.h: @usm.asid (member is actually asid_to_vm)

Sigh ... naturally this adds a number of docs-build warnings, but they
do seem to be legit.  So I've applied it, thanks.

In the future, please copy the maintainer(s) on your patches;
scripts/get_maintainer.pl should have told you to do that.  I almost
missed this one entirely.

jon

      parent reply	other threads:[~2026-05-15 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  2:32 [PATCH v4] scripts/kernel-doc: Detect mismatched inline member documentation tags Shuicheng Lin
2026-05-07  2:43 ` ✓ CI.KUnit: success for scripts/kernel-doc: Detect mismatched inline member documentation tags (rev5) Patchwork
2026-05-07  4:05 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-07  5:41 ` [PATCH v4] scripts/kernel-doc: Detect mismatched inline member documentation tags Randy Dunlap
2026-05-07 11:47 ` ✗ Xe.CI.FULL: failure for scripts/kernel-doc: Detect mismatched inline member documentation tags (rev5) Patchwork
2026-05-15 14:42 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6igpwdx.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=shuicheng.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox