From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21DE4C3DA4A for ; Mon, 5 Aug 2024 06:51:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E2B5E10E128; Mon, 5 Aug 2024 06:51:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HTDXs4Pa"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF5AC10E128 for ; Mon, 5 Aug 2024 06:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722840708; x=1754376708; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=dH41Kd/3hV2NPc2xEFcKbOuFwG3eMc0ZzD5Yf4a/HdM=; b=HTDXs4PaFCxaio3FuTH5C+JUS3k1+8/9JTGEektr7V4rN8JySBAkGOA6 10JG50PKBXXszNQjnjrBaMeF9nWofGjUdMF31U4HIi7kpDmY07TYEbN5a fMS5Ltz99gVZ24Mcae2gE45tjlucJnEocBfQ6b/qBJ7Gjh1lMVEHWjCfw RE8PSaqgDeWUJY0/KOfhEiHxXbSk7dak9LeAL7eMyTWXB21e7Wldow05W csSAm51V/dNMwZY3dXLLo9k1qxxfSo0Dz1p/I44dD4H0el1ht4BfoFC4C ndmTYaJ3DI/JeumNyx91O0NZNY4cS+EGzqwF+c77MpJqGwjft70tyT1mG w==; X-CSE-ConnectionGUID: rGDy5va9Sl6GI3FFc03pAw== X-CSE-MsgGUID: /Hy7Vtt5SPeVMbaBh+mUnQ== X-IronPort-AV: E=McAfee;i="6700,10204,11154"; a="20737921" X-IronPort-AV: E=Sophos;i="6.09,263,1716274800"; d="scan'208";a="20737921" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2024 23:51:47 -0700 X-CSE-ConnectionGUID: WU3W5/B9SSW5sw6COjyE7Q== X-CSE-MsgGUID: lsdBKLVZQKeC+3ty1mi0bg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,263,1716274800"; d="scan'208";a="61037942" Received: from dmertma-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.18.124]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2024 23:51:47 -0700 Date: Sun, 04 Aug 2024 23:37:18 -0700 Message-ID: <87o767a31d.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Chauhan, Shekhar" Cc: intel-xe@lists.freedesktop.org, Zbigniew Kempczynski , Umesh Nerlige Ramappa Subject: Re: [PATCH] drm/xe/observation: Drop empty sysctl table entry In-Reply-To: References: <20240805062057.3547560-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sun, 04 Aug 2024 23:39:19 -0700, Chauhan, Shekhar wrote: > > [1 ] > [2 ] > Drive-by comment: > I see a couple of articles, citing the removal of sysctl sentinels starting Linux 6.10. Is there any plan to remove this > from everywhere else from the kernel? I don't see these elsewhere. > > On 8/5/2024 11:50, Ashutosh Dixit wrote: > > An empty sysctl table entry was inadvertently left behind for observation > sysctl. The breaks on 6.11 with the following errors: > > [ 219.654850] sysctl table check failed: dev/xe/(null) procname is null > [ 219.654862] sysctl table check failed: dev/xe/(null) No proc_handler > > Drop the empty entry. > > Fixes: 8169b2097d88 ("drm/xe/uapi: Rename xe perf layer as xe observation layer") > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2419 > Signed-off-by: Ashutosh Dixit > --- > drivers/gpu/drm/xe/xe_observation.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_observation.c b/drivers/gpu/drm/xe/xe_observation.c > index fcb584b42a7d5..a78c92a44ec2d 100644 > --- a/drivers/gpu/drm/xe/xe_observation.c > +++ b/drivers/gpu/drm/xe/xe_observation.c > @@ -66,7 +66,6 @@ static struct ctl_table observation_ctl_table[] = { > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, > - {} > }; > > /** > > -- > -shekhar