From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7F34C27C79 for ; Thu, 20 Jun 2024 16:28:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9397A10EB31; Thu, 20 Jun 2024 16:28:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BWJmte5h"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DC8810EB50 for ; Thu, 20 Jun 2024 16:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718900903; x=1750436903; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=7dEdy6OGlAFiBTO//90jL6UJ3KUS9DBYAxem0k3ArUs=; b=BWJmte5hqf/dQehCrkokmpyyxSVBwqqDj2sOJguxNedsHoMT/fQu3Qwl 1DyJLgMSKEhaMbz4qiefuONsshCqccFTBnTX/px0VWb4t3dCGmaUTH8KB 3UtLjDpbfA9Cul5r0uXwDroMKW6Fb7Ywt4PNyJGiBa93qkcn7gQtYsBgb F5pkOJaUVEl0UMB7feQQoPCIFWXpluPrShkLQxNE74bveJEPcwYu1FtM6 wtcq75jgxzSbaTE8IuzwMfsjzD0VbAAiwtg0uUUn77IkGaPT8EkOhIpXk 6ucr9/jTaynPw+m/kmWYGjfInwlSpefG7DMhKT4iO3oxk9HJSJjzi8ixz g==; X-CSE-ConnectionGUID: Gn9RZCy6TP2lVSzuEDpDRw== X-CSE-MsgGUID: 8SgZhWOhR5aHohmqqLChJQ== X-IronPort-AV: E=McAfee;i="6700,10204,11109"; a="18810759" X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="18810759" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 09:28:22 -0700 X-CSE-ConnectionGUID: Km9v9BprSOajc/5ejP6g9w== X-CSE-MsgGUID: b/V89lrrQfevWyeRAPiAUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="42985159" Received: from vishrutm-mobl11.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.97.201]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 09:28:22 -0700 Date: Thu, 20 Jun 2024 09:17:03 -0700 Message-ID: <87o77vr3ls.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Michal Wajdeczko Cc: Subject: Re: [PATCH] drm/xe/oa: Remove WARN_ON's for unsupported configurations In-Reply-To: References: <20240619225617.3465899-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 19 Jun 2024 16:04:42 -0700, Michal Wajdeczko wrote: > > > > On 20.06.2024 00:56, Ashutosh Dixit wrote: > > The OA ioctl's already have drm_dbg's which are sufficient to tell the user > > that OA is not supported on unsupported configurations (execlist mode and > > platform gen < 12). Having additional WARN_ON's for these during driver > > probe create unnecessary noise. Just remove these WARN_ON's. > > > > Suggested-by: Michal Wajdeczko > > Signed-off-by: Ashutosh Dixit > > Reviewed-by: Michal Wajdeczko Thanks for the review, patch merged to drm-xe-next. Thanks. -- Ashutosh