From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19C81EEB580 for ; Sat, 9 Sep 2023 15:59:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A180010E0BE; Sat, 9 Sep 2023 15:59:42 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0654010E0BE for ; Sat, 9 Sep 2023 15:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694275180; x=1725811180; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=hFW4q1hqj/EYIhjw7LEJzmdQk7A8JMTYAqY/0wxFMfg=; b=RQUbQfuOXNYkFDHDNXEUY6m4y0eyjy8ESjhlRIqttVHW/I+TfAnlVl8E YXxBoZeivwJhXSxhaq8i/Ubr+ceU76479rWu8nftzl4M325nE2sfdy+Fw mWd30Zb8GuQycJC+NjmFg40bhApLblwnXzE50+bzg0sFVnnXMlYxmBmQI 3Hyc1k//0qYJPiQpFuqrtTwE04UeEPrFV+s0wOMf0vbpJao0RgdIlp7FX 8hDFKHYTD5MEN6xP23WnxZkYjbq1jyJQ8gxE1BBNDpb0q625b2HVE9RVH TDVls58f3hrNGwE0clayNSWOLHJGru2WsMdR6C1lupQ1bf1iGgfF0yBpt g==; X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="464198219" X-IronPort-AV: E=Sophos;i="6.02,239,1688454000"; d="scan'208";a="464198219" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2023 08:59:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="736287002" X-IronPort-AV: E=Sophos;i="6.02,239,1688454000"; d="scan'208";a="736287002" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.43.185]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2023 08:59:34 -0700 Date: Sat, 09 Sep 2023 08:59:34 -0700 Message-ID: <87o7ibqqvt.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: References: <20230909052153.1669790-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH] drm/xe/uapi: Use common drm_xe_ext_set_property extension X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francois.Dugast@intel.com, intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sat, 09 Sep 2023 08:21:59 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Sat, Sep 09, 2023 at 11:15:20AM -0400, Rodrigo Vivi wrote: > > On Fri, Sep 08, 2023 at 10:21:53PM -0700, Ashutosh Dixit wrote: > > > There really is no difference between 'struct drm_xe_ext_vm_set_property' > > > and 'struct drm_xe_ext_exec_queue_set_property', they are extensions which > > > specify a pair. Replace the two extensions with a single > > > common 'struct drm_xe_ext_set_property' extension. The rationale is that > > > rather than have each XE module (including future modules) invent their own > > > property/value extensions, all XE modules use a common set_property > > > extension when possible. > > > > What about just killing this entirely? > > https://lore.kernel.org/all/20230908203302.449041-2-rodrigo.vivi@intel.com/ > > hmm... or maybe what we want is a mix of your patch and mine. > Let's use yours to kill the drm_xe_ext_exec_queue_set_property > in favor of a generic drm_xe_ext_set_property > and then mine goes on top killing just the > XE_VM_PROPERTY_BIND_OP_ERROR_CAPTURE_ADDRESS operation. > > thoughts? I can integrate and carry your patch in my series if you are > okay with that. Yes, please go ahead. Fwiw I think a generic drm_xe_ext_set_property will be useful in the future, e.g. I am thinking of using it for OA. Thanks. -- Ashutosh