Re: [PATCH] drm/xe/lrc: Fix uninitialized new_ts when capturing context timestamp

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 12 Mar 2026 05:53:09 -0700, Umesh Nerlige Ramappa wrote:
>
> Getting engine specific CTX TIMESTAMP register can fail. In that case,
> if the context is active, new_ts is uninitialized. Fix that case by
> initializing new_ts to the last value that was sampled in SW -
> lrc->ctx_timestamp.
>
> Flagged by static analysis.
>
> v2: Fix new_ts initialization (Ashutosh)

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_lrc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index aa26c71ae34f..04304dff45b0 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -2563,14 +2563,14 @@ static int get_ctx_timestamp(struct xe_lrc *lrc, u32 engine_id, u64 *reg_ctx_ts)
>   * @lrc: Pointer to the lrc.
>   *
>   * Return latest ctx timestamp. With support for active contexts, the
> - * calculation may bb slightly racy, so follow a read-again logic to ensure that
> + * calculation may be slightly racy, so follow a read-again logic to ensure that
>   * the context is still active before returning the right timestamp.
>   *
>   * Returns: New ctx timestamp value
>   */
>  u64 xe_lrc_timestamp(struct xe_lrc *lrc)
>  {
> -	u64 lrc_ts, reg_ts, new_ts;
> +	u64 lrc_ts, reg_ts, new_ts = lrc->ctx_timestamp;
>	u32 engine_id;
>
>	lrc_ts = xe_lrc_ctx_timestamp(lrc);
> --
> 2.51.0
>