From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5ABE7CAC5B0 for ; Fri, 3 Oct 2025 21:41:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E241F10E0C5; Fri, 3 Oct 2025 21:41:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="d1gnwenz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDB6310E0C5 for ; Fri, 3 Oct 2025 21:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1759527669; x=1791063669; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=sBabNOLfBblWSLq9IvWHOgz9xqngsjuL9IT3QjtPHpk=; b=d1gnwenz9rctnd1N6BYGqx5n/wQZ1uKdEKLoBdGxH63WW0WQn2SHkBas dQb3BI1FjbSfZL7DADgrl+lZAK3ksZRNbU3aBnCnNOxv9X27Vf0J9vpgS saNiYX/PfWWksn5ElAV3lvVXQ6skW4KfP6piGbahrpc74X7dycDa904Ck TqEb6iPbyP/sKHVzm7SStf57GREoJhCj1WUn7QiRgJWOeAnmLYm3H4Sur V5nnSr4sqCILj4d6YuDYaQqVPFODzqCAfUaPazu/JAbLl7YysQSE8CSS9 vwBqA8c2U8zH+0gzuuGqARPlwRcadsY6f6VIPFTpvTywPCNjQMfxkham4 A==; X-CSE-ConnectionGUID: mp/Elqh2QgW9ZgbreNg+xQ== X-CSE-MsgGUID: EqYWjNMtSBe2mUI1qu4Lmw== X-IronPort-AV: E=McAfee;i="6800,10657,11571"; a="79240994" X-IronPort-AV: E=Sophos;i="6.18,313,1751266800"; d="scan'208";a="79240994" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2025 14:41:08 -0700 X-CSE-ConnectionGUID: 09eDTetDTEqvONq56Kqqaw== X-CSE-MsgGUID: ZVXOleX9QPaWBjpqO5RCxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,313,1751266800"; d="scan'208";a="210360481" Received: from anirban1-intel.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.84.251]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2025 14:41:08 -0700 Date: Fri, 03 Oct 2025 14:41:07 -0700 Message-ID: <87plb3ek98.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi Cc: Aakash Deep Sarkar , , , , , Subject: Re: [PATCH v4 3/9] drm/xe: Add a trace point for GPU work period In-Reply-To: References: <20250926104521.1815428-1-aakash.deep.sarkar@intel.com> <20250926104521.1815428-4-aakash.deep.sarkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 02 Oct 2025 07:42:33 -0700, Rodrigo Vivi wrote: > > > diff --git a/include/trace/gpu_work_period.h b/include/trace/gpu_work_p= eriod.h > > new file mode 100644 > > index 000000000000..e06467625705 > > --- /dev/null > > +++ b/include/trace/gpu_work_period.h > > @@ -0,0 +1,59 @@ > > +/* SPDX-License-Identifier: MIT */ > > +/* > > + * Copyright =A9 2025 Intel Corporation > > + */ > > + > > +#undef TRACE_SYSTEM > > +#define TRACE_SYSTEM power > > + > > +#if !defined(_TRACE_GPU_WORK_PERIOD_H) || defined(TRACE_HEADER_MULTI_R= EAD) > > +#define _TRACE_GPU_WORK_PERIOD_H > > + > > +#include > > + > > +TRACE_EVENT(gpu_work_period, > > oh! not again please! > Stop trying to brute force this. > > If it is a xe trace you need to add 'xe_' prefix. > > If you really need the 'gpu_' prefix because of Android, this > needs to go through the drm layer, not a driver specific. Also, drm layer patches need to be sent to the following mail lists: intel-gfx@lists.freedesktop.org dri-devel@lists.freedesktop.org intel-xe@lists.freedesktop.org Also, see previous similar comments on the gpu_frequency tracepoint series. Thanks. -- Ashutosh