Re: [PATCH] drm/i915: Indicate which pipe lied about its interrupts

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 13 May 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Indicate which pipe signalled the spurious DE PIPE interrupt.
> Might help with debugging a bit if we know where the interrupt
> is supposedly coming from.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_irq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
> index 3e73832e5e81..a3261c7aad72 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
> @@ -1418,7 +1418,8 @@ void gen8_de_irq_handler(struct intel_display *display, u32 master_ctl)
>  		iir = intel_de_read(display, GEN8_DE_PIPE_IIR(pipe));
>  		if (!iir) {
>  			drm_err_ratelimited(display->drm,
> -					    "The master control interrupt lied (DE PIPE)!\n");
> +					    "The master control interrupt lied (DE PIPE %c)!\n",
> +					    pipe_name(pipe));
>  			continue;
>  		}

-- 
Jani Nikula, Intel