From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32DFEC3DA49 for ; Thu, 18 Jul 2024 14:32:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB90210E935; Thu, 18 Jul 2024 14:32:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LyDb3e3r"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87A8B10E935 for ; Thu, 18 Jul 2024 14:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721313153; x=1752849153; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Spg/9CwnT6fPTF/q5tJnyB5JPQV8H/K33Xk16ft9vWQ=; b=LyDb3e3rvrpDvd6QRp8wxbYcP7/Bw2mDHKvd5DWYagzSSUjshkom1t6U bQPrVwQYJEoTWye+j+nMbcDngJ4oiRLlIKxRcytY4PBcgo7QT2GGhdKB4 gRlXH6qAgXrHv1WixPMjygmBcyYflsZ+cDX/3UY0e/IVUlvHa72d1d9bN ZR6tCUvZvuMVw8wYPjfLOEUMdAyW8Y0IECmg4Y4t1qJTWj6/RyUgnZbfv YSq6VNag1j5kuudqJjo7khxszQCBJrKohL45ETyMr9pFnh5K7TXvb+WcV vvlNHoerFUREaXHHy/9Qo5C+HAry/k6+3QmthtQcMfidSHsFIVnLb6PWh g==; X-CSE-ConnectionGUID: IN0zQhuVR9Sj3gaDVwxO/A== X-CSE-MsgGUID: LzVSoarqRiKuwUfF0dvt8w== X-IronPort-AV: E=McAfee;i="6700,10204,11137"; a="18832568" X-IronPort-AV: E=Sophos;i="6.09,218,1716274800"; d="scan'208";a="18832568" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2024 07:32:33 -0700 X-CSE-ConnectionGUID: +Y4zaOMHRWa2F41PeBYnfg== X-CSE-MsgGUID: fWu2/2reSdyXcl3uzmkFEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,218,1716274800"; d="scan'208";a="51067310" Received: from mastettl-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.163.102]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2024 07:32:32 -0700 Date: Thu, 18 Jul 2024 07:22:34 -0700 Message-ID: <87plrazsnp.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Ohad Sharabi Cc: intel-xe@lists.freedesktop.org, obitton@habana.ai Subject: Re: [PATCH] fixup! drm/xe/oa: Add OAR support In-Reply-To: <20240718054848.2955818-1-osharabi@habana.ai> References: <20240718054848.2955818-1-osharabi@habana.ai> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 17 Jul 2024 22:48:48 -0700, Ohad Sharabi wrote: > Hi Ohad, > The current implementation uses static CS codes instead of common. > > Signed-off-by: Ohad Sharabi > --- > drivers/gpu/drm/xe/xe_oa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c > index 6d69f751bf78..3ef92eb8fbb1 100644 > --- a/drivers/gpu/drm/xe/xe_oa.c > +++ b/drivers/gpu/drm/xe/xe_oa.c > @@ -641,7 +641,7 @@ static void xe_oa_store_flex(struct xe_oa_stream *stream, struct xe_lrc *lrc, > u32 offset = xe_bo_ggtt_addr(lrc->bo); > > do { > - bb->cs[bb->len++] = MI_STORE_DATA_IMM | BIT(22) /* GGTT */ | 2; > + bb->cs[bb->len++] = MI_STORE_DATA_IMM | MI_SDI_GGTT | MI_SDI_NUM_DW(1); > bb->cs[bb->len++] = offset + flex->offset * sizeof(u32); > bb->cs[bb->len++] = 0; > bb->cs[bb->len++] = flex->value; The patch is fine. However, we don't have fixup patches upstream. So please change the patch title and description to something like: " drm/xe/oa: Don't use hardcoded values The current implementation uses hardcoded values instead of common defines. " Please resend the patch with this change, I can review and merge it. Thanks. -- Ashutosh