From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0685CC25B47 for ; Fri, 27 Oct 2023 20:28:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCB0810EA42; Fri, 27 Oct 2023 20:28:03 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FC7F10EA42 for ; Fri, 27 Oct 2023 20:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698438481; x=1729974481; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=YcXV/3mvMiaDlyJ3/ZnE6Kwtc6r3sYwcKINNIy2WxAg=; b=nrFM+qNqIMGHxQQLIqAY5z0ABFyjt+3bMO9xlOQTWM43AR/F4awrrM+S 75GXzPtFDVXog4cSTtOyNvdaSzifu5JUc3S2DtmEXMmgAXe8MeYwlL1fR eN5dIQSz82ay5K956z922sjrPr1G7nDhUmB8tl4x9YZ+ttwQwep/gNCP0 I4keqMtz4UvDTwJ8QKdjfKwg5XO1L9Lvdb4Hp8VrzQl+Z4P7YI5ZZb01L Dflk2HAWN0RVBacjXIZvQ4TUao37SA2yWSLp0hd54S+b1gw4xRqr2pkUH Q+BdI9UMha0IJ3qJiJBiysnoarjIqb93re264EC7qw+LmkTXayrATOoYp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10876"; a="390710232" X-IronPort-AV: E=Sophos;i="6.03,257,1694761200"; d="scan'208";a="390710232" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 13:28:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10876"; a="794687852" X-IronPort-AV: E=Sophos;i="6.03,257,1694761200"; d="scan'208";a="794687852" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.34.111]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 13:28:00 -0700 Date: Fri, 27 Oct 2023 13:28:00 -0700 Message-ID: <87pm0zdd4f.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Lionel Landwerlin In-Reply-To: <85638449-3894-4887-b10d-7a6b2b73d4ae@intel.com> References: <20230919161049.2307855-5-ashutosh.dixit@intel.com> <85638449-3894-4887-b10d-7a6b2b73d4ae@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [04/21] drm/xe/oa: Module init/exit and probe/remove X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 20 Oct 2023 00:08:18 -0700, Lionel Landwerlin wrote: > > > +static void xe_oa_init_supported_formats(struct xe_oa *oa) > > +{ > > + switch (oa->xe->info.platform) { > > + case XE_ALDERLAKE_S: > > + case XE_ALDERLAKE_P: > > case XE_ALDERLAKE_N: > > case XE_DG1: > > case XE_TIGERLAKE: > > case XE_ROCKETLAKE: > > Those are essentially the same from the OA register/format point of view. OK, will add them. Thx. > > > + oa_format_add(oa, XE_OA_FORMAT_A12); > > + oa_format_add(oa, XE_OA_FORMAT_A12_B8_C8); > > + oa_format_add(oa, XE_OA_FORMAT_A32u40_A4u32_B8_C8); > > + oa_format_add(oa, XE_OA_FORMAT_C4_B8); > > + break; > > + > > + case XE_DG2: > > + oa_format_add(oa, XE_OAR_FORMAT_A32u40_A4u32_B8_C8); > > + oa_format_add(oa, XE_OA_FORMAT_A24u40_A14u32_B8_C8); > > + break; > > + > > + case XE_METEORLAKE: > > + oa_format_add(oa, XE_OAR_FORMAT_A32u40_A4u32_B8_C8); > > + oa_format_add(oa, XE_OA_FORMAT_A24u40_A14u32_B8_C8); > > + oa_format_add(oa, XE_OAM_FORMAT_MPEC8u64_B8_C8); > > + oa_format_add(oa, XE_OAM_FORMAT_MPEC8u32_B8_C8); > > + break; > > + > > + default: > > + drm_err(&oa->xe->drm, "Unknown platform\n"); > > + } > > +}