From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F981C27C79 for ; Thu, 20 Jun 2024 16:26:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9E4710EB2C; Thu, 20 Jun 2024 16:26:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DKF157es"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id C223610EB2C for ; Thu, 20 Jun 2024 16:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718900784; x=1750436784; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=wPpTqpyJa8OmSweqISZZPSh3+CFvvW0k4lVvhlovpp4=; b=DKF157esOqdyyjULG6FMAEGCL49BfgVc0LE5TUEiUsMkXdzOjmny9zUr UJFkmj/K7asaBfcOyQzhhabFVHEMQhvWNHpCd8zMOTaW53PjIOwYzjNgO yiQCzLy5BOprtDgZnkcG/2rkrCVTY05SwxauwG5u/i/13iTnoQW/Dupey sEgFv2n8oFohQwE1Fs7cBePGKwRuc1Bqmp1pdhsFYjDSGIZ0hRbxGsZ01 eADmxKfMLTIRDNCJQfXzWjTILDa8JvuNMAEv7ghIB49otyPEJsoPX0DWz dpRznJrC+J1N2nIS7+xhidx6jryp009NBQE9BhSk6rZTbVot3hgpJRdUI Q==; X-CSE-ConnectionGUID: TH0L9YytSAawLupDPhIC/A== X-CSE-MsgGUID: RN46xtIjRrWRwDqwP6rcuA== X-IronPort-AV: E=McAfee;i="6700,10204,11109"; a="12166602" X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="12166602" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 09:26:23 -0700 X-CSE-ConnectionGUID: dpAlOiL+SGGu4IT67Cg+WQ== X-CSE-MsgGUID: b5x4o5FYRN6KMCaxHC38wg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="42202661" Received: from vishrutm-mobl11.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.97.201]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 09:26:22 -0700 Date: Thu, 20 Jun 2024 09:16:03 -0700 Message-ID: <87r0crr3ng.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Michal Wajdeczko Cc: , Rodrigo Vivi , "Umesh Nerlige Ramappa" Subject: Re: [PATCH] drm/xe/oa: Fix potential NPD when OA is not initialized In-Reply-To: <878qz0zm1l.wl-ashutosh.dixit@intel.com> References: <20240619175427.861-1-michal.wajdeczko@intel.com> <878qz0zm1l.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 19 Jun 2024 13:59:18 -0700, Dixit, Ashutosh wrote: > > On Wed, 19 Jun 2024 10:54:27 -0700, Michal Wajdeczko wrote: > > > > If oa->xe can be NULL then we shall not use it as a valid pointer. > > Hi Michal, thanks for catching this: > > Reviewed-by: Ashutosh Dixit Hi Michal, once again thanks for the patch. Merged now to drm-xe-next. -- Ashutosh