From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5665FC021BE for ; Thu, 27 Feb 2025 10:47:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2219610EA89; Thu, 27 Feb 2025 10:47:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mGjukulC"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 282B510EA89; Thu, 27 Feb 2025 10:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740653259; x=1772189259; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=faKqbIo9ohlJImOLrrHIkwjNGaccf93VmOWvmUtLnEg=; b=mGjukulC12kfBa9ndhjDjW010/RoXnaVQEOm5pppIOocBuWlnJowZXse Y314WbFj+iemWaVmuIeON0Um44fXxhjHS4DzjEjKd8KZRZH++U+TtfeKW J5l85X+KoXOVBxTKm/yUsbrGY0RcgeQa4SD3vSVRFp4oCrccLZZvBjmIo w8ChHiRfk0u7woUnr/m1/c5Ylz7+Lm3sFAGNKAUzWM2p98jut4GhuAn3x vYsmQxQ/CcG4wLvoIcZ2kOd72WcJ2KhM5c+iwhxgGySH7yky8S+qiihM1 xuBzNdFN81QUpzpgShkq8lIUca0Ys+913T8OYK3unAVX4XEqGQRuVXKEW w==; X-CSE-ConnectionGUID: CAnIjP8AS/u/rmpQmVf3vw== X-CSE-MsgGUID: wHL1CyuISdigi+orK4qNvw== X-IronPort-AV: E=McAfee;i="6700,10204,11357"; a="41663452" X-IronPort-AV: E=Sophos;i="6.13,319,1732608000"; d="scan'208";a="41663452" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2025 02:47:39 -0800 X-CSE-ConnectionGUID: bDl6Q4biRAisW1awg+BeNw== X-CSE-MsgGUID: 9yUe7WxTQ2u7KZi8apzAAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,319,1732608000"; d="scan'208";a="116783370" Received: from lfiedoro-mobl.ger.corp.intel.com (HELO localhost) ([10.245.246.181]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2025 02:47:33 -0800 From: Jani Nikula To: Su Hui , lucas.demarchi@intel.com, thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: Su Hui , ilpo.jarvinen@linux.intel.com, andriy.shevchenko@linux.intel.com, michael.j.ruhl@intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm/xe: Select INTEL_VSEC to fix build dependency In-Reply-To: <20250227073205.1248282-1-suhui@nfschina.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250227073205.1248282-1-suhui@nfschina.com> Date: Thu, 27 Feb 2025 12:47:28 +0200 Message-ID: <87senz3br3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 27 Feb 2025, Su Hui wrote: > When build randconfig, there is an error: > ld: drivers/gpu/drm/xe/xe_vsec.o: in function `xe_vsec_init': > xe_vsec.c:(.text+0x182): undefined reference to `intel_vsec_register' > > When CONFIG_DRM_XE=y and CONFIG_INTEL_VSEC=m is set, ld couldn't find > 'intel_vsec_register'. Select INTEL_VSEC to fix this error. Documentation/kbuild/kconfig-language.rst: Note: select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set. In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over. This should likely be either depends on INTEL_VSEC || INTEL_VSEC=n or depends on INTEL_VSEC BR, Jani. > > Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices") > Signed-off-by: Su Hui > --- > drivers/gpu/drm/xe/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig > index b51a2bde73e2..7a60d96d2dd6 100644 > --- a/drivers/gpu/drm/xe/Kconfig > +++ b/drivers/gpu/drm/xe/Kconfig > @@ -44,6 +44,7 @@ config DRM_XE > select WANT_DEV_COREDUMP > select AUXILIARY_BUS > select HMM_MIRROR > + select INTEL_VSEC > help > Experimental driver for Intel Xe series GPUs -- Jani Nikula, Intel