* [PATCH 1/2] drm: print top commit sha after loading the driver
@ 2024-04-24 10:07 Farah Kassabri
2024-04-24 10:07 ` [PATCH 2/2] drm/xe: set last driver commit sha Farah Kassabri
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Farah Kassabri @ 2024-04-24 10:07 UTC (permalink / raw)
To: intel-xe; +Cc: osharabi, Farah Kassabri
Add the last driver sha to the existing log message
which prints the drm device info.
Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
---
drivers/gpu/drm/drm_drv.c | 6 +++---
include/drm/drm_drv.h | 2 ++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 535b624d4c9d..e0f7af1b6ec3 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -947,10 +947,10 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
}
drm_panic_register(dev);
- DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
+ DRM_INFO("Initialized %s %d.%d.%d%s %s for %s on minor %d\n",
driver->name, driver->major, driver->minor,
- driver->patchlevel, driver->date,
- dev->dev ? dev_name(dev->dev) : "virtual device",
+ driver->patchlevel, driver->git_sha ? driver->git_sha : "",
+ driver->date, dev->dev ? dev_name(dev->dev) : "virtual device",
dev->primary ? dev->primary->index : dev->accel->index);
goto out_unlock;
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 8878260d7529..7578a1f4ce74 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -407,6 +407,8 @@ struct drm_driver {
int minor;
/** @patchlevel: driver patch level */
int patchlevel;
+ /** @git_sha: driver last commit sha */
+ char *git_sha;
/** @name: driver name */
char *name;
/** @desc: driver description */
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] drm/xe: set last driver commit sha
2024-04-24 10:07 [PATCH 1/2] drm: print top commit sha after loading the driver Farah Kassabri
@ 2024-04-24 10:07 ` Farah Kassabri
2024-04-29 11:15 ` Jani Nikula
2024-04-28 21:48 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm: print top commit sha after loading the driver Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Farah Kassabri @ 2024-04-24 10:07 UTC (permalink / raw)
To: intel-xe; +Cc: osharabi, Farah Kassabri
This patch will set the last driver commit sha into the drm driver
info data structure, which will be used in the log message which
prints the device info at the end of the driver initialization.
Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
---
drivers/gpu/drm/xe/Makefile | 4 ++++
drivers/gpu/drm/xe/xe_device.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 8321ec4f9b46..acccb517b7bb 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -309,6 +309,10 @@ ifeq ($(CONFIG_DEBUG_FS),y)
i915-display/intel_pipe_crc.o
endif
+GIT_SHA ?= $(shell cd $(srctree) && git rev-parse --short HEAD)
+DRV_CFLAGS_MODULE="-DXE_DRIVER_GIT_SHA=-$(GIT_SHA)"
+CFLAGS_MODULE += ${DRV_CFLAGS_MODULE}
+
obj-$(CONFIG_DRM_XE) += xe.o
obj-$(CONFIG_DRM_XE_KUNIT_TEST) += tests/
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 55bbc8b8df15..2e74aa18e953 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -215,6 +215,7 @@ static struct drm_driver driver = {
.major = DRIVER_MAJOR,
.minor = DRIVER_MINOR,
.patchlevel = DRIVER_PATCHLEVEL,
+ .git_sha = __stringify(XE_DRIVER_GIT_SHA),
};
static void xe_device_destroy(struct drm_device *dev, void *dummy)
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* ✓ CI.Patch_applied: success for series starting with [1/2] drm: print top commit sha after loading the driver
2024-04-24 10:07 [PATCH 1/2] drm: print top commit sha after loading the driver Farah Kassabri
2024-04-24 10:07 ` [PATCH 2/2] drm/xe: set last driver commit sha Farah Kassabri
@ 2024-04-28 21:48 ` Patchwork
2024-04-28 21:48 ` ✓ CI.checkpatch: " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2024-04-28 21:48 UTC (permalink / raw)
To: Farah Kassabri; +Cc: intel-xe
== Series Details ==
Series: series starting with [1/2] drm: print top commit sha after loading the driver
URL : https://patchwork.freedesktop.org/series/133000/
State : success
== Summary ==
=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: 94a0eea182f0 drm-tip: 2024y-04m-27d-07h-26m-48s UTC integration manifest
=== git am output follows ===
Applying: drm: print top commit sha after loading the driver
Applying: drm/xe: set last driver commit sha
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ CI.checkpatch: success for series starting with [1/2] drm: print top commit sha after loading the driver
2024-04-24 10:07 [PATCH 1/2] drm: print top commit sha after loading the driver Farah Kassabri
2024-04-24 10:07 ` [PATCH 2/2] drm/xe: set last driver commit sha Farah Kassabri
2024-04-28 21:48 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm: print top commit sha after loading the driver Patchwork
@ 2024-04-28 21:48 ` Patchwork
2024-04-28 21:49 ` ✓ CI.KUnit: " Patchwork
2024-04-29 11:02 ` [PATCH 1/2] " Jani Nikula
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2024-04-28 21:48 UTC (permalink / raw)
To: Farah Kassabri; +Cc: intel-xe
== Series Details ==
Series: series starting with [1/2] drm: print top commit sha after loading the driver
URL : https://patchwork.freedesktop.org/series/133000/
State : success
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
0daf0be5bb95eb0a0e42275e00a0e42d8d8fd543
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 80aaad3d857c19dbd4e8481a504b23dc861fbe7e
Author: Farah Kassabri <fkassabri@habana.ai>
Date: Wed Apr 24 13:07:06 2024 +0300
drm/xe: set last driver commit sha
This patch will set the last driver commit sha into the drm driver
info data structure, which will be used in the log message which
prints the device info at the end of the driver initialization.
Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
+ /mt/dim checkpatch 94a0eea182f0a8b1ff4cd6269bcb0d26bb4994f2 drm-intel
cb374b72f57d drm: print top commit sha after loading the driver
80aaad3d857c drm/xe: set last driver commit sha
^ permalink raw reply [flat|nested] 12+ messages in thread
* ✓ CI.KUnit: success for series starting with [1/2] drm: print top commit sha after loading the driver
2024-04-24 10:07 [PATCH 1/2] drm: print top commit sha after loading the driver Farah Kassabri
` (2 preceding siblings ...)
2024-04-28 21:48 ` ✓ CI.checkpatch: " Patchwork
@ 2024-04-28 21:49 ` Patchwork
2024-04-29 11:02 ` [PATCH 1/2] " Jani Nikula
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2024-04-28 21:49 UTC (permalink / raw)
To: Farah Kassabri; +Cc: intel-xe
== Series Details ==
Series: series starting with [1/2] drm: print top commit sha after loading the driver
URL : https://patchwork.freedesktop.org/series/133000/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[21:48:19] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[21:48:24] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make ARCH=um O=.kunit --jobs=48
../arch/x86/um/user-offsets.c:17:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
17 | void foo(void)
| ^~~
In file included from ../arch/um/kernel/asm-offsets.c:1:
../arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
9 | void foo(void)
| ^~~
../arch/x86/um/fault.c:18:5: warning: no previous prototype for ‘arch_fixup’ [-Wmissing-prototypes]
18 | int arch_fixup(unsigned long address, struct uml_pt_regs *regs)
| ^~~~~~~~~~
../arch/x86/um/bugs_64.c:9:6: warning: no previous prototype for ‘arch_check_bugs’ [-Wmissing-prototypes]
9 | void arch_check_bugs(void)
| ^~~~~~~~~~~~~~~
../arch/x86/um/bugs_64.c:13:6: warning: no previous prototype for ‘arch_examine_signal’ [-Wmissing-prototypes]
13 | void arch_examine_signal(int sig, struct uml_pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~
../arch/x86/um/os-Linux/mcontext.c:7:6: warning: no previous prototype for ‘get_regs_from_mc’ [-Wmissing-prototypes]
7 | void get_regs_from_mc(struct uml_pt_regs *regs, mcontext_t *mc)
| ^~~~~~~~~~~~~~~~
../arch/x86/um/os-Linux/registers.c:146:15: warning: no previous prototype for ‘get_thread_reg’ [-Wmissing-prototypes]
146 | unsigned long get_thread_reg(int reg, jmp_buf *buf)
| ^~~~~~~~~~~~~~
../arch/um/os-Linux/skas/process.c:107:6: warning: no previous prototype for ‘wait_stub_done’ [-Wmissing-prototypes]
107 | void wait_stub_done(int pid)
| ^~~~~~~~~~~~~~
../arch/um/os-Linux/skas/process.c:683:6: warning: no previous prototype for ‘__switch_mm’ [-Wmissing-prototypes]
683 | void __switch_mm(struct mm_id *mm_idp)
| ^~~~~~~~~~~
../arch/x86/um/vdso/um_vdso.c:16:5: warning: no previous prototype for ‘__vdso_clock_gettime’ [-Wmissing-prototypes]
16 | int __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
| ^~~~~~~~~~~~~~~~~~~~
../arch/x86/um/vdso/um_vdso.c:30:5: warning: no previous prototype for ‘__vdso_gettimeofday’ [-Wmissing-prototypes]
30 | int __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
| ^~~~~~~~~~~~~~~~~~~
../arch/x86/um/vdso/um_vdso.c:44:21: warning: no previous prototype for ‘__vdso_time’ [-Wmissing-prototypes]
44 | __kernel_old_time_t __vdso_time(__kernel_old_time_t *t)
| ^~~~~~~~~~~
../arch/x86/um/vdso/um_vdso.c:57:1: warning: no previous prototype for ‘__vdso_getcpu’ [-Wmissing-prototypes]
57 | __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
| ^~~~~~~~~~~~~
../arch/um/os-Linux/main.c:187:7: warning: no previous prototype for ‘__wrap_malloc’ [-Wmissing-prototypes]
187 | void *__wrap_malloc(int size)
| ^~~~~~~~~~~~~
../arch/um/os-Linux/main.c:208:7: warning: no previous prototype for ‘__wrap_calloc’ [-Wmissing-prototypes]
208 | void *__wrap_calloc(int n, int size)
| ^~~~~~~~~~~~~
../arch/um/os-Linux/main.c:222:6: warning: no previous prototype for ‘__wrap_free’ [-Wmissing-prototypes]
222 | void __wrap_free(void *ptr)
| ^~~~~~~~~~~
../arch/um/os-Linux/mem.c:28:6: warning: no previous prototype for ‘kasan_map_memory’ [-Wmissing-prototypes]
28 | void kasan_map_memory(void *start, size_t len)
| ^~~~~~~~~~~~~~~~
../arch/um/os-Linux/mem.c:212:13: warning: no previous prototype for ‘check_tmpexec’ [-Wmissing-prototypes]
212 | void __init check_tmpexec(void)
| ^~~~~~~~~~~~~
../arch/um/kernel/skas/mmu.c:17:5: warning: no previous prototype for ‘init_new_context’ [-Wmissing-prototypes]
17 | int init_new_context(struct task_struct *task, struct mm_struct *mm)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/skas/mmu.c:60:6: warning: no previous prototype for ‘destroy_context’ [-Wmissing-prototypes]
60 | void destroy_context(struct mm_struct *mm)
| ^~~~~~~~~~~~~~~
../arch/x86/um/ptrace_64.c:111:5: warning: no previous prototype for ‘poke_user’ [-Wmissing-prototypes]
111 | int poke_user(struct task_struct *child, long addr, long data)
| ^~~~~~~~~
../arch/x86/um/ptrace_64.c:171:5: warning: no previous prototype for ‘peek_user’ [-Wmissing-prototypes]
171 | int peek_user(struct task_struct *child, long addr, long data)
| ^~~~~~~~~
../arch/um/os-Linux/signal.c:75:6: warning: no previous prototype for ‘sig_handler’ [-Wmissing-prototypes]
75 | void sig_handler(int sig, struct siginfo *si, mcontext_t *mc)
| ^~~~~~~~~~~
../arch/um/os-Linux/signal.c:111:6: warning: no previous prototype for ‘timer_alarm_handler’ [-Wmissing-prototypes]
111 | void timer_alarm_handler(int sig, struct siginfo *unused_si, mcontext_t *mc)
| ^~~~~~~~~~~~~~~~~~~
../arch/um/kernel/skas/process.c:36:12: warning: no previous prototype for ‘start_uml’ [-Wmissing-prototypes]
36 | int __init start_uml(void)
| ^~~~~~~~~
../arch/um/os-Linux/start_up.c:301:12: warning: no previous prototype for ‘parse_iomem’ [-Wmissing-prototypes]
301 | int __init parse_iomem(char *str, int *add)
| ^~~~~~~~~~~
../arch/x86/um/signal.c:560:6: warning: no previous prototype for ‘sys_rt_sigreturn’ [-Wmissing-prototypes]
560 | long sys_rt_sigreturn(void)
| ^~~~~~~~~~~~~~~~
../arch/x86/um/syscalls_64.c:48:6: warning: no previous prototype for ‘arch_switch_to’ [-Wmissing-prototypes]
48 | void arch_switch_to(struct task_struct *to)
| ^~~~~~~~~~~~~~
../arch/um/kernel/mem.c:202:8: warning: no previous prototype for ‘pgd_alloc’ [-Wmissing-prototypes]
202 | pgd_t *pgd_alloc(struct mm_struct *mm)
| ^~~~~~~~~
../arch/um/kernel/mem.c:215:7: warning: no previous prototype for ‘uml_kmalloc’ [-Wmissing-prototypes]
215 | void *uml_kmalloc(int size, int flags)
| ^~~~~~~~~~~
../arch/um/kernel/process.c:51:5: warning: no previous prototype for ‘pid_to_processor_id’ [-Wmissing-prototypes]
51 | int pid_to_processor_id(int pid)
| ^~~~~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:87:7: warning: no previous prototype for ‘__switch_to’ [-Wmissing-prototypes]
87 | void *__switch_to(struct task_struct *from, struct task_struct *to)
| ^~~~~~~~~~~
../arch/um/kernel/process.c:140:6: warning: no previous prototype for ‘fork_handler’ [-Wmissing-prototypes]
140 | void fork_handler(void)
| ^~~~~~~~~~~~
../arch/um/kernel/process.c:217:6: warning: no previous prototype for ‘arch_cpu_idle’ [-Wmissing-prototypes]
217 | void arch_cpu_idle(void)
| ^~~~~~~~~~~~~
../arch/um/kernel/process.c:253:5: warning: no previous prototype for ‘copy_to_user_proc’ [-Wmissing-prototypes]
253 | int copy_to_user_proc(void __user *to, void *from, int size)
| ^~~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:263:5: warning: no previous prototype for ‘clear_user_proc’ [-Wmissing-prototypes]
263 | int clear_user_proc(void __user *buf, int size)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/process.c:271:6: warning: no previous prototype for ‘set_using_sysemu’ [-Wmissing-prototypes]
271 | void set_using_sysemu(int value)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:278:5: warning: no previous prototype for ‘get_using_sysemu’ [-Wmissing-prototypes]
278 | int get_using_sysemu(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:316:12: warning: no previous prototype for ‘make_proc_sysemu’ [-Wmissing-prototypes]
316 | int __init make_proc_sysemu(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:348:15: warning: no previous prototype for ‘arch_align_stack’ [-Wmissing-prototypes]
348 | unsigned long arch_align_stack(unsigned long sp)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:45:6: warning: no previous prototype for ‘machine_restart’ [-Wmissing-prototypes]
45 | void machine_restart(char * __unused)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:51:6: warning: no previous prototype for ‘machine_power_off’ [-Wmissing-prototypes]
51 | void machine_power_off(void)
| ^~~~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:57:6: warning: no previous prototype for ‘machine_halt’ [-Wmissing-prototypes]
57 | void machine_halt(void)
| ^~~~~~~~~~~~
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
../arch/um/kernel/tlb.c:579:6: warning: no previous prototype for ‘flush_tlb_mm_range’ [-Wmissing-prototypes]
579 | void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
| ^~~~~~~~~~~~~~~~~~
../arch/um/kernel/tlb.c:594:6: warning: no previous prototype for ‘force_flush_all’ [-Wmissing-prototypes]
594 | void force_flush_all(void)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/um_arch.c:408:19: warning: no previous prototype for ‘read_initrd’ [-Wmissing-prototypes]
408 | int __init __weak read_initrd(void)
| ^~~~~~~~~~~
../arch/um/kernel/um_arch.c:461:7: warning: no previous prototype for ‘text_poke’ [-Wmissing-prototypes]
461 | void *text_poke(void *addr, const void *opcode, size_t len)
| ^~~~~~~~~
../arch/um/kernel/um_arch.c:473:6: warning: no previous prototype for ‘text_poke_sync’ [-Wmissing-prototypes]
473 | void text_poke_sync(void)
| ^~~~~~~~~~~~~~
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
../arch/um/kernel/kmsg_dump.c:60:12: warning: no previous prototype for ‘kmsg_dumper_stdout_init’ [-Wmissing-prototypes]
60 | int __init kmsg_dumper_stdout_init(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes]
156 | u64 ioread64_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes]
163 | u64 ioread64_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes]
170 | u64 ioread64be_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes]
178 | u64 ioread64be_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes]
264 | void iowrite64_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes]
272 | void iowrite64_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes]
280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes]
288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
fatal: detected dubious ownership in repository at '/kernel'
To add an exception for this directory, call:
git config --global --add safe.directory /kernel
stty: 'standard input': Inappropriate ioctl for device
[21:48:49] Starting KUnit Kernel (1/1)...
[21:48:49] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[21:48:49] =================== guc_dbm (7 subtests) ===================
[21:48:49] [PASSED] test_empty
[21:48:49] [PASSED] test_default
[21:48:49] ======================== test_size ========================
[21:48:49] [PASSED] 4
[21:48:49] [PASSED] 8
[21:48:49] [PASSED] 32
[21:48:49] [PASSED] 256
[21:48:49] ==================== [PASSED] test_size ====================
[21:48:49] ======================= test_reuse ========================
[21:48:49] [PASSED] 4
[21:48:49] [PASSED] 8
[21:48:49] [PASSED] 32
[21:48:49] [PASSED] 256
[21:48:49] =================== [PASSED] test_reuse ====================
[21:48:49] =================== test_range_overlap ====================
[21:48:49] [PASSED] 4
[21:48:49] [PASSED] 8
[21:48:49] [PASSED] 32
[21:48:49] [PASSED] 256
[21:48:49] =============== [PASSED] test_range_overlap ================
[21:48:49] =================== test_range_compact ====================
[21:48:49] [PASSED] 4
[21:48:49] [PASSED] 8
[21:48:49] [PASSED] 32
[21:48:49] [PASSED] 256
[21:48:49] =============== [PASSED] test_range_compact ================
[21:48:49] ==================== test_range_spare =====================
[21:48:49] [PASSED] 4
[21:48:49] [PASSED] 8
[21:48:49] [PASSED] 32
[21:48:49] [PASSED] 256
[21:48:49] ================ [PASSED] test_range_spare =================
[21:48:49] ===================== [PASSED] guc_dbm =====================
[21:48:49] =================== guc_idm (6 subtests) ===================
[21:48:49] [PASSED] bad_init
[21:48:49] [PASSED] no_init
[21:48:49] [PASSED] init_fini
[21:48:49] [PASSED] check_used
[21:48:49] [PASSED] check_quota
[21:48:49] [PASSED] check_all
[21:48:49] ===================== [PASSED] guc_idm =====================
[21:48:49] ================== no_relay (3 subtests) ===================
[21:48:49] [PASSED] xe_drops_guc2pf_if_not_ready
[21:48:49] [PASSED] xe_drops_guc2vf_if_not_ready
[21:48:49] [PASSED] xe_rejects_send_if_not_ready
[21:48:49] ==================== [PASSED] no_relay =====================
[21:48:49] ================== pf_relay (14 subtests) ==================
[21:48:49] [PASSED] pf_rejects_guc2pf_too_short
[21:48:49] [PASSED] pf_rejects_guc2pf_too_long
[21:48:49] [PASSED] pf_rejects_guc2pf_no_payload
[21:48:49] [PASSED] pf_fails_no_payload
[21:48:49] [PASSED] pf_fails_bad_origin
[21:48:49] [PASSED] pf_fails_bad_type
[21:48:49] [PASSED] pf_txn_reports_error
[21:48:49] [PASSED] pf_txn_sends_pf2guc
[21:48:49] [PASSED] pf_sends_pf2guc
[21:48:49] [SKIPPED] pf_loopback_nop
[21:48:49] [SKIPPED] pf_loopback_echo
[21:48:49] [SKIPPED] pf_loopback_fail
[21:48:49] [SKIPPED] pf_loopback_busy
[21:48:49] [SKIPPED] pf_loopback_retry
[21:48:49] ==================== [PASSED] pf_relay =====================
[21:48:49] ================== vf_relay (3 subtests) ===================
[21:48:49] [PASSED] vf_rejects_guc2vf_too_short
[21:48:49] [PASSED] vf_rejects_guc2vf_too_long
[21:48:49] [PASSED] vf_rejects_guc2vf_no_payload
[21:48:49] ==================== [PASSED] vf_relay =====================
[21:48:49] ================= pf_service (11 subtests) =================
[21:48:49] [PASSED] pf_negotiate_any
[21:48:49] [PASSED] pf_negotiate_base_match
[21:48:49] [PASSED] pf_negotiate_base_newer
[21:48:49] [PASSED] pf_negotiate_base_next
[21:48:49] [SKIPPED] pf_negotiate_base_older
[21:48:49] [PASSED] pf_negotiate_base_prev
[21:48:49] [PASSED] pf_negotiate_latest_match
[21:48:49] [PASSED] pf_negotiate_latest_newer
[21:48:49] [PASSED] pf_negotiate_latest_next
[21:48:49] [SKIPPED] pf_negotiate_latest_older
[21:48:49] [SKIPPED] pf_negotiate_latest_prev
[21:48:49] =================== [PASSED] pf_service ====================
[21:48:49] ===================== lmtt (1 subtest) =====================
[21:48:49] ======================== test_ops =========================
[21:48:49] [PASSED] 2-level
[21:48:49] [PASSED] multi-level
[21:48:49] ==================== [PASSED] test_ops =====================
[21:48:49] ====================== [PASSED] lmtt =======================
[21:48:49] ==================== xe_bo (2 subtests) ====================
[21:48:49] [SKIPPED] xe_ccs_migrate_kunit
[21:48:49] [SKIPPED] xe_bo_evict_kunit
[21:48:49] ===================== [SKIPPED] xe_bo ======================
[21:48:49] ================== xe_dma_buf (1 subtest) ==================
[21:48:49] [SKIPPED] xe_dma_buf_kunit
[21:48:49] =================== [SKIPPED] xe_dma_buf ===================
[21:48:49] ================== xe_migrate (1 subtest) ==================
[21:48:49] [SKIPPED] xe_migrate_sanity_kunit
[21:48:49] =================== [SKIPPED] xe_migrate ===================
[21:48:49] =================== xe_mocs (2 subtests) ===================
[21:48:49] [SKIPPED] xe_live_mocs_kernel_kunit
[21:48:49] [SKIPPED] xe_live_mocs_reset_kunit
[21:48:49] ==================== [SKIPPED] xe_mocs =====================
[21:48:49] =================== xe_pci (2 subtests) ====================
[21:48:49] [PASSED] xe_gmdid_graphics_ip
[21:48:49] [PASSED] xe_gmdid_media_ip
[21:48:49] ===================== [PASSED] xe_pci ======================
[21:48:49] ==================== xe_rtp (1 subtest) ====================
[21:48:49] ================== xe_rtp_process_tests ===================
[21:48:49] [PASSED] coalesce-same-reg
[21:48:49] [PASSED] no-match-no-add
[21:48:49] [PASSED] no-match-no-add-multiple-rules
[21:48:49] [PASSED] two-regs-two-entries
[21:48:49] [PASSED] clr-one-set-other
[21:48:49] [PASSED] set-field
[21:48:49] [PASSED] conflict-duplicate
[21:48:49] [PASSED] conflict-not-disjoint
[21:48:49] [PASSED] conflict-reg-type
[21:48:49] ============== [PASSED] xe_rtp_process_tests ===============
[21:48:49] ===================== [PASSED] xe_rtp ======================
[21:48:49] ==================== xe_wa (1 subtest) =====================
[21:48:49] ======================== xe_wa_gt =========================
[21:48:49] [PASSED] TIGERLAKE (B0)
[21:48:49] [PASSED] DG1 (A0)
[21:48:49] [PASSED] DG1 (B0)
[21:48:49] [PASSED] ALDERLAKE_S (A0)
[21:48:49] [PASSED] ALDERLAKE_S (B0)
[21:48:49] [PASSED] ALDERLAKE_S (C0)
[21:48:49] [PASSED] ALDERLAKE_S (D0)
[21:48:49] [PASSED] ALDERLAKE_P (A0)
[21:48:49] [PASSED] ALDERLAKE_P (B0)
[21:48:49] [PASSED] ALDERLAKE_P (C0)
[21:48:49] [PASSED] ALDERLAKE_S_RPLS (D0)
[21:48:49] [PASSED] ALDERLAKE_P_RPLU (E0)
[21:48:49] [PASSED] DG2_G10 (C0)
[21:48:49] [PASSED] DG2_G11 (B1)
[21:48:49] [PASSED] DG2_G12 (A1)
[21:48:49] [PASSED] METEORLAKE (g:A0, m:A0)
[21:48:49] [PASSED] METEORLAKE (g:A0, m:A0)
[21:48:49] [PASSED] METEORLAKE (g:A0, m:A0)
[21:48:49] [PASSED] LUNARLAKE (g:A0, m:A0)
[21:48:49] [PASSED] LUNARLAKE (g:B0, m:A0)
[21:48:49] ==================== [PASSED] xe_wa_gt =====================
[21:48:49] ====================== [PASSED] xe_wa ======================
[21:48:49] ============================================================
[21:48:49] Testing complete. Ran 98 tests: passed: 84, skipped: 14
[21:48:49] Elapsed time: 29.824s total, 4.262s configuring, 25.343s building, 0.200s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[21:48:49] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[21:48:51] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make ARCH=um O=.kunit --jobs=48
In file included from ../arch/um/kernel/asm-offsets.c:1:
../arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes]
9 | void foo(void)
| ^~~
../arch/x86/um/ptrace_64.c:111:5: warning: no previous prototype for ‘poke_user’ [-Wmissing-prototypes]
111 | int poke_user(struct task_struct *child, long addr, long data)
| ^~~~~~~~~
../arch/x86/um/ptrace_64.c:171:5: warning: no previous prototype for ‘peek_user’ [-Wmissing-prototypes]
171 | int peek_user(struct task_struct *child, long addr, long data)
| ^~~~~~~~~
../arch/um/kernel/mem.c:202:8: warning: no previous prototype for ‘pgd_alloc’ [-Wmissing-prototypes]
202 | pgd_t *pgd_alloc(struct mm_struct *mm)
| ^~~~~~~~~
../arch/um/kernel/mem.c:215:7: warning: no previous prototype for ‘uml_kmalloc’ [-Wmissing-prototypes]
215 | void *uml_kmalloc(int size, int flags)
| ^~~~~~~~~~~
../arch/um/kernel/process.c:51:5: warning: no previous prototype for ‘pid_to_processor_id’ [-Wmissing-prototypes]
51 | int pid_to_processor_id(int pid)
| ^~~~~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:87:7: warning: no previous prototype for ‘__switch_to’ [-Wmissing-prototypes]
87 | void *__switch_to(struct task_struct *from, struct task_struct *to)
| ^~~~~~~~~~~
../arch/um/kernel/process.c:140:6: warning: no previous prototype for ‘fork_handler’ [-Wmissing-prototypes]
140 | void fork_handler(void)
| ^~~~~~~~~~~~
../arch/um/kernel/process.c:217:6: warning: no previous prototype for ‘arch_cpu_idle’ [-Wmissing-prototypes]
217 | void arch_cpu_idle(void)
| ^~~~~~~~~~~~~
../arch/um/kernel/process.c:253:5: warning: no previous prototype for ‘copy_to_user_proc’ [-Wmissing-prototypes]
253 | int copy_to_user_proc(void __user *to, void *from, int size)
| ^~~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:263:5: warning: no previous prototype for ‘clear_user_proc’ [-Wmissing-prototypes]
263 | int clear_user_proc(void __user *buf, int size)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/process.c:271:6: warning: no previous prototype for ‘set_using_sysemu’ [-Wmissing-prototypes]
271 | void set_using_sysemu(int value)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:278:5: warning: no previous prototype for ‘get_using_sysemu’ [-Wmissing-prototypes]
278 | int get_using_sysemu(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:316:12: warning: no previous prototype for ‘make_proc_sysemu’ [-Wmissing-prototypes]
316 | int __init make_proc_sysemu(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/process.c:348:15: warning: no previous prototype for ‘arch_align_stack’ [-Wmissing-prototypes]
348 | unsigned long arch_align_stack(unsigned long sp)
| ^~~~~~~~~~~~~~~~
../arch/x86/um/signal.c:560:6: warning: no previous prototype for ‘sys_rt_sigreturn’ [-Wmissing-prototypes]
560 | long sys_rt_sigreturn(void)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:45:6: warning: no previous prototype for ‘machine_restart’ [-Wmissing-prototypes]
45 | void machine_restart(char * __unused)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:51:6: warning: no previous prototype for ‘machine_power_off’ [-Wmissing-prototypes]
51 | void machine_power_off(void)
| ^~~~~~~~~~~~~~~~~
../arch/um/kernel/reboot.c:57:6: warning: no previous prototype for ‘machine_halt’ [-Wmissing-prototypes]
57 | void machine_halt(void)
| ^~~~~~~~~~~~
../arch/um/kernel/tlb.c:579:6: warning: no previous prototype for ‘flush_tlb_mm_range’ [-Wmissing-prototypes]
579 | void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
| ^~~~~~~~~~~~~~~~~~
../arch/um/kernel/tlb.c:594:6: warning: no previous prototype for ‘force_flush_all’ [-Wmissing-prototypes]
594 | void force_flush_all(void)
| ^~~~~~~~~~~~~~~
../arch/um/kernel/kmsg_dump.c:60:12: warning: no previous prototype for ‘kmsg_dumper_stdout_init’ [-Wmissing-prototypes]
60 | int __init kmsg_dumper_stdout_init(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
../arch/um/kernel/um_arch.c:408:19: warning: no previous prototype for ‘read_initrd’ [-Wmissing-prototypes]
408 | int __init __weak read_initrd(void)
| ^~~~~~~~~~~
../arch/um/kernel/um_arch.c:461:7: warning: no previous prototype for ‘text_poke’ [-Wmissing-prototypes]
461 | void *text_poke(void *addr, const void *opcode, size_t len)
| ^~~~~~~~~
../arch/um/kernel/um_arch.c:473:6: warning: no previous prototype for ‘text_poke_sync’ [-Wmissing-prototypes]
473 | void text_poke_sync(void)
| ^~~~~~~~~~~~~~
../arch/um/kernel/skas/process.c:36:12: warning: no previous prototype for ‘start_uml’ [-Wmissing-prototypes]
36 | int __init start_uml(void)
| ^~~~~~~~~
../arch/x86/um/syscalls_64.c:48:6: warning: no previous prototype for ‘arch_switch_to’ [-Wmissing-prototypes]
48 | void arch_switch_to(struct task_struct *to)
| ^~~~~~~~~~~~~~
../arch/um/kernel/skas/mmu.c:17:5: warning: no previous prototype for ‘init_new_context’ [-Wmissing-prototypes]
17 | int init_new_context(struct task_struct *task, struct mm_struct *mm)
| ^~~~~~~~~~~~~~~~
../arch/um/kernel/skas/mmu.c:60:6: warning: no previous prototype for ‘destroy_context’ [-Wmissing-prototypes]
60 | void destroy_context(struct mm_struct *mm)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes]
156 | u64 ioread64_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes]
163 | u64 ioread64_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes]
170 | u64 ioread64be_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes]
178 | u64 ioread64be_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes]
264 | void iowrite64_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes]
272 | void iowrite64_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes]
280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes]
288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
[21:49:13] Starting KUnit Kernel (1/1)...
[21:49:13] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[21:49:13] ============ drm_test_pick_cmdline (2 subtests) ============
[21:49:13] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[21:49:13] =============== drm_test_pick_cmdline_named ===============
[21:49:13] [PASSED] NTSC
[21:49:13] [PASSED] NTSC-J
[21:49:13] [PASSED] PAL
[21:49:13] [PASSED] PAL-M
[21:49:13] =========== [PASSED] drm_test_pick_cmdline_named ===========
[21:49:13] ============== [PASSED] drm_test_pick_cmdline ==============
[21:49:13] ================== drm_buddy (7 subtests) ==================
[21:49:13] [PASSED] drm_test_buddy_alloc_limit
[21:49:13] [PASSED] drm_test_buddy_alloc_optimistic
[21:49:13] [PASSED] drm_test_buddy_alloc_pessimistic
[21:49:13] [PASSED] drm_test_buddy_alloc_pathological
[21:49:13] [PASSED] drm_test_buddy_alloc_contiguous
[21:49:13] [PASSED] drm_test_buddy_alloc_clear
[21:49:13] [PASSED] drm_test_buddy_alloc_range_bias
[21:49:13] ==================== [PASSED] drm_buddy ====================
[21:49:13] ============= drm_cmdline_parser (40 subtests) =============
[21:49:13] [PASSED] drm_test_cmdline_force_d_only
[21:49:13] [PASSED] drm_test_cmdline_force_D_only_dvi
[21:49:13] [PASSED] drm_test_cmdline_force_D_only_hdmi
[21:49:13] [PASSED] drm_test_cmdline_force_D_only_not_digital
[21:49:13] [PASSED] drm_test_cmdline_force_e_only
[21:49:13] [PASSED] drm_test_cmdline_res
[21:49:13] [PASSED] drm_test_cmdline_res_vesa
[21:49:13] [PASSED] drm_test_cmdline_res_vesa_rblank
[21:49:13] [PASSED] drm_test_cmdline_res_rblank
[21:49:13] [PASSED] drm_test_cmdline_res_bpp
[21:49:13] [PASSED] drm_test_cmdline_res_refresh
[21:49:13] [PASSED] drm_test_cmdline_res_bpp_refresh
[21:49:13] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[21:49:13] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[21:49:13] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[21:49:13] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[21:49:13] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[21:49:13] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[21:49:13] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[21:49:13] [PASSED] drm_test_cmdline_res_margins_force_on
[21:49:13] [PASSED] drm_test_cmdline_res_vesa_margins
[21:49:13] [PASSED] drm_test_cmdline_name
[21:49:13] [PASSED] drm_test_cmdline_name_bpp
[21:49:13] [PASSED] drm_test_cmdline_name_option
[21:49:13] [PASSED] drm_test_cmdline_name_bpp_option
[21:49:13] [PASSED] drm_test_cmdline_rotate_0
[21:49:13] [PASSED] drm_test_cmdline_rotate_90
[21:49:13] [PASSED] drm_test_cmdline_rotate_180
[21:49:13] [PASSED] drm_test_cmdline_rotate_270
[21:49:13] [PASSED] drm_test_cmdline_hmirror
[21:49:13] [PASSED] drm_test_cmdline_vmirror
[21:49:13] [PASSED] drm_test_cmdline_margin_options
[21:49:13] [PASSED] drm_test_cmdline_multiple_options
[21:49:13] [PASSED] drm_test_cmdline_bpp_extra_and_option
[21:49:13] [PASSED] drm_test_cmdline_extra_and_option
[21:49:13] [PASSED] drm_test_cmdline_freestanding_options
[21:49:13] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[21:49:13] [PASSED] drm_test_cmdline_panel_orientation
[21:49:13] ================ drm_test_cmdline_invalid =================
[21:49:13] [PASSED] margin_only
[21:49:13] [PASSED] interlace_only
[21:49:13] [PASSED] res_missing_x
[21:49:13] [PASSED] res_missing_y
[21:49:13] [PASSED] res_bad_y
[21:49:13] [PASSED] res_missing_y_bpp
[21:49:13] [PASSED] res_bad_bpp
[21:49:13] [PASSED] res_bad_refresh
[21:49:13] [PASSED] res_bpp_refresh_force_on_off
[21:49:13] [PASSED] res_invalid_mode
[21:49:13] [PASSED] res_bpp_wrong_place_mode
[21:49:13] [PASSED] name_bpp_refresh
[21:49:13] [PASSED] name_refresh
[21:49:13] [PASSED] name_refresh_wrong_mode
[21:49:13] [PASSED] name_refresh_invalid_mode
[21:49:13] [PASSED] rotate_multiple
[21:49:13] [PASSED] rotate_invalid_val
[21:49:13] [PASSED] rotate_truncated
[21:49:13] [PASSED] invalid_option
[21:49:13] [PASSED] invalid_tv_option
[21:49:13] [PASSED] truncated_tv_option
[21:49:13] ============ [PASSED] drm_test_cmdline_invalid =============
[21:49:13] =============== drm_test_cmdline_tv_options ===============
[21:49:13] [PASSED] NTSC
[21:49:13] [PASSED] NTSC_443
[21:49:13] [PASSED] NTSC_J
[21:49:13] [PASSED] PAL
[21:49:13] [PASSED] PAL_M
[21:49:13] [PASSED] PAL_N
[21:49:13] [PASSED] SECAM
[21:49:13] =========== [PASSED] drm_test_cmdline_tv_options ===========
[21:49:13] =============== [PASSED] drm_cmdline_parser ================
[21:49:13] ============= drmm_connector_init (3 subtests) =============
[21:49:13] [PASSED] drm_test_drmm_connector_init
[21:49:13] [PASSED] drm_test_drmm_connector_init_null_ddc
[21:49:13] ========= drm_test_drmm_connector_init_type_valid =========
[21:49:13] [PASSED] Unknown
[21:49:13] [PASSED] VGA
[21:49:13] [PASSED] DVI-I
[21:49:13] [PASSED] DVI-D
[21:49:13] [PASSED] DVI-A
[21:49:13] [PASSED] Composite
[21:49:13] [PASSED] SVIDEO
[21:49:13] [PASSED] LVDS
[21:49:13] [PASSED] Component
[21:49:13] [PASSED] DIN
[21:49:13] [PASSED] DP
[21:49:13] [PASSED] HDMI-A
[21:49:13] [PASSED] HDMI-B
[21:49:13] [PASSED] TV
[21:49:13] [PASSED] eDP
[21:49:13] [PASSED] Virtual
[21:49:13] [PASSED] DSI
[21:49:13] [PASSED] DPI
[21:49:13] [PASSED] Writeback
[21:49:13] [PASSED] SPI
[21:49:13] [PASSED] USB
[21:49:13] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[21:49:13] =============== [PASSED] drmm_connector_init ===============
[21:49:13] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[21:49:13] ========== drm_test_get_tv_mode_from_name_valid ===========
[21:49:13] [PASSED] NTSC
[21:49:13] [PASSED] NTSC-443
[21:49:13] [PASSED] NTSC-J
[21:49:13] [PASSED] PAL
[21:49:13] [PASSED] PAL-M
[21:49:13] [PASSED] PAL-N
[21:49:13] [PASSED] SECAM
[21:49:13] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[21:49:13] [PASSED] drm_test_get_tv_mode_from_name_truncated
[21:49:13] ============ [PASSED] drm_get_tv_mode_from_name ============
[21:49:13] ============= drm_damage_helper (21 subtests) ==============
[21:49:13] [PASSED] drm_test_damage_iter_no_damage
[21:49:13] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[21:49:13] [PASSED] drm_test_damage_iter_no_damage_src_moved
[21:49:13] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[21:49:13] [PASSED] drm_test_damage_iter_no_damage_not_visible
[21:49:13] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[21:49:13] [PASSED] drm_test_damage_iter_no_damage_no_fb
[21:49:13] [PASSED] drm_test_damage_iter_simple_damage
[21:49:13] [PASSED] drm_test_damage_iter_single_damage
[21:49:13] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[21:49:13] [PASSED] drm_test_damage_iter_single_damage_outside_src
[21:49:13] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[21:49:13] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[21:49:13] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[21:49:13] [PASSED] drm_test_damage_iter_single_damage_src_moved
[21:49:13] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[21:49:13] [PASSED] drm_test_damage_iter_damage
[21:49:13] [PASSED] drm_test_damage_iter_damage_one_intersect
[21:49:13] [PASSED] drm_test_damage_iter_damage_one_outside
[21:49:13] [PASSED] drm_test_damage_iter_damage_src_moved
[21:49:13] [PASSED] drm_test_damage_iter_damage_not_visible
[21:49:13] ================ [PASSED] drm_damage_helper ================
[21:49:13] ============== drm_dp_mst_helper (3 subtests) ==============
[21:49:13] ============== drm_test_dp_mst_calc_pbn_mode ==============
[21:49:13] [PASSED] Clock 154000 BPP 30 DSC disabled
[21:49:13] [PASSED] Clock 234000 BPP 30 DSC disabled
[21:49:13] [PASSED] Clock 297000 BPP 24 DSC disabled
[21:49:13] [PASSED] Clock 332880 BPP 24 DSC enabled
[21:49:13] [PASSED] Clock 324540 BPP 24 DSC enabled
[21:49:13] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[21:49:13] ============== drm_test_dp_mst_calc_pbn_div ===============
[21:49:13] [PASSED] Link rate 2000000 lane count 4
[21:49:13] [PASSED] Link rate 2000000 lane count 2
[21:49:13] [PASSED] Link rate 2000000 lane count 1
[21:49:13] [PASSED] Link rate 1350000 lane count 4
[21:49:13] [PASSED] Link rate 1350000 lane count 2
[21:49:13] [PASSED] Link rate 1350000 lane count 1
[21:49:13] [PASSED] Link rate 1000000 lane count 4
[21:49:13] [PASSED] Link rate 1000000 lane count 2
[21:49:13] [PASSED] Link rate 1000000 lane count 1
[21:49:13] [PASSED] Link rate 810000 lane count 4
[21:49:13] [PASSED] Link rate 810000 lane count 2
[21:49:13] [PASSED] Link rate 810000 lane count 1
[21:49:13] [PASSED] Link rate 540000 lane count 4
[21:49:13] [PASSED] Link rate 540000 lane count 2
[21:49:13] [PASSED] Link rate 540000 lane count 1
[21:49:13] [PASSED] Link rate 270000 lane count 4
[21:49:13] [PASSED] Link rate 270000 lane count 2
[21:49:13] [PASSED] Link rate 270000 lane count 1
[21:49:13] [PASSED] Link rate 162000 lane count 4
[21:49:13] [PASSED] Link rate 162000 lane count 2
[21:49:13] [PASSED] Link rate 162000 lane count 1
[21:49:13] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[21:49:13] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[21:49:13] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[21:49:13] [PASSED] DP_POWER_UP_PHY with port number
[21:49:13] [PASSED] DP_POWER_DOWN_PHY with port number
[21:49:13] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[21:49:13] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[21:49:13] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[21:49:13] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[21:49:13] [PASSED] DP_QUERY_PAYLOAD with port number
[21:49:13] [PASSED] DP_QUERY_PAYLOAD with VCPI
[21:49:13] [PASSED] DP_REMOTE_DPCD_READ with port number
[21:49:13] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[21:49:13] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[21:49:13] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[21:49:13] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[21:49:13] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[21:49:13] [PASSED] DP_REMOTE_I2C_READ with port number
[21:49:13] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[21:49:13] [PASSED] DP_REMOTE_I2C_READ with transactions array
[21:49:13] [PASSED] DP_REMOTE_I2C_WRITE with port number
[21:49:13] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[21:49:13] [PASSED] DP_REMOTE_I2C_WRITE with data array
[21:49:13] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[21:49:13] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[21:49:13] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[21:49:13] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[21:49:13] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[21:49:13] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[21:49:13] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[21:49:13] ================ [PASSED] drm_dp_mst_helper ================
[21:49:13] ================== drm_exec (7 subtests) ===================
[21:49:13] [PASSED] sanitycheck
[21:49:13] [PASSED] test_lock
[21:49:13] [PASSED] test_lock_unlock
[21:49:13] [PASSED] test_duplicates
[21:49:13] [PASSED] test_prepare
[21:49:13] [PASSED] test_prepare_array
[21:49:13] [PASSED] test_multiple_loops
[21:49:13] ==================== [PASSED] drm_exec =====================
[21:49:13] =========== drm_format_helper_test (17 subtests) ===========
[21:49:13] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[21:49:13] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[21:49:13] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[21:49:13] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[21:49:13] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[21:49:13] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[21:49:13] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[21:49:13] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[21:49:13] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[21:49:13] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[21:49:13] ============== drm_test_fb_xrgb8888_to_mono ===============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[21:49:13] ==================== drm_test_fb_swab =====================
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ================ [PASSED] drm_test_fb_swab =================
[21:49:13] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[21:49:13] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[21:49:13] [PASSED] single_pixel_source_buffer
[21:49:13] [PASSED] single_pixel_clip_rectangle
[21:49:13] [PASSED] well_known_colors
[21:49:13] [PASSED] destination_pitch
[21:49:13] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[21:49:13] ================= drm_test_fb_clip_offset =================
[21:49:13] [PASSED] pass through
[21:49:13] [PASSED] horizontal offset
[21:49:13] [PASSED] vertical offset
[21:49:13] [PASSED] horizontal and vertical offset
[21:49:13] [PASSED] horizontal offset (custom pitch)
[21:49:13] [PASSED] vertical offset (custom pitch)
[21:49:13] [PASSED] horizontal and vertical offset (custom pitch)
[21:49:13] ============= [PASSED] drm_test_fb_clip_offset =============
[21:49:13] ============== drm_test_fb_build_fourcc_list ==============
[21:49:13] [PASSED] no native formats
[21:49:13] [PASSED] XRGB8888 as native format
[21:49:13] [PASSED] remove duplicates
[21:49:13] [PASSED] convert alpha formats
[21:49:13] [PASSED] random formats
[21:49:13] ========== [PASSED] drm_test_fb_build_fourcc_list ==========
[21:49:13] =================== drm_test_fb_memcpy ====================
[21:49:13] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[21:49:13] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[21:49:13] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[21:49:13] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[21:49:13] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[21:49:13] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[21:49:13] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[21:49:13] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[21:49:13] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[21:49:13] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[21:49:13] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[21:49:13] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[21:49:13] =============== [PASSED] drm_test_fb_memcpy ================
[21:49:13] ============= [PASSED] drm_format_helper_test ==============
[21:49:13] ================= drm_format (18 subtests) =================
[21:49:13] [PASSED] drm_test_format_block_width_invalid
[21:49:13] [PASSED] drm_test_format_block_width_one_plane
[21:49:13] [PASSED] drm_test_format_block_width_two_plane
[21:49:13] [PASSED] drm_test_format_block_width_three_plane
[21:49:13] [PASSED] drm_test_format_block_width_tiled
[21:49:13] [PASSED] drm_test_format_block_height_invalid
[21:49:13] [PASSED] drm_test_format_block_height_one_plane
[21:49:13] [PASSED] drm_test_format_block_height_two_plane
[21:49:13] [PASSED] drm_test_format_block_height_three_plane
[21:49:13] [PASSED] drm_test_format_block_height_tiled
[21:49:13] [PASSED] drm_test_format_min_pitch_invalid
[21:49:13] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[21:49:13] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[21:49:13] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[21:49:13] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[21:49:13] [PASSED] drm_test_format_min_pitch_two_plane
[21:49:13] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[21:49:13] [PASSED] drm_test_format_min_pitch_tiled
[21:49:13] =================== [PASSED] drm_format ====================
[21:49:13] =============== drm_framebuffer (1 subtest) ================
[21:49:13] =============== drm_test_framebuffer_create ===============
[21:49:13] [PASSED] ABGR8888 normal sizes
[21:49:13] [PASSED] ABGR8888 max sizes
[21:49:13] [PASSED] ABGR8888 pitch greater than min required
[21:49:13] [PASSED] ABGR8888 pitch less than min required
[21:49:13] [PASSED] ABGR8888 Invalid width
[21:49:13] [PASSED] ABGR8888 Invalid buffer handle
[21:49:13] [PASSED] No pixel format
[21:49:13] [PASSED] ABGR8888 Width 0
[21:49:13] [PASSED] ABGR8888 Height 0
[21:49:13] [PASSED] ABGR8888 Out of bound height * pitch combination
[21:49:13] [PASSED] ABGR8888 Large buffer offset
[21:49:13] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[21:49:13] [PASSED] ABGR8888 Valid buffer modifier
[21:49:13] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[21:49:13] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[21:49:13] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[21:49:13] [PASSED] NV12 Normal sizes
[21:49:13] [PASSED] NV12 Max sizes
[21:49:13] [PASSED] NV12 Invalid pitch
[21:49:13] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[21:49:13] [PASSED] NV12 different modifier per-plane
[21:49:13] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[21:49:13] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[21:49:13] [PASSED] NV12 Modifier for inexistent plane
[21:49:13] [PASSED] NV12 Handle for inexistent plane
[21:49:13] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[21:49:13] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[21:49:13] [PASSED] YVU420 Normal sizes
[21:49:13] [PASSED] YVU420 Max sizes
[21:49:13] [PASSED] YVU420 Invalid pitch
[21:49:13] [PASSED] YVU420 Different pitches
[21:49:13] [PASSED] YVU420 Different buffer offsets/pitches
[21:49:13] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[21:49:13] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[21:49:13] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[21:49:13] [PASSED] YVU420 Valid modifier
[21:49:13] [PASSED] YVU420 Different modifiers per plane
[21:49:13] [PASSED] YVU420 Modifier for inexistent plane
[21:49:13] [PASSED] X0L2 Normal sizes
[21:49:13] [PASSED] X0L2 Max sizes
[21:49:13] [PASSED] X0L2 Invalid pitch
[21:49:13] [PASSED] X0L2 Pitch greater than minimum required
[21:49:13] [PASSED] X0L2 Handle for inexistent plane
[21:49:13] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[21:49:13] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[21:49:13] [PASSED] X0L2 Valid modifier
[21:49:13] [PASSED] X0L2 Modifier for inexistent plane
[21:49:13] =========== [PASSED] drm_test_framebuffer_create ===========
[21:49:13] ================= [PASSED] drm_framebuffer =================
[21:49:13] ================ drm_gem_shmem (8 subtests) ================
[21:49:13] [PASSED] drm_gem_shmem_test_obj_create
[21:49:13] [PASSED] drm_gem_shmem_test_obj_create_private
[21:49:13] [PASSED] drm_gem_shmem_test_pin_pages
[21:49:13] [PASSED] drm_gem_shmem_test_vmap
[21:49:13] [PASSED] drm_gem_shmem_test_get_pages_sgt
[21:49:13] [PASSED] drm_gem_shmem_test_get_sg_table
[21:49:13] [PASSED] drm_gem_shmem_test_madvise
[21:49:13] [PASSED] drm_gem_shmem_test_purge
[21:49:13] ================== [PASSED] drm_gem_shmem ==================
[21:49:13] ================= drm_managed (2 subtests) =================
[21:49:13] [PASSED] drm_test_managed_release_action
[21:49:13] [PASSED] drm_test_managed_run_action
[21:49:13] =================== [PASSED] drm_managed ===================
[21:49:13] =================== drm_mm (6 subtests) ====================
[21:49:13] [PASSED] drm_test_mm_init
[21:49:13] [PASSED] drm_test_mm_debug
[21:49:13] [PASSED] drm_test_mm_align32
[21:49:13] [PASSED] drm_test_mm_align64
[21:49:13] [PASSED] drm_test_mm_lowest
[21:49:13] [PASSED] drm_test_mm_highest
[21:49:13] ===================== [PASSED] drm_mm ======================
[21:49:13] ============= drm_modes_analog_tv (4 subtests) =============
[21:49:13] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[21:49:13] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[21:49:13] [PASSED] drm_test_modes_analog_tv_pal_576i
[21:49:13] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[21:49:13] =============== [PASSED] drm_modes_analog_tv ===============
[21:49:13] ============== drm_plane_helper (2 subtests) ===============
[21:49:13] =============== drm_test_check_plane_state ================
[21:49:13] [PASSED] clipping_simple
[21:49:13] [PASSED] clipping_rotate_reflect
[21:49:13] [PASSED] positioning_simple
[21:49:13] [PASSED] upscaling
[21:49:13] [PASSED] downscaling
[21:49:13] [PASSED] rounding1
[21:49:13] [PASSED] rounding2
[21:49:13] [PASSED] rounding3
[21:49:13] [PASSED] rounding4
[21:49:13] =========== [PASSED] drm_test_check_plane_state ============
[21:49:13] =========== drm_test_check_invalid_plane_state ============
[21:49:13] [PASSED] positioning_invalid
[21:49:13] [PASSED] upscaling_invalid
[21:49:13] [PASSED] downscaling_invalid
[21:49:13] ======= [PASSED] drm_test_check_invalid_plane_state ========
[21:49:13] ================ [PASSED] drm_plane_helper =================
[21:49:13] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[21:49:13] ====== drm_test_connector_helper_tv_get_modes_check =======
[21:49:13] [PASSED] None
[21:49:13] [PASSED] PAL
[21:49:13] [PASSED] NTSC
[21:49:13] [PASSED] Both, NTSC Default
[21:49:13] [PASSED] Both, PAL Default
[21:49:13] [PASSED] Both, NTSC Default, with PAL on command-line
[21:49:13] [PASSED] Both, PAL Default, with NTSC on command-line
[21:49:13] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[21:49:13] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[21:49:13] ================== drm_rect (9 subtests) ===================
[21:49:13] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[21:49:13] [PASSED] drm_test_rect_clip_scaled_not_clipped
[21:49:13] [PASSED] drm_test_rect_clip_scaled_clipped
stty: 'standard input': Inappropriate ioctl for device
[21:49:13] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[21:49:13] ================= drm_test_rect_intersect =================
[21:49:13] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[21:49:13] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[21:49:13] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[21:49:13] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[21:49:13] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[21:49:13] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[21:49:13] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[21:49:13] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[21:49:13] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[21:49:13] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[21:49:13] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[21:49:13] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[21:49:13] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[21:49:13] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[21:49:13] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[21:49:13] ============= [PASSED] drm_test_rect_intersect =============
[21:49:13] ================ drm_test_rect_calc_hscale ================
[21:49:13] [PASSED] normal use
[21:49:13] [PASSED] out of max range
[21:49:13] [PASSED] out of min range
[21:49:13] [PASSED] zero dst
[21:49:13] [PASSED] negative src
[21:49:13] [PASSED] negative dst
[21:49:13] ============ [PASSED] drm_test_rect_calc_hscale ============
[21:49:13] ================ drm_test_rect_calc_vscale ================
[21:49:13] [PASSED] normal use
[21:49:13] [PASSED] out of max range
[21:49:13] [PASSED] out of min range
[21:49:13] [PASSED] zero dst
[21:49:13] [PASSED] negative src
[21:49:13] [PASSED] negative dst
[21:49:13] ============ [PASSED] drm_test_rect_calc_vscale ============
[21:49:13] ================== drm_test_rect_rotate ===================
[21:49:13] [PASSED] reflect-x
[21:49:13] [PASSED] reflect-y
[21:49:13] [PASSED] rotate-0
[21:49:13] [PASSED] rotate-90
[21:49:13] [PASSED] rotate-180
[21:49:13] [PASSED] rotate-270
[21:49:13] ============== [PASSED] drm_test_rect_rotate ===============
[21:49:13] ================ drm_test_rect_rotate_inv =================
[21:49:13] [PASSED] reflect-x
[21:49:13] [PASSED] reflect-y
[21:49:13] [PASSED] rotate-0
[21:49:13] [PASSED] rotate-90
[21:49:13] [PASSED] rotate-180
[21:49:13] [PASSED] rotate-270
[21:49:13] ============ [PASSED] drm_test_rect_rotate_inv =============
[21:49:13] ==================== [PASSED] drm_rect =====================
[21:49:13] ============================================================
[21:49:13] Testing complete. Ran 417 tests: passed: 417
[21:49:13] Elapsed time: 23.580s total, 1.688s configuring, 21.701s building, 0.188s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm: print top commit sha after loading the driver
2024-04-24 10:07 [PATCH 1/2] drm: print top commit sha after loading the driver Farah Kassabri
` (3 preceding siblings ...)
2024-04-28 21:49 ` ✓ CI.KUnit: " Patchwork
@ 2024-04-29 11:02 ` Jani Nikula
2024-04-29 15:32 ` Lucas De Marchi
4 siblings, 1 reply; 12+ messages in thread
From: Jani Nikula @ 2024-04-29 11:02 UTC (permalink / raw)
To: Farah Kassabri, intel-xe; +Cc: osharabi, Farah Kassabri
On Wed, 24 Apr 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
> Add the last driver sha to the existing log message
> which prints the drm device info.
The commit message fails to answer the most important question: why?
Especially, what makes drm devices such special snowflakes that they'd
need to be the only ones in the kernel to print git commit sha1's?
BR,
Jani.
>
> Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
> ---
> drivers/gpu/drm/drm_drv.c | 6 +++---
> include/drm/drm_drv.h | 2 ++
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 535b624d4c9d..e0f7af1b6ec3 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -947,10 +947,10 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
> }
> drm_panic_register(dev);
>
> - DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
> + DRM_INFO("Initialized %s %d.%d.%d%s %s for %s on minor %d\n",
> driver->name, driver->major, driver->minor,
> - driver->patchlevel, driver->date,
> - dev->dev ? dev_name(dev->dev) : "virtual device",
> + driver->patchlevel, driver->git_sha ? driver->git_sha : "",
> + driver->date, dev->dev ? dev_name(dev->dev) : "virtual device",
> dev->primary ? dev->primary->index : dev->accel->index);
>
> goto out_unlock;
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 8878260d7529..7578a1f4ce74 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -407,6 +407,8 @@ struct drm_driver {
> int minor;
> /** @patchlevel: driver patch level */
> int patchlevel;
> + /** @git_sha: driver last commit sha */
> + char *git_sha;
> /** @name: driver name */
> char *name;
> /** @desc: driver description */
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] drm/xe: set last driver commit sha
2024-04-24 10:07 ` [PATCH 2/2] drm/xe: set last driver commit sha Farah Kassabri
@ 2024-04-29 11:15 ` Jani Nikula
2024-05-08 12:09 ` Farah Kassabri
0 siblings, 1 reply; 12+ messages in thread
From: Jani Nikula @ 2024-04-29 11:15 UTC (permalink / raw)
To: Farah Kassabri, intel-xe; +Cc: osharabi, Farah Kassabri
On Wed, 24 Apr 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
> This patch will set the last driver commit sha into the drm driver
> info data structure, which will be used in the log message which
> prints the device info at the end of the driver initialization.
>
> Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
> ---
> drivers/gpu/drm/xe/Makefile | 4 ++++
> drivers/gpu/drm/xe/xe_device.c | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index 8321ec4f9b46..acccb517b7bb 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -309,6 +309,10 @@ ifeq ($(CONFIG_DEBUG_FS),y)
> i915-display/intel_pipe_crc.o
> endif
>
> +GIT_SHA ?= $(shell cd $(srctree) && git rev-parse --short HEAD)
There are no guarantees that the kernel is being built from a git
checkout. Or if it is, that there are no uncommitted changes. Etc. See
scripts/setlocalversion.
IMO it's just not so simple that we could reasonably add this into a
local Makefile.
BR,
Jani.
> +DRV_CFLAGS_MODULE="-DXE_DRIVER_GIT_SHA=-$(GIT_SHA)"
> +CFLAGS_MODULE += ${DRV_CFLAGS_MODULE}
> +
> obj-$(CONFIG_DRM_XE) += xe.o
> obj-$(CONFIG_DRM_XE_KUNIT_TEST) += tests/
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 55bbc8b8df15..2e74aa18e953 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -215,6 +215,7 @@ static struct drm_driver driver = {
> .major = DRIVER_MAJOR,
> .minor = DRIVER_MINOR,
> .patchlevel = DRIVER_PATCHLEVEL,
> + .git_sha = __stringify(XE_DRIVER_GIT_SHA),
> };
>
> static void xe_device_destroy(struct drm_device *dev, void *dummy)
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm: print top commit sha after loading the driver
2024-04-29 11:02 ` [PATCH 1/2] " Jani Nikula
@ 2024-04-29 15:32 ` Lucas De Marchi
2024-05-08 11:01 ` Farah Kassabri
0 siblings, 1 reply; 12+ messages in thread
From: Lucas De Marchi @ 2024-04-29 15:32 UTC (permalink / raw)
To: Jani Nikula; +Cc: Farah Kassabri, intel-xe, osharabi, dri-devel
On Mon, Apr 29, 2024 at 02:02:28PM GMT, Jani Nikula wrote:
>On Wed, 24 Apr 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
>> Add the last driver sha to the existing log message
>> which prints the drm device info.
>
>The commit message fails to answer the most important question: why?
>
>Especially, what makes drm devices such special snowflakes that they'd
>need to be the only ones in the kernel to print git commit sha1's?
the closest to what was added here would be srcversion:
$ modinfo build64/drivers/gpu/drm/xe/xe.ko | grep srcversion
srcversion: 0EA08A43AC399A0D942740
which makes more sense and doesn't depend on the git tree checkout and
other possible problems with dirty checkouts. If you want to print it
on module load to be able to tell from a log, you could probably just
access mod->srcversion.
but I'm not sure what we are trying to accomplish here and the commit
message certainly missed that. Please Cc dri-devel on changes outside xe
and provide the motivation in the commit message.
thanks
Lucas De Marchi
>
>BR,
>Jani.
>
>>
>> Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
>> ---
>> drivers/gpu/drm/drm_drv.c | 6 +++---
>> include/drm/drm_drv.h | 2 ++
>> 2 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
>> index 535b624d4c9d..e0f7af1b6ec3 100644
>> --- a/drivers/gpu/drm/drm_drv.c
>> +++ b/drivers/gpu/drm/drm_drv.c
>> @@ -947,10 +947,10 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
>> }
>> drm_panic_register(dev);
>>
>> - DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
>> + DRM_INFO("Initialized %s %d.%d.%d%s %s for %s on minor %d\n",
>> driver->name, driver->major, driver->minor,
>> - driver->patchlevel, driver->date,
>> - dev->dev ? dev_name(dev->dev) : "virtual device",
>> + driver->patchlevel, driver->git_sha ? driver->git_sha : "",
>> + driver->date, dev->dev ? dev_name(dev->dev) : "virtual device",
>> dev->primary ? dev->primary->index : dev->accel->index);
>>
>> goto out_unlock;
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 8878260d7529..7578a1f4ce74 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -407,6 +407,8 @@ struct drm_driver {
>> int minor;
>> /** @patchlevel: driver patch level */
>> int patchlevel;
>> + /** @git_sha: driver last commit sha */
>> + char *git_sha;
>> /** @name: driver name */
>> char *name;
>> /** @desc: driver description */
>
>--
>Jani Nikula, Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm: print top commit sha after loading the driver
2024-04-29 15:32 ` Lucas De Marchi
@ 2024-05-08 11:01 ` Farah Kassabri
2024-05-08 11:34 ` Jani Nikula
0 siblings, 1 reply; 12+ messages in thread
From: Farah Kassabri @ 2024-05-08 11:01 UTC (permalink / raw)
To: De Marchi, Lucas, Jani Nikula
Cc: intel-xe@lists.freedesktop.org, Ohad Sharabi,
dri-devel@lists.freedesktop.org
On 4/29/2024 18:32, Lucas De Marchi wrote:
> On Mon, Apr 29, 2024 at 02:02:28PM GMT, Jani Nikula wrote:
>> On Wed, 24 Apr 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
>>> Add the last driver sha to the existing log message
>>> which prints the drm device info.
>>
>> The commit message fails to answer the most important question: why?
>>
>> Especially, what makes drm devices such special snowflakes that they'd
>> need to be the only ones in the kernel to print git commit sha1's?
>
>
> the closest to what was added here would be srcversion:
>
> $ modinfo build64/drivers/gpu/drm/xe/xe.ko | grep srcversion
> srcversion: 0EA08A43AC399A0D942740
>
> which makes more sense and doesn't depend on the git tree checkout and
> other possible problems with dirty checkouts. If you want to print it
> on module load to be able to tell from a log, you could probably just
> access mod->srcversion.
>
> but I'm not sure what we are trying to accomplish here and the commit
> message certainly missed that. Please Cc dri-devel on changes outside xe
> and provide the motivation in the commit message.
The main reason why we need this sha, is because our driver will run in
multiple environments and setups (whether it's for clients, our labs or
data center), each setup could work with different driver build and it's
very convenient to see what is the last sha in the running driver
in order to see if some fix is inside or not for example.
The srcversion is not good enough as it's doesn't server the purpose and
it's not incrementing at the same rate as the commits sha.
Note that this apply not to all drm devices only xe, and it's optional
for other devices to set it or not, and in case it's not set this patch
will not affect the existing drm log.
you can see we're already doing that for habanalabs driver.
I'll update the commit message, and the dri-level alreay in CC in case
they see any issue with this change.
BR,
Farah
>
> thanks
> Lucas De Marchi
>
>
>>
>> BR,
>> Jani.
>>
>>>
>>> Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
>>> ---
>>> drivers/gpu/drm/drm_drv.c | 6 +++---
>>> include/drm/drm_drv.h | 2 ++
>>> 2 files changed, 5 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
>>> index 535b624d4c9d..e0f7af1b6ec3 100644
>>> --- a/drivers/gpu/drm/drm_drv.c
>>> +++ b/drivers/gpu/drm/drm_drv.c
>>> @@ -947,10 +947,10 @@ int drm_dev_register(struct drm_device *dev,
>>> unsigned long flags)
>>> }
>>> drm_panic_register(dev);
>>>
>>> - DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
>>> + DRM_INFO("Initialized %s %d.%d.%d%s %s for %s on minor %d\n",
>>> driver->name, driver->major, driver->minor,
>>> - driver->patchlevel, driver->date,
>>> - dev->dev ? dev_name(dev->dev) : "virtual device",
>>> + driver->patchlevel, driver->git_sha ? driver->git_sha : "",
>>> + driver->date, dev->dev ? dev_name(dev->dev) : "virtual
>>> device",
>>> dev->primary ? dev->primary->index : dev->accel->index);
>>>
>>> goto out_unlock;
>>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>>> index 8878260d7529..7578a1f4ce74 100644
>>> --- a/include/drm/drm_drv.h
>>> +++ b/include/drm/drm_drv.h
>>> @@ -407,6 +407,8 @@ struct drm_driver {
>>> int minor;
>>> /** @patchlevel: driver patch level */
>>> int patchlevel;
>>> + /** @git_sha: driver last commit sha */
>>> + char *git_sha;
>>> /** @name: driver name */
>>> char *name;
>>> /** @desc: driver description */
>>
>> --
>> Jani Nikula, Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm: print top commit sha after loading the driver
2024-05-08 11:01 ` Farah Kassabri
@ 2024-05-08 11:34 ` Jani Nikula
2024-05-16 14:17 ` Farah Kassabri
0 siblings, 1 reply; 12+ messages in thread
From: Jani Nikula @ 2024-05-08 11:34 UTC (permalink / raw)
To: Farah Kassabri, De Marchi, Lucas
Cc: intel-xe@lists.freedesktop.org, Ohad Sharabi,
dri-devel@lists.freedesktop.org
On Wed, 08 May 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
> On 4/29/2024 18:32, Lucas De Marchi wrote:
>> On Mon, Apr 29, 2024 at 02:02:28PM GMT, Jani Nikula wrote:
>>> On Wed, 24 Apr 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
>>>> Add the last driver sha to the existing log message
>>>> which prints the drm device info.
>>>
>>> The commit message fails to answer the most important question: why?
>>>
>>> Especially, what makes drm devices such special snowflakes that they'd
>>> need to be the only ones in the kernel to print git commit sha1's?
>>
>>
>> the closest to what was added here would be srcversion:
>>
>> $ modinfo build64/drivers/gpu/drm/xe/xe.ko | grep srcversion
>> srcversion: 0EA08A43AC399A0D942740
>>
>> which makes more sense and doesn't depend on the git tree checkout and
>> other possible problems with dirty checkouts. If you want to print it
>> on module load to be able to tell from a log, you could probably just
>> access mod->srcversion.
>>
>> but I'm not sure what we are trying to accomplish here and the commit
>> message certainly missed that. Please Cc dri-devel on changes outside xe
>> and provide the motivation in the commit message.
>
> The main reason why we need this sha, is because our driver will run in
> multiple environments and setups (whether it's for clients, our labs or
> data center), each setup could work with different driver build and it's
> very convenient to see what is the last sha in the running driver
> in order to see if some fix is inside or not for example.
While I sympathize with this view, it's not really an upstream problem,
is it? When you're running upstream kernels, you don't mix and match,
you run a known kernel version and the drivers that come with it.
And again, why should xe be a special snowflake in this respect? If it
were fine for xe to add this, why wouldn't it be fine for absolutely all
drivers?
> The srcversion is not good enough as it's doesn't server the purpose and
> it's not incrementing at the same rate as the commits sha.
> Note that this apply not to all drm devices only xe, and it's optional
> for other devices to set it or not, and in case it's not set this patch
> will not affect the existing drm log.
> you can see we're already doing that for habanalabs driver.
Where?
Not that it justifies adding more, but I can't find it.
BR,
Jani.
> I'll update the commit message, and the dri-level alreay in CC in case
> they see any issue with this change.
>
> BR,
> Farah
>
>>
>> thanks
>> Lucas De Marchi
>>
>>
>>>
>>> BR,
>>> Jani.
>>>
>>>>
>>>> Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
>>>> ---
>>>> drivers/gpu/drm/drm_drv.c | 6 +++---
>>>> include/drm/drm_drv.h | 2 ++
>>>> 2 files changed, 5 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
>>>> index 535b624d4c9d..e0f7af1b6ec3 100644
>>>> --- a/drivers/gpu/drm/drm_drv.c
>>>> +++ b/drivers/gpu/drm/drm_drv.c
>>>> @@ -947,10 +947,10 @@ int drm_dev_register(struct drm_device *dev,
>>>> unsigned long flags)
>>>> }
>>>> drm_panic_register(dev);
>>>>
>>>> - DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
>>>> + DRM_INFO("Initialized %s %d.%d.%d%s %s for %s on minor %d\n",
>>>> driver->name, driver->major, driver->minor,
>>>> - driver->patchlevel, driver->date,
>>>> - dev->dev ? dev_name(dev->dev) : "virtual device",
>>>> + driver->patchlevel, driver->git_sha ? driver->git_sha : "",
>>>> + driver->date, dev->dev ? dev_name(dev->dev) : "virtual
>>>> device",
>>>> dev->primary ? dev->primary->index : dev->accel->index);
>>>>
>>>> goto out_unlock;
>>>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>>>> index 8878260d7529..7578a1f4ce74 100644
>>>> --- a/include/drm/drm_drv.h
>>>> +++ b/include/drm/drm_drv.h
>>>> @@ -407,6 +407,8 @@ struct drm_driver {
>>>> int minor;
>>>> /** @patchlevel: driver patch level */
>>>> int patchlevel;
>>>> + /** @git_sha: driver last commit sha */
>>>> + char *git_sha;
>>>> /** @name: driver name */
>>>> char *name;
>>>> /** @desc: driver description */
>>>
>>> --
>>> Jani Nikula, Intel
>
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] drm/xe: set last driver commit sha
2024-04-29 11:15 ` Jani Nikula
@ 2024-05-08 12:09 ` Farah Kassabri
0 siblings, 0 replies; 12+ messages in thread
From: Farah Kassabri @ 2024-05-08 12:09 UTC (permalink / raw)
To: Jani Nikula, intel-xe@lists.freedesktop.org; +Cc: Ohad Sharabi
On 4/29/2024 14:15, Jani Nikula wrote:
> On Wed, 24 Apr 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
>> This patch will set the last driver commit sha into the drm driver
>> info data structure, which will be used in the log message which
>> prints the device info at the end of the driver initialization.
>>
>> Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
>> ---
>> drivers/gpu/drm/xe/Makefile | 4 ++++
>> drivers/gpu/drm/xe/xe_device.c | 1 +
>> 2 files changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
>> index 8321ec4f9b46..acccb517b7bb 100644
>> --- a/drivers/gpu/drm/xe/Makefile
>> +++ b/drivers/gpu/drm/xe/Makefile
>> @@ -309,6 +309,10 @@ ifeq ($(CONFIG_DEBUG_FS),y)
>> i915-display/intel_pipe_crc.o
>> endif
>>
>> +GIT_SHA ?= $(shell cd $(srctree) && git rev-parse --short HEAD)
>
> There are no guarantees that the kernel is being built from a git
> checkout. Or if it is, that there are no uncommitted changes. Etc. See
> scripts/setlocalversion.
>
> IMO it's just not so simple that we could reasonably add this into a
> local Makefile.
>
This script looks good, but to my understanding it compels having a
$kERNELVERSION set (which is also not always the case), and we need to
change it to serve my purpose as well in order to have the sha in the dmesg.
if you think its better to change that script, and call it from the our
Makefile to set env variable instead i'll consider that.
BR,
Farah
> BR,
> Jani.
>
>> +DRV_CFLAGS_MODULE="-DXE_DRIVER_GIT_SHA=-$(GIT_SHA)"
>> +CFLAGS_MODULE += ${DRV_CFLAGS_MODULE}
>> +
>> obj-$(CONFIG_DRM_XE) += xe.o
>> obj-$(CONFIG_DRM_XE_KUNIT_TEST) += tests/
>>
>> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
>> index 55bbc8b8df15..2e74aa18e953 100644
>> --- a/drivers/gpu/drm/xe/xe_device.c
>> +++ b/drivers/gpu/drm/xe/xe_device.c
>> @@ -215,6 +215,7 @@ static struct drm_driver driver = {
>> .major = DRIVER_MAJOR,
>> .minor = DRIVER_MINOR,
>> .patchlevel = DRIVER_PATCHLEVEL,
>> + .git_sha = __stringify(XE_DRIVER_GIT_SHA),
>> };
>>
>> static void xe_device_destroy(struct drm_device *dev, void *dummy)
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] drm: print top commit sha after loading the driver
2024-05-08 11:34 ` Jani Nikula
@ 2024-05-16 14:17 ` Farah Kassabri
0 siblings, 0 replies; 12+ messages in thread
From: Farah Kassabri @ 2024-05-16 14:17 UTC (permalink / raw)
To: Jani Nikula, De Marchi, Lucas
Cc: intel-xe@lists.freedesktop.org, Ohad Sharabi,
dri-devel@lists.freedesktop.org
On 5/8/2024 14:34, Jani Nikula wrote:
> On Wed, 08 May 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
>> On 4/29/2024 18:32, Lucas De Marchi wrote:
>>> On Mon, Apr 29, 2024 at 02:02:28PM GMT, Jani Nikula wrote:
>>>> On Wed, 24 Apr 2024, Farah Kassabri <fkassabri@habana.ai> wrote:
>>>>> Add the last driver sha to the existing log message
>>>>> which prints the drm device info.
>>>>
>>>> The commit message fails to answer the most important question: why?
>>>>
>>>> Especially, what makes drm devices such special snowflakes that they'd
>>>> need to be the only ones in the kernel to print git commit sha1's?
>>>
>>>
>>> the closest to what was added here would be srcversion:
>>>
>>> $ modinfo build64/drivers/gpu/drm/xe/xe.ko | grep srcversion
>>> srcversion: 0EA08A43AC399A0D942740
>>>
>>> which makes more sense and doesn't depend on the git tree checkout and
>>> other possible problems with dirty checkouts. If you want to print it
>>> on module load to be able to tell from a log, you could probably just
>>> access mod->srcversion.
>>>
>>> but I'm not sure what we are trying to accomplish here and the commit
>>> message certainly missed that. Please Cc dri-devel on changes outside xe
>>> and provide the motivation in the commit message.
>>
>> The main reason why we need this sha, is because our driver will run in
>> multiple environments and setups (whether it's for clients, our labs or
>> data center), each setup could work with different driver build and it's
>> very convenient to see what is the last sha in the running driver
>> in order to see if some fix is inside or not for example.
>
> While I sympathize with this view, it's not really an upstream problem,
> is it? When you're running upstream kernels, you don't mix and match,
> you run a known kernel version and the drivers that come with it.
>
> And again, why should xe be a special snowflake in this respect? If it
> were fine for xe to add this, why wouldn't it be fine for absolutely all
> drivers?
I think you're right, we'll keep this change internally, no need to
upstream it.
Thanks,
Farah
>
>> The srcversion is not good enough as it's doesn't server the purpose and
>> it's not incrementing at the same rate as the commits sha.
>> Note that this apply not to all drm devices only xe, and it's optional
>> for other devices to set it or not, and in case it's not set this patch
>> will not affect the existing drm log.
>> you can see we're already doing that for habanalabs driver.
>
> Where?
>
> Not that it justifies adding more, but I can't find it.
>
>
> BR,
> Jani.
>
>
>> I'll update the commit message, and the dri-level alreay in CC in case
>> they see any issue with this change.
>>
>> BR,
>> Farah
>>
>>>
>>> thanks
>>> Lucas De Marchi
>>>
>>>
>>>>
>>>> BR,
>>>> Jani.
>>>>
>>>>>
>>>>> Signed-off-by: Farah Kassabri <fkassabri@habana.ai>
>>>>> ---
>>>>> drivers/gpu/drm/drm_drv.c | 6 +++---
>>>>> include/drm/drm_drv.h | 2 ++
>>>>> 2 files changed, 5 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
>>>>> index 535b624d4c9d..e0f7af1b6ec3 100644
>>>>> --- a/drivers/gpu/drm/drm_drv.c
>>>>> +++ b/drivers/gpu/drm/drm_drv.c
>>>>> @@ -947,10 +947,10 @@ int drm_dev_register(struct drm_device *dev,
>>>>> unsigned long flags)
>>>>> }
>>>>> drm_panic_register(dev);
>>>>>
>>>>> - DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
>>>>> + DRM_INFO("Initialized %s %d.%d.%d%s %s for %s on minor %d\n",
>>>>> driver->name, driver->major, driver->minor,
>>>>> - driver->patchlevel, driver->date,
>>>>> - dev->dev ? dev_name(dev->dev) : "virtual device",
>>>>> + driver->patchlevel, driver->git_sha ? driver->git_sha : "",
>>>>> + driver->date, dev->dev ? dev_name(dev->dev) : "virtual
>>>>> device",
>>>>> dev->primary ? dev->primary->index : dev->accel->index);
>>>>>
>>>>> goto out_unlock;
>>>>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>>>>> index 8878260d7529..7578a1f4ce74 100644
>>>>> --- a/include/drm/drm_drv.h
>>>>> +++ b/include/drm/drm_drv.h
>>>>> @@ -407,6 +407,8 @@ struct drm_driver {
>>>>> int minor;
>>>>> /** @patchlevel: driver patch level */
>>>>> int patchlevel;
>>>>> + /** @git_sha: driver last commit sha */
>>>>> + char *git_sha;
>>>>> /** @name: driver name */
>>>>> char *name;
>>>>> /** @desc: driver description */
>>>>
>>>> --
>>>> Jani Nikula, Intel
>>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-05-16 14:18 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-24 10:07 [PATCH 1/2] drm: print top commit sha after loading the driver Farah Kassabri
2024-04-24 10:07 ` [PATCH 2/2] drm/xe: set last driver commit sha Farah Kassabri
2024-04-29 11:15 ` Jani Nikula
2024-05-08 12:09 ` Farah Kassabri
2024-04-28 21:48 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm: print top commit sha after loading the driver Patchwork
2024-04-28 21:48 ` ✓ CI.checkpatch: " Patchwork
2024-04-28 21:49 ` ✓ CI.KUnit: " Patchwork
2024-04-29 11:02 ` [PATCH 1/2] " Jani Nikula
2024-04-29 15:32 ` Lucas De Marchi
2024-05-08 11:01 ` Farah Kassabri
2024-05-08 11:34 ` Jani Nikula
2024-05-16 14:17 ` Farah Kassabri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).