From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFD7CC4332F for ; Tue, 12 Dec 2023 04:05:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A2F1A10E183; Tue, 12 Dec 2023 04:05:33 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D071D10E4C8 for ; Tue, 12 Dec 2023 04:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702353931; x=1733889931; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=sYdDBVojJoIatm5QyckpKoTygUiyhyJG5Ay5TOEZ+xA=; b=FW2adCmk1E1sTdMncRYREJCrUzb//82/NPKxVtzYjaGVrFQqTxmutBmi 8llPcTL6/axFa4zRcddjOZpfn16AHpEAT2Ivx2qYPvv7bhFRnNYlX8HZT 1f4pJrycCXWF2V9jX7sFD3QXf5xUExjMkN7SbrAUqLMEeiqLK/h80VpKO J4qh9VI+824bsKytdidVBmfLzKeY/Un29jcHH0XlgsHRBqNrBs7lGOAmm 0TiqgGvZTCwu7afgpdwiMyU6hf7Btyd3EjE7FZnZKy1HITEH2/KJZVHY9 HtdyVJFtTUI0YCRx4obZmog74ruiZnm3uPp1AXVUHdTWxCv3ZDLoI6rOG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="393621143" X-IronPort-AV: E=Sophos;i="6.04,269,1695711600"; d="scan'208";a="393621143" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 20:05:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="1020530045" X-IronPort-AV: E=Sophos;i="6.04,269,1695711600"; d="scan'208";a="1020530045" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.173.43]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 20:05:30 -0800 Date: Mon, 11 Dec 2023 20:05:30 -0800 Message-ID: <87sf489ib9.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Francois Dugast Subject: Re: [PATCH] drm/xe/pmu: Remove PMU from Xe till uapi is finalized In-Reply-To: References: <20231209224352.2720403-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lucas De Marchi , Rodrigo Vivi , intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 11 Dec 2023 13:30:02 -0800, Francois Dugast wrote: Hi Francois, > > On Mon, Dec 11, 2023 at 10:25:09AM -0800, Umesh Nerlige Ramappa wrote: > > On Sat, Dec 09, 2023 at 02:43:52PM -0800, Ashutosh Dixit wrote: > > > PMU uapi is likely to change in the future. Till the uapi is finalize= d, > > > remove PMU from Xe. PMU can be re-added after uapi is finalized. > > > > > > Signed-off-by: Ashutosh Dixit > > > > I guess partial removal was messy. This is fine. > > > > Reviewed-by: Umesh Nerlige Ramappa > > It seems this patch cannot be used as it is, I am getting the same error > as the one reported by CI: > > ../drivers/gpu/drm/xe/tests/xe_dma_buf.c:125:47: error: \ > =A1DRM_XE_GEM_CPU_CACHING_WC=A2 undeclared (first use in this functio= n) > 125 | bo =3D xe_bo_create_user(xe, NULL, NULL, size, DRM_XE_GEM_CP= U_CACHING_WC, > > drivers/gpu/drm/xe/tests/xe_dma_buf.c appears to be missing a: > > #include I had a missing CONFIG_KUNIT, added this line and posted this: https://patchwork.freedesktop.org/series/127598/#rev3 Actually posted another version here with a separate 'fixup' to drivers/gpu/drm/xe/tests/xe_dma_buf.c: https://patchwork.freedesktop.org/series/127664/ Both should be fine. Please pick one. Thanks. -- Ashutosh