Re: [Intel-xe] [PATCH 1/2] misc: mei: fix Kconfig dependencies

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 20 Oct 2023, Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> The dependency chain for INTEL_MEI is not properly addressed, as
> reported by LKP:
>
>    WARNING: unmet direct dependencies detected for INTEL_MEI_ME
>    Depends on [n]: X86 && PCI [=y]
>    Selected by [y]:
>    - INTEL_MEI_HDCP [=y] && (DRM_I915 [=n] || DRM_XE [=y])
>
> Basically, all symbols selecting INTEL_MEI shall also depends on
> both X86 and PCI.
>
> Add such dependency, as otherwise the dependencies won't be
> properly followed.

This must *not* be applied to drm-xe-next directly. Get it merged
upstream first, and backport with cherry-pick -x annotation if needed.

BR,
Jani

>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202310201234.ZZLwdoiy-lkp@intel.com/
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  drivers/misc/mei/gsc_proxy/Kconfig | 1 +
>  drivers/misc/mei/hdcp/Kconfig      | 1 +
>  drivers/misc/mei/pxp/Kconfig       | 1 +
>  3 files changed, 3 insertions(+)
>
> diff --git a/drivers/misc/mei/gsc_proxy/Kconfig b/drivers/misc/mei/gsc_proxy/Kconfig
> index 5f68d9f3d691..6053ebbf536d 100644
> --- a/drivers/misc/mei/gsc_proxy/Kconfig
> +++ b/drivers/misc/mei/gsc_proxy/Kconfig
> @@ -4,6 +4,7 @@
>  config INTEL_MEI_GSC_PROXY
>  	tristate "Intel GSC Proxy services of ME Interface"
>  	select INTEL_MEI_ME
> +	depends on X86 && PCI
>  	depends on DRM_I915
>  	help
>           MEI Support for GSC Proxy Services on Intel platforms.
> diff --git a/drivers/misc/mei/hdcp/Kconfig b/drivers/misc/mei/hdcp/Kconfig
> index 2ac9148988d4..a5e8d3e9fc92 100644
> --- a/drivers/misc/mei/hdcp/Kconfig
> +++ b/drivers/misc/mei/hdcp/Kconfig
> @@ -4,6 +4,7 @@
>  config INTEL_MEI_HDCP
>  	tristate "Intel HDCP2.2 services of ME Interface"
>  	select INTEL_MEI_ME
> +	depends on X86 && PCI
>  	depends on DRM_I915 || DRM_XE
>  	help
>  	  MEI Support for HDCP2.2 Services on Intel platforms.
> diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> index 4029b96afc04..3acc05fea744 100644
> --- a/drivers/misc/mei/pxp/Kconfig
> +++ b/drivers/misc/mei/pxp/Kconfig
> @@ -4,6 +4,7 @@
>  #
>  config INTEL_MEI_PXP
>  	tristate "Intel PXP services of ME Interface"
> +	depends on X86 && PCI
>  	select INTEL_MEI_ME
>  	depends on DRM_I915
>  	help

-- 
Jani Nikula, Intel