From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FB14D5B86A for ; Mon, 15 Dec 2025 19:34:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E17910E25A; Mon, 15 Dec 2025 19:34:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="aByhGr4B"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97C1210E25A for ; Mon, 15 Dec 2025 19:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765827270; x=1797363270; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=ovF5UTM8QO7zYX7nwyskGkYS1/J0m5TBH86wRLxGQ6U=; b=aByhGr4B0yhTICj6lR9Due8uh7l87aI6toHcZe9z1hc8pudGnB96Ap+y TZkiZUyErLUnGPbg5xk+hNDZbUD4N1LMNR0nip4EUovVsob2PywFsCIFc 7SggEL5q2hiCb1tJ4lYLckO9EJbzs34v5TG5IhlnP+dBQhdSVGAdwBScI 5lB14P9VBfUDrt6yVexgQ56WZnmz1WnNr4Y1gCMNQn+izDw3enkoCzCcN ofQzGcEWWbp+3fLuj7mNks5oK7+Ks1uIAfpbNIajiJrg2j0PDbb/C0p+O 4lJul82uzv3xZAWL6RtJK3lZ2aRT5ezi+CCT8JctqRtMAealTiQySeymw A==; X-CSE-ConnectionGUID: YqbKVkbWTm2KX3n8gnulXQ== X-CSE-MsgGUID: TFg02c4QRCmSm1WIQAE44Q== X-IronPort-AV: E=McAfee;i="6800,10657,11643"; a="71372622" X-IronPort-AV: E=Sophos;i="6.21,151,1763452800"; d="scan'208";a="71372622" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2025 11:34:30 -0800 X-CSE-ConnectionGUID: Qu8Gpg5MTmqiJeFUYapEzw== X-CSE-MsgGUID: 3/n/A2PlTBiD6pi69xczNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,151,1763452800"; d="scan'208";a="228463056" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.241.242.187]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2025 11:34:30 -0800 Date: Mon, 15 Dec 2025 11:34:28 -0800 Message-ID: <87tsxr8rp7.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi Cc: , Umesh Nerlige Ramappa Subject: Re: [PATCH 1/3] drm/xe/oa/uapi: Expose MERT OA unit In-Reply-To: References: <20251205212613.826224-1-ashutosh.dixit@intel.com> <20251205212613.826224-2-ashutosh.dixit@intel.com> <87345k6b8q.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 08 Dec 2025 11:53:26 -0800, Rodrigo Vivi wrote: > Hi Rodrigo, > On Mon, Dec 08, 2025 at 11:10:13AM -0800, Dixit, Ashutosh wrote: > > On Mon, 08 Dec 2025 04:48:13 -0800, Rodrigo Vivi wrote: > > > > > > > Hi Rodrigo, > > > > > On Fri, Dec 05, 2025 at 01:26:11PM -0800, Ashutosh Dixit wrote: > > > > A MERT OA unit is available in the SoC on some platforms. Add support > > > > for this OA unit and expose it to userspace. The MERT OA unit does not > > > > have any HW engines attached, but is otherwise similar to an OAM unit. > > > > > > > > Signed-off-by: Lucas De Marchi > > > > Reviewed-by: Umesh Nerlige Ramappa > > > > Signed-off-by: Ashutosh Dixit > > > > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h > > > > index 876a076fa6c0c..f520462c28643 100644 > > > > --- a/include/uapi/drm/xe_drm.h > > > > +++ b/include/uapi/drm/xe_drm.h > > > > @@ -1675,6 +1675,9 @@ enum drm_xe_oa_unit_type { > > > > > > > > /** @DRM_XE_OA_UNIT_TYPE_OAM_SAG: OAM_SAG OA unit */ > > > > DRM_XE_OA_UNIT_TYPE_OAM_SAG, > > > > + > > > > + /** @DRM_XE_OA_UNIT_TYPE_MERT: MERT OA unit */ > > > > + DRM_XE_OA_UNIT_TYPE_MERT, > > > > > > And who&where is the usage here? > > > > Sorry I just merged this. > > No worries, I just force pushed it out. > > > I will provide the MDAPI UMD pull request for > > this when it is available. Hope this is ok. > > Let's re-merge when we see the usage out there. We now have a MDAPI PR for this feature: https://github.com/intel/metrics-discovery/pull/37 I am still waiting for the PR to be reviewed, it is expected to be reviewed by EOW, at which point I am planning to re-merge this series (after updating this email thread). MDAPI will merge their PR after the holidays. Hope this plan is ok. Thanks. -- Ashutosh > > > > > This functionality (memory access counters) was part of OAG OA unit but is > > now separated out into a separate OA unit on some platforms. > > Yeap, but any flag or anything that changes the uapi we do in the defined > order: > > 1. both kernel and user space patches are sent out together and reviewed > in paralell. > 2. kernel code is acked by user-space developers (apparently not relevant > in this case) > 3. kernel patch lands first. (Here we have the user-space review already > finished and ready to get merged) > 4. user space patch lands right after. > > Thanks, > Rodrigo. > > > > > Thanks. > > -- > > Ashutosh