Re: [PATCH 1/5] drm/xe/oa/uapi: Expose media OA units

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 06 Jun 2025 10:37:53 -0700, Umesh Nerlige Ramappa wrote:
>
> On Fri, Jun 06, 2025 at 09:02:49AM -0700, Ashutosh Dixit wrote:
> > On Xe2+ platforms, media engines are attached to "SCMI" OA media (OAM)
> > units. One or more SCMI OAM units might be present on a platform. In
> > addition there is another OAM unit for global events, called
> > OAM-SAG. Performance metrics for media workloads can be obtained from these
> > OAM units, similar to OAG.
> >
> > Expose these OAM units for userspace to use. OAM-SAG is exposed as an OA
> > unit without any attached engines.
> >
> > Bspec: 70819, 67103, 63844, 72572, 74476, 61284
> >
> > v2: Fix xe_gt_WARN_ON in __hwe_oam_unit for < 12.7 platforms
> > v3: Return XE_OA_UNIT_INVALID for < 12.7 to indicate no OAM units
> > v4: Move xe_oa_print_oa_units() to separate patch
> > v5: Introduce DRM_XE_OA_UNIT_TYPE_OAM_SAG
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> LGTM,
>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Thanks Umesh. I also just added a DRM_XE_OA_CAPS_OAM capability also to
this patch. I was debating initially, since userland will see at least 2
OAM units after this series is merged, so that is the way to figure out if
correct OAM support is present in the driver. But then went ahead and added
DRM_XE_OA_CAPS_OAM, since that's how we've been doing things: if you change
uapi, you add a capability. Thanks.