From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-xe@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Jose Souza <jose.souza@intel.com>
Subject: Re: [PATCH] drm/xe/uapi: Rename xe perf layer as xe observation layer
Date: Tue, 02 Jul 2024 17:03:31 -0700 [thread overview]
Message-ID: <87tth79wa4.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <ZoSDBuvL/b07eXRs@orsosgc001>
On Tue, 02 Jul 2024 15:45:26 -0700, Umesh Nerlige Ramappa wrote:
>
Hi Umesh,
> On Tue, Jul 02, 2024 at 02:40:34PM -0700, Ashutosh Dixit wrote:
> > In Xe, the perf layer allows capture of HW counter streams. These HW
> > counters are generally performance related but don't have to be necessarily
> > so. Also, the name "perf" is a carryover from i915 and is not preferred.
> >
> > Here we propose the name "observation" for this common layer which allows
> > capture of different types of these counter streams.
> >
> > v2: Rename observability layer to observation layer and in code
> > s/obsrv/observation/ (Lucas/Rodrigo)
> >
> > Fixes: 52c2e956dceb ("drm/xe/perf/uapi: "Perf" layer to support multiple
> > perf counter stream types")
> > Fixes: fe8929bdf835 ("drm/xe/perf/uapi: Add perf_stream_paranoid sysctl")
> > Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Applied the patch and grepped for perf/obsrv/observation, LGTM,
>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thanks for checking and reviewing. Looks like CI is not running at
present. In any case, I'll wait to see if anyone else also has any review
comments before merging this.
Thanks.
--
Ashutosh
next prev parent reply other threads:[~2024-07-03 0:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 21:40 [PATCH] drm/xe/uapi: Rename xe perf layer as xe observation layer Ashutosh Dixit
2024-07-02 21:48 ` Dixit, Ashutosh
2024-07-03 15:18 ` Rodrigo Vivi
2024-07-02 22:45 ` Umesh Nerlige Ramappa
2024-07-03 0:03 ` Dixit, Ashutosh [this message]
2024-07-03 15:03 ` ✓ CI.Patch_applied: success for " Patchwork
2024-07-03 15:03 ` ✗ CI.checkpatch: warning " Patchwork
2024-07-03 15:05 ` ✓ CI.KUnit: success " Patchwork
2024-07-03 15:16 ` ✓ CI.Build: " Patchwork
2024-07-03 15:19 ` ✓ CI.Hooks: " Patchwork
2024-07-03 15:20 ` ✓ CI.checksparse: " Patchwork
2024-07-03 15:48 ` ✓ CI.BAT: " Patchwork
2024-07-03 15:52 ` [PATCH] " Souza, Jose
2024-07-03 15:50 ` Dixit, Ashutosh
2024-07-03 16:12 ` Souza, Jose
2024-07-03 16:36 ` Dixit, Ashutosh
2024-07-03 16:41 ` Dixit, Ashutosh
2024-07-03 15:53 ` ✓ CI.Patch_applied: success for drm/xe/uapi: Rename xe perf layer as xe observation layer (rev2) Patchwork
2024-07-03 15:54 ` ✗ CI.checkpatch: warning " Patchwork
2024-07-03 15:55 ` ✓ CI.KUnit: success " Patchwork
2024-07-03 16:07 ` ✓ CI.Build: " Patchwork
2024-07-03 16:09 ` ✓ CI.Hooks: " Patchwork
2024-07-03 16:10 ` ✓ CI.checksparse: " Patchwork
2024-07-03 16:37 ` ✗ CI.BAT: failure " Patchwork
2024-07-03 20:58 ` ✓ CI.FULL: success for drm/xe/uapi: Rename xe perf layer as xe observation layer Patchwork
2024-07-03 22:30 ` ✓ CI.FULL: success for drm/xe/uapi: Rename xe perf layer as xe observation layer (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-07-03 16:48 [PATCH] drm/xe/uapi: Rename xe perf layer as xe observation layer Ashutosh Dixit
2024-07-03 17:04 ` Souza, Jose
2024-07-03 18:02 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tth79wa4.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).