From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13A0DEE57C1 for ; Fri, 8 Sep 2023 04:40:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B7EDF10E863; Fri, 8 Sep 2023 04:40:54 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E29910E863 for ; Fri, 8 Sep 2023 04:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694148052; x=1725684052; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Xujz/k3nH5de31DfFwxc/7CwY9chZ/QV8WslhQDJIMk=; b=QENeO3vXTmuQXhrEYOJG4CfTJuR+6LpRgHmvgk114sHEwaskgVfEsXZa gWwenng/9b5q2yekSFIQn7/VoCbPVqtoNn/MXadN+/NalrXVBKtJjqJk7 /RzRfRCHnV47WSzTxds/Tvu1qkYnMmkuceVC2fWkZaww76GkcT0Ye+7dy yJbpxkScSUAH9G0G/nfmXZQXL3BD1VBiITkNBOeOhJh7Xy1M8MCmWMBB+ +QRFHF3mEYyBQx+AcVAr+aNHIMmRtHuz04SACG749XcXnSU1LfZROHq3O cJGRH3GxnbB231R0HAyGuH4O0HqEY3BFWu38M/Yt25bQ6qdWrnbk41juE w==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="374939601" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="374939601" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 21:40:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="719003257" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="719003257" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.97.168]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 21:40:50 -0700 Date: Thu, 07 Sep 2023 21:40:50 -0700 Message-ID: <87tts5qnu5.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Nerlige Ramappa, Umesh" In-Reply-To: References: <20230808013159.38811-1-ashutosh.dixit@intel.com> <20230808013159.38811-10-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH 09/10] drm/xe/oa: Read file_operation X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-xe@lists.freedesktop.org" Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 23 Aug 2023 12:46:45 -0700, Nerlige Ramappa, Umesh wrote: > Hi Umesh, > On Mon, Aug 07, 2023 at 06:31:58PM -0700, Ashutosh Dixit wrote: > >+static bool oa_report_ctx_invalid(struct xe_oa_stream *stream, void > >*report) > >+{ > >+ return false; > >+} > > I think I had posted an updated patch for i915. The context valid bit is > applicable to gen12 as well, so we should implement the context id > valid/invalid helper. Couldn't find your patch but I have implmented it in patch v2. Please review. https://patchwork.freedesktop.org/patch/556313/?series=121084&rev=5 > >+ /* An out of bounds or misaligned head or tail pointer implies a driver bug */ > >+ if (drm_WARN_ONCE(&stream->oa->xe->drm, > >+ head > OA_BUFFER_SIZE || tail > OA_BUFFER_SIZE, > >+ "Inconsistent OA buffer pointers: head = %u, tail = %u\n", > >+ head, tail)) > >+ return -EIO; > >+ > >+ for (/* none */; OA_TAKEN(tail, head); head = (head + report_size) & mask) { > > We can drop the 'none' comment. Done. Thanks. -- Ashutosh