Re: [PATCH] drm/i915/display: Don't allow odd ypan or ysize with semiplanar format

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 19 Nov 2024, Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> wrote:
> Disable support for odd panning and size in y direction when running
> on display version 3x and using semiplanar formats.
>
> Bspec: 68903
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> index d89630b2d5c1..a61eeaa7640c 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> @@ -1030,6 +1030,11 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state)
>  		     DISPLAY_VERx100(i915) == 3000) &&
>  		     src_x % 2 != 0)
>  			hsub = 2;
> +
> +		if (DISPLAY_VERx100(i915) >= 3000 &&
> +		    DISPLAY_VERx100(i915) <= 3500)

x100 is only needed if the last two digits are non-zero, right?

IS_DISPLAY_VER()?

BR,
Jani.

> +			vsub = 2;
> +
>  	} else {
>  		hsub = fb->format->hsub;
>  		vsub = fb->format->vsub;

-- 
Jani Nikula, Intel