From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C62D0C54E4A for ; Thu, 7 Mar 2024 20:49:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E2BD10F09B; Thu, 7 Mar 2024 20:49:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Jq3e+EhV"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C4DB10F09B; Thu, 7 Mar 2024 20:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709844566; x=1741380566; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=ilMUyXopEkmBNybJuR23NjEdPVgSG3BBUTWyPhUd7SE=; b=Jq3e+EhVCdLTVJCyLo+oOaDnSkQX3BAw8E7Ru6clqLoK/jYDTBZI/EwM TkefR+jzJB9iQtmoOMffrvcHccEVCz+Hk6M8I39DBxoAye0KeqV6VKbVO 2m63S3R5QG0xJ2tnNABxP45FU1EZ9ToYPaTyDP9pSEqTdrR3s2HjyCe8s PAw879eA1KUoZuS3UzaZzSvm4lmYTRdEPsVAqmgesFwfnA2mJ/Ebq67na erlHtFxcAfMjHh9nvSiDX3NAUSYFbgB0bZ3UKank8EwCGvKF5mb1y++Y3 J4U5iXhUlrcX4A/NTcDrwccQQgOJgjMXtrLAI+wSmTRscXXmo2IZfwgud g==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="15686320" X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="15686320" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 12:49:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,107,1708416000"; d="scan'208";a="10168983" Received: from tofferse-mobl.ger.corp.intel.com (HELO localhost) ([10.252.33.212]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 12:49:23 -0800 From: Jani Nikula To: Lucas De Marchi Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 17/22] drm/i915/pxp: fix i915_pxp_tee_interface.h kernel-doc warnings In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Thu, 07 Mar 2024 22:49:19 +0200 Message-ID: <87v85xvkc0.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 07 Mar 2024, Lucas De Marchi wrote: > On Wed, Mar 06, 2024 at 08:31:22PM +0200, Jani Nikula wrote: >>Make documentation match code. >> >>Signed-off-by: Jani Nikula >>--- >> include/drm/i915_pxp_tee_interface.h | 19 ++++++++++++------- >> 1 file changed, 12 insertions(+), 7 deletions(-) >> >>diff --git a/include/drm/i915_pxp_tee_interface.h b/include/drm/i915_pxp_tee_interface.h >>index 7d96985f2d05..653e85d6e32b 100644 >>--- a/include/drm/i915_pxp_tee_interface.h >>+++ b/include/drm/i915_pxp_tee_interface.h >>@@ -14,12 +14,10 @@ struct scatterlist; >> * struct i915_pxp_component_ops - ops for PXP services. >> * @owner: Module providing the ops >> * @send: sends data to PXP >>- * @receive: receives data from PXP >>+ * @recv: receives data from PXP >>+ * @gsc_command: send gsc command >> */ >> struct i915_pxp_component_ops { >>- /** >>- * @owner: owner of the module provding the ops >>- */ > > > isn't the other way around the more common one? i.e. document the > struct members closer to their declaration. > >> struct module *owner; >> >> int (*send)(struct device *dev, const void *message, size_t size, >>@@ -35,14 +33,21 @@ struct i915_pxp_component_ops { >> /** >> * struct i915_pxp_component - Used for communication between i915 and TEE >> * drivers for the PXP services >>- * @tee_dev: device that provide the PXP service from TEE Bus. >>- * @pxp_ops: Ops implemented by TEE driver, used by i915 driver. >> */ > > ... which you follow here. Yeah, fixed locally, ditto for previous patch. Thanks for the reviews. BR, Jani. -- Jani Nikula, Intel