From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
<intel-xe@lists.freedesktop.org>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH 4/6] drm/xe: Drop redundant parameter from xe_probe_info_early
Date: Sat, 5 Sep 2026 10:55:49 -0300 [thread overview]
Message-ID: <87wlsz7qfu.fsf@intel.com> (raw)
In-Reply-To: <20260904170531.516-5-michal.wajdeczko@intel.com>
Michal Wajdeczko <michal.wajdeczko@intel.com> writes:
> We can now obtain the const pointer to struct xe_device_desc directly
> from the xe, no need to pass it as explicit parameter.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
> drivers/gpu/drm/xe/xe_pci.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index d19478c9439e..6ca1ec311a4b 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -753,7 +753,6 @@ struct xe_probed_info {
> * Probe from the hardware the info required by xe_info_init_early().
> */
> static int xe_probe_info_early(struct xe_device *xe,
> - const struct xe_device_desc *desc,
> struct xe_probed_info *probed_info)
> {
> struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
> @@ -761,7 +760,7 @@ static int xe_probe_info_early(struct xe_device *xe,
> probed_info->devid = pdev->device;
> probed_info->revid = pdev->revision;
>
> - xe_step_platform_get(desc->platform, probed_info->revid, &probed_info->step);
> + xe_step_platform_get(xe->desc->platform, probed_info->revid, &probed_info->step);
>
> return 0;
> }
> @@ -1218,7 +1217,7 @@ static int __xe_pci_probe(struct pci_dev *pdev, const struct xe_device_desc *des
>
> pci_set_master(pdev);
>
> - err = xe_probe_info_early(xe, desc, &probed_info);
> + err = xe_probe_info_early(xe, &probed_info);
> if (err)
> return err;
>
> --
> 2.47.1
next prev parent reply other threads:[~2026-09-05 13:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 17:05 [PATCH 0/6] drm/xe/log: Relax location ID recognition Michal Wajdeczko
2026-09-04 17:05 ` [PATCH 1/6] drm/xe: Drop unused parameter from xe_info_init Michal Wajdeczko
2026-09-04 18:09 ` Rodrigo Vivi
2026-09-05 13:04 ` Gustavo Sousa
2026-09-04 17:05 ` [PATCH 2/6] drm/xe: Keep reference to device descriptor Michal Wajdeczko
2026-09-04 17:14 ` sashiko-bot
2026-09-05 13:52 ` Gustavo Sousa
2026-09-07 19:30 ` Michal Wajdeczko
2026-09-11 11:25 ` Michal Wajdeczko
2026-09-11 16:36 ` Gustavo Sousa
2026-09-04 17:05 ` [PATCH 3/6] drm/xe: Drop redundant parameters from xe_info_init_early Michal Wajdeczko
2026-09-05 13:54 ` Gustavo Sousa
2026-09-04 17:05 ` [PATCH 4/6] drm/xe: Drop redundant parameter from xe_probe_info_early Michal Wajdeczko
2026-09-05 13:55 ` Gustavo Sousa [this message]
2026-09-04 17:05 ` [PATCH 5/6] drm/xe: Drop redundant parameter from xe_probe_info and friends Michal Wajdeczko
2026-09-05 13:58 ` Gustavo Sousa
2026-09-04 17:05 ` [PATCH 6/6] drm/xe/log: Relax location ID recognition Michal Wajdeczko
2026-09-04 18:44 ` Rodrigo Vivi
2026-09-09 9:00 ` Mallesh, Koujalagi
2026-09-09 9:42 ` Michal Wajdeczko
2026-09-09 11:02 ` Mallesh, Koujalagi
2026-09-09 13:01 ` Michal Wajdeczko
2026-09-04 17:13 ` ✓ CI.KUnit: success for " Patchwork
2026-09-04 17:52 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-05 1:36 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wlsz7qfu.fsf@intel.com \
--to=gustavo.sousa@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox