From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08AD4C83F09 for ; Tue, 8 Jul 2025 14:26:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2A8910E660; Tue, 8 Jul 2025 14:26:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="fy0RiWDl"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id D90F810E660 for ; Tue, 8 Jul 2025 14:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751984819; x=1783520819; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=YF2vhM97f6N66ZAvb8ZVSm0mgWYyyKysBeSbNhNbfFM=; b=fy0RiWDlw0kfz8k6vQFhtDGeiEHWDBgwA1gwq5h2COgKv6rydtA6/Y6x iG3tnz/UetuB46/QqeCgdD+oyuZbIipZZNkqy6QZyTSKCfUR/5uTmRffH xyr424bf6TBGXnzSwX1CO5B4MwWwkBvFPUqqI4iROMfq2Wy9rQ+9FmKzB GP2SIFjUmorV85HQv5KRzjIZfjCgGRd80tK0r7dlJeVeTkvp2sy756L2K EMPlXU2dG12HppJeeH/A6kJE/D9MJxMpvejjtumKKP6lPD020TpcGN7dF MqAeNP3KVutOkADR+TBm0H9MXF/MrQEF43D4itswaPfWisXBI4iLijKGa w==; X-CSE-ConnectionGUID: lV340qC3SbaRpIOUm4fmaw== X-CSE-MsgGUID: xkZu4gitQuqUBwiywHn0HA== X-IronPort-AV: E=McAfee;i="6800,10657,11487"; a="54366276" X-IronPort-AV: E=Sophos;i="6.16,297,1744095600"; d="scan'208";a="54366276" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2025 07:26:50 -0700 X-CSE-ConnectionGUID: mPqNpGcqQBCVMZI5A/iYhQ== X-CSE-MsgGUID: wTMoo2g9QnW8FK8dtRfB7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,297,1744095600"; d="scan'208";a="154925868" Received: from dyeung-mobl2.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.124.18.96]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2025 07:26:47 -0700 Date: Tue, 08 Jul 2025 07:26:45 -0700 Message-ID: <87wm8i21y2.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Lucas De Marchi Cc: , Matthew Auld Subject: Re: [PATCH] drm/xe/pat: Use XE_WA in xe_pat_init_early In-Reply-To: <3ab27we7l3262ltktojmwxt6m35iv2qx7k52cnfsjidqts6h6m@qxmnk52eaeg2> References: <20250707222111.3214505-1-ashutosh.dixit@intel.com> <3ab27we7l3262ltktojmwxt6m35iv2qx7k52cnfsjidqts6h6m@qxmnk52eaeg2> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 07 Jul 2025 20:48:38 -0700, Lucas De Marchi wrote: > > On Mon, Jul 07, 2025 at 03:21:11PM -0700, Ashutosh Dixit wrote: > > Add the missing XE_WA in xe_pat_init_early. > > > > Fixes: 01570b446939 ("drm/xe/bmg: implement Wa_16023588340") > > Signed-off-by: Ashutosh Dixit > > --- > > drivers/gpu/drm/xe/xe_pat.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c > > index 2e7cb99ae87aa..d36da052f8a43 100644 > > --- a/drivers/gpu/drm/xe/xe_pat.c > > +++ b/drivers/gpu/drm/xe/xe_pat.c > > @@ -384,8 +384,7 @@ void xe_pat_init_early(struct xe_device *xe) > > if (IS_DGFX(xe)) > > xe->pat.pat_pta = &xe2_pat_pta; > > > > - /* Wa_16023588340. XXX: Should use XE_WA */ > > - if (GRAPHICS_VERx100(xe) == 2001) > > + if (XE_WA(xe_root_mmio_gt(xe), 16023588340)) > > xe_device_probe() > xe_pat_init_early() // -> OOB WAs are not initialized at this point > ... > for_each_gt() > xe_gt_init_early() > xe_wa_init() > xe_wa_process_oob() > > you should see this assert triggered: > xe_gt_assert(gt__, (gt__)->wa_active.oob_initialized); Yikes, got it. Thanks. > > > xe->pat.n_entries = 28; /* Disable CLOS3 */ > > else > > xe->pat.n_entries = ARRAY_SIZE(xe2_pat_table); > > -- > > 2.48.1 > >