intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Tiwei Bie <tiwei.btw@antgroup.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	linux-um@lists.infradead.org
Cc: intel-xe@lists.freedesktop.org,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: -Wmissing-prototypes warnings in user-mode linux
Date: Tue, 05 Mar 2024 15:45:52 +0200	[thread overview]
Message-ID: <87y1aw23n3.fsf@intel.com> (raw)
In-Reply-To: <9d297bf5-4f54-431b-ab8d-c5be825f129e@antgroup.com>

On Tue, 05 Mar 2024, Tiwei Bie <tiwei.btw@antgroup.com> wrote:
> Thanks for raising this topic!                            
>                                                               
> Indeed. To make it easier to review, the current series only addressed
> the -Wmissing-prototypes warnings that can be fixed straightforwardly (e.g.
> by turning into static functions or including missing headers). The remaining 
> -Wmissing-prototypes warnings mainly fall into the following categories:
>
> - Symbols defined and used in os-Linux/;                
> - Symbols defined in os-Linux/, but declared in kernel headers;
> - Symbols defined in individual files and not called explicitly;
>
> My plan was to fix the remaining warnings in followup series. Ultimately,
> I wish we can let cc treat -Wmissing-prototypes warnings as errors.

Yay! That's good to hear.

If you want to get build testing from our CI, using our configs, please
just Cc: intel-xe@lists.freedesktop.org when sending the patches. You'll
get the results in reply.


Thanks,
Jani.

-- 
Jani Nikula, Intel

  reply	other threads:[~2024-03-05 13:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 10:34 -Wmissing-prototypes warnings in user-mode linux Jani Nikula
2024-03-05 10:35 ` Johannes Berg
2024-03-05 10:49   ` Jani Nikula
2024-03-05 11:17     ` Johannes Berg
2024-03-05 11:18     ` Tiwei Bie
2024-03-05 13:45       ` Jani Nikula [this message]
2024-03-05 14:26         ` Tiwei Bie
2024-04-22 20:35     ` Richard Weinberger
2024-04-23  4:59       ` Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1aw23n3.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-um@lists.infradead.org \
    --cc=lucas.demarchi@intel.com \
    --cc=richard@nod.at \
    --cc=tiwei.btw@antgroup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).