Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
	intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: Re: [Intel-xe] [PATCH 1/8] fixup! drm/xe/display: Implement display support
Date: Tue, 07 Nov 2023 14:54:58 +0200	[thread overview]
Message-ID: <87y1f9yb8d.fsf@intel.com> (raw)
In-Reply-To: <20231106064834.161647-2-jouni.hogander@intel.com>

On Mon, 06 Nov 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> Using i915_fence_timeout causes linking error as i915_fence_context_timeout
> doesn't exist for Xe. Return just MAX_SCHEDULE_TIMEOUT.

Considering the implementation of i915_fence_context_timeout(), isn't 0
more appropriate?

BR,
Jani.

>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/xe/compat-i915-headers/i915_config.h | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_config.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_config.h
> index 10e18b036489..e835bea08d1b 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_config.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_config.h
> @@ -6,18 +6,14 @@
>  #ifndef __I915_CONFIG_H__
>  #define __I915_CONFIG_H__
>  
> -#include <linux/types.h>
> -#include <linux/limits.h>
> +#include <linux/sched.h>
>  
>  struct drm_i915_private;
>  
> -unsigned long i915_fence_context_timeout(const struct drm_i915_private *i915,
> -					 u64 context);
> -
>  static inline unsigned long
>  i915_fence_timeout(const struct drm_i915_private *i915)
>  {
> -	return i915_fence_context_timeout(i915, U64_MAX);
> +	return MAX_SCHEDULE_TIMEOUT;
>  }
>  
>  #endif /* __I915_CONFIG_H__ */

-- 
Jani Nikula, Intel

  reply	other threads:[~2023-11-07 12:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06  6:48 [Intel-xe] [PATCH 0/8] Backport i915_sw_fence to dma fence conversion Jouni Högander
2023-11-06  6:48 ` [Intel-xe] [PATCH 1/8] fixup! drm/xe/display: Implement display support Jouni Högander
2023-11-07 12:54   ` Jani Nikula [this message]
2023-11-07 13:19     ` Hogander, Jouni
2023-11-07 13:41       ` Jani Nikula
2023-11-06  6:48 ` [Intel-xe] [PATCH 2/8] Revert "FIXME: drm/i915: fence stuff" Jouni Högander
2023-11-06  6:48 ` [Intel-xe] [PATCH 3/8] Revert "drm/xe/display: Append dma_buf fences to framebuffer fences" Jouni Högander
2023-11-06  6:48 ` [Intel-xe] [PATCH 4/8] fixup! drm/xe/display: Implement display support Jouni Högander
2023-11-06  6:48 ` [Intel-xe] [PATCH 5/8] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence Jouni Högander
2023-11-06  6:48 ` [Intel-xe] [PATCH 6/8] drm/i915/display: Use intel_bo_to_drm_bo instead of obj->base Jouni Högander
2023-11-06  6:48 ` [Intel-xe] [PATCH 7/8] fixup! drm/xe/display: Implement display support Jouni Högander
2023-11-06  6:48 ` [Intel-xe] [PATCH 8/8] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-11-06  6:51 ` [Intel-xe] ✓ CI.Patch_applied: success for Backport i915_sw_fence to dma fence conversion Patchwork
2023-11-06  6:51 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-06  6:53 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-06  7:00 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-06  7:03 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-06  7:04 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-11-06  7:33 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-11-07 12:56 ` [Intel-xe] [PATCH 0/8] " Jani Nikula
2023-11-08  6:06   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1f9yb8d.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox