Re: [PATCH v3 0/7] drm/xe/rtp: Miscellaneous improvements to rule matching

[Gustavo Sousa <gustavo.sousa@intel.com>]

Gustavo Sousa <gustavo.sousa@intel.com> writes:

> This series adds several improvements to RTP code around rule matching
> logic.
>
> It first starts with making sure there is a cleaner separation of
> responsibilities when it comes to the generic kunit testing for RTP.
> Then it goes on to improve rule matching code by making the parsing
> logic more robust and restructuring the code to resemble a formal
> grammar and make it easier to add future extensions.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>

Pushed to drm-xe-next. Thanks Matt and Violet for the reviews!

--
Gustavo Sousa

> ---
> Changes in v3:
> - Added eBNF grammar for the rules to the kernel-doc.
> - Fully reviewed now. Sent for fresh CI results.
> - Link to v2: https://patch.msgid.link/20260430-rtp-rule-parser-v2-0-157e98b4ab51@intel.com
>
> Changes in v2:
> - Incorporated review feedback. See individual patches for the
>   changelog.
> - Incorporated the addition of the match type XE_RTP_MATCH_PLATFORM_STEP
>   after rebasing on latest drm-tip, which is reflected in some of the
>   patches.
> - Link to v1: https://patch.msgid.link/20260114-rtp-rule-parser-v1-0-fa9029586bff@intel.com
>
> ---
> Gustavo Sousa (7):
>       drm/xe/rtp: Write kunit test cases specific for rule matching
>       drm/xe/rtp: Drop rule matching cases from rtp_to_sr_cases and rtp_cases
>       drm/xe/rtp: Don't short-circuit to false in or-yes case
>       drm/xe/rtp: Do not break parsing when missing context
>       drm/xe/rtp: Extract rule_match_item()
>       drm/xe/rtp: Fully parse the ruleset
>       drm/xe/rtp: Implement a structured parser for rule matching
>
>  drivers/gpu/drm/xe/tests/xe_rtp.c      |  38 ++++
>  drivers/gpu/drm/xe/tests/xe_rtp_test.c | 327 +++++++++++++++++++++------------
>  drivers/gpu/drm/xe/tests/xe_rtp_test.h |  23 +++
>  drivers/gpu/drm/xe/xe_rtp.c            | 321 +++++++++++++++++++-------------
>  drivers/gpu/drm/xe/xe_rtp.h            |  29 ++-
>  5 files changed, 486 insertions(+), 252 deletions(-)
> ---
> base-commit: 7e25390024f8a4a9fdd6ec50f000ee25c006c02f
> change-id: 20260114-rtp-rule-parser-ac01472acdeb
>
> Best regards,
> --  
> Gustavo Sousa <gustavo.sousa@intel.com>