From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 981D1FF6E97 for ; Tue, 17 Mar 2026 23:04:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 43EAD10E1CA; Tue, 17 Mar 2026 23:04:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="e6+9xuFk"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4458910E1CA for ; Tue, 17 Mar 2026 23:04:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773788645; x=1805324645; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=+zLYOXo4NKRPMr+iNjzptrwVgeJQk9cVattyeSUpOQc=; b=e6+9xuFkL7hvovsBlqBCY8j9s7zG9fezq6V1sFbY2M3C2L0S11LuxN0j NGplH9Gn6ovMKaiErk+exVcKfceXCzjl7TUeQD3Azv2AHhPD+7McSSrTS KqVEjegdGNZL8GqEdn4S6LMgddUVZbyWMB1C8FcXzQcxsnoO4UTxjwpux eLmSZV+HQ0n994Loqas5RtVQZ9KM6c44Hzoc9iTpWlONEkYXizs/c0dqv c1UX3cCf5j2q15GG8SD2rfPXYIBN4D/C6F3HXQlGLQnrEOqM0bkkoBNZX cq1IWlRJVucIK0BNOUSRbV25w3JymJGcZ7rlQWOwsx3dM3qEKuT40FRDM A==; X-CSE-ConnectionGUID: Z5zX0AHJTCO7YaPIa5oQeA== X-CSE-MsgGUID: MBBtojOKRaeZUu4fBChvkw== X-IronPort-AV: E=McAfee;i="6800,10657,11732"; a="75019044" X-IronPort-AV: E=Sophos;i="6.23,126,1770624000"; d="scan'208";a="75019044" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 16:04:04 -0700 X-CSE-ConnectionGUID: X576cokWR2KSIEVXXRPjPg== X-CSE-MsgGUID: sXAh1O9cTtm2HKlV9L3zsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,126,1770624000"; d="scan'208";a="245439539" Received: from chungjes-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.64.16]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 16:03:51 -0700 Date: Tue, 17 Mar 2026 16:03:48 -0700 Message-ID: <87zf46xdm3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Nerlige Ramappa, Umesh" Cc: "intel-xe@lists.freedesktop.org" Subject: Re: [PATCH v2] drm/xe/oa: Allow reading after disabling OA stream In-Reply-To: References: <20260313053630.3176100-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 16 Mar 2026 21:42:50 -0700, Nerlige Ramappa, Umesh wrote: > > Have mail client problems, so sending from Outlook > > > -----Original Message----- > > From: Dixit, Ashutosh > > Sent: Friday, March 13, 2026 11:07 AM > > To: intel-xe@lists.freedesktop.org > > Cc: Nerlige Ramappa, Umesh > > Subject: [PATCH v2] drm/xe/oa: Allow reading after disabling OA stream > > > > Some OA data might be present in the OA buffer when OA stream is disabled. > > Allow UMD's to retrieve this data, so that all data till the point when OA stream is > > disabled can be retrieved. > > > > v2: Update tail pointer after disable (Umesh) > > > > Signed-off-by: Ashutosh Dixit > > --- > > drivers/gpu/drm/xe/xe_oa.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c index > > dcd393b0931a2..2efc16c3a95df 100644 > > --- a/drivers/gpu/drm/xe/xe_oa.c > > +++ b/drivers/gpu/drm/xe/xe_oa.c > > @@ -543,8 +543,7 @@ static ssize_t xe_oa_read(struct file *file, char __user > > *buf, > > size_t offset = 0; > > int ret; > > > > - /* Can't read from disabled streams */ > > - if (!stream->enabled || !stream->sample) > > + if (!stream->sample) > > return -EINVAL; > > > > if (!(file->f_flags & O_NONBLOCK)) { > > @@ -1456,6 +1455,10 @@ static void xe_oa_stream_disable(struct > > xe_oa_stream *stream) > > > > if (stream->sample) > > hrtimer_cancel(&stream->poll_check_timer); > > + > > + /* Update stream->oa_buffer.tail to allow any final reports to be read */ > > + if (xe_oa_buffer_check_unlocked(stream)) > > + wake_up(&stream->poll_wq); > > Reviewed-by: Umesh Nerlige Ramappa Thanks Umesh, just FYI, I added Fixes: as well Cc:stable tags on this and merged it. > > > } > > > > static int xe_oa_enable_preempt_timeslice(struct xe_oa_stream *stream) > > -- > > 2.48.1 >