From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3ADEC36014 for ; Wed, 2 Apr 2025 10:29:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACA8310E02B; Wed, 2 Apr 2025 10:29:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Y87itNYx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id CAAF188F94; Wed, 2 Apr 2025 10:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743589787; x=1775125787; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=A+4tSjn2YdRj34Y5p/NVm+Jy+j8Xa4VbK0J8GUs1mXU=; b=Y87itNYxo+ZsqnrnGpiW0hq/z0z05PLfJiBU5WOC0buZ73SjmFTPE+nF J1ZytyrEWb3fhye0s9M5TSlaIB4Ol7CYM45w8E7lYeOjtvCFyfzrbUNvU D0JD0X1+iQasTpX13md214w4Z+Wp1nG5bVlV5jw5XnoLoa7U6IhpIjjsR eUj+Q2X7hlDFmvx8KlGHNaI24mz4A+mzGcXN1qnHwwLoyh+0q0khA8YCH Wzfx7sVJNtOu3XEMdUIr2SyB+DvlXCpYGSURfcjo+PKCAbRHffjltXifo uShMkwBvFOotUBzpkpnJm3FGoYMu7+i0RvtOn2EgmNwqGjddS1S61HyUM w==; X-CSE-ConnectionGUID: qmdFQtRPToqcOc8m2dGNnQ== X-CSE-MsgGUID: RFDKdABUSnCBzneS9q810A== X-IronPort-AV: E=McAfee;i="6700,10204,11391"; a="44093687" X-IronPort-AV: E=Sophos;i="6.14,182,1736841600"; d="scan'208";a="44093687" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2025 03:29:46 -0700 X-CSE-ConnectionGUID: Nyv2T5E7RVCv1Vp2Emz6nA== X-CSE-MsgGUID: Ly0wDuBxTJmHMfqoHErj3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,182,1736841600"; d="scan'208";a="127560846" Received: from bergbenj-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.73]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2025 03:29:45 -0700 From: Jani Nikula To: Arun R Murthy , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: imre.deak@intel.com, Arun R Murthy Subject: Re: [PATCH v3 1/2] drm/i915/display/dp: Remove UHBR13.5 for icl In-Reply-To: <8734eq3lic.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250402-dprates-v3-0-9e5d8ca989dd@intel.com> <20250402-dprates-v3-1-9e5d8ca989dd@intel.com> <8734eq3lic.fsf@intel.com> Date: Wed, 02 Apr 2025 13:29:41 +0300 Message-ID: <87zfgy26wa.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 02 Apr 2025, Jani Nikula wrote: > On Wed, 02 Apr 2025, Arun R Murthy wrote: >> Per Bspec display 14+ has uhbr13.5 Due to the retimer constraint none of >> the Intel platforms support uhbr13.5. > > Those two sentences together make no sense. > > The subject makes no sense, because icl never supported UHBR. > >> This has been removed for mtl >> by the commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") >> This patch will remove the support for DG2. > > "This patch" and "will" are unnecessary fillers. And once a patch is > committed, "this patch" is meaningless. > > Just "Remove ..." is fine. > > dg2_max_source_rate() *still* refers to 1350000 as max rate, and that's > arguably more important than the rates array. And you can just remove > the entire function because it becomes a constant. Except of course not, because that would drop UHBR support completely. You just need to adjust the rate in the function to reflect reality. > > BR, > Jani. > >> >> v2: Reframed the commit msg (Jani) >> >> Signed-off-by: Arun R Murthy >> --- >> drivers/gpu/drm/i915/display/intel_dp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c >> index f21f9b441fc2a4e644c69410e6ec6b3d37907478..d7955351dd43ff61ebfd57e5b6a4ba99c1c7a2b2 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >> @@ -550,7 +550,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) >> }; >> static const int icl_rates[] = { >> 162000, 216000, 270000, 324000, 432000, 540000, 648000, 810000, >> - 1000000, 1350000, >> + 1000000, >> }; >> static const int bxt_rates[] = { >> 162000, 216000, 243000, 270000, 324000, 432000, 540000 -- Jani Nikula, Intel