From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: lucas.demarchi@intel.com, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 0/5] drm/xe: drop unnecessary i915 display commits
Date: Mon, 11 Sep 2023 17:35:07 +0300 [thread overview]
Message-ID: <87zg1seq1w.fsf@intel.com> (raw)
In-Reply-To: <ZPuR8zorq32uh3Bn@intel.com>
On Fri, 08 Sep 2023, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Tue, Sep 05, 2023 at 05:13:42PM +0300, Jani Nikula wrote:
>> Revert five unnecessary commits.
>>
>> The rebased version with all the commits just thrown away is at
>> [1]. That also drops "drm/i915/display: Make FBC check stolen at use
>> time." which has become an empty commit.
>>
>> [1] https://gitlab.freedesktop.org/jani/xe/-/commits/xe-drop-unnecessary-commits-2023-09-05
>>
>>
>> Jani Nikula (5):
>> Revert "FIXME: drm/i915: display/intel_display_types.h random
>> whitespace changes"
>> Revert "FIXME: drm/i915: include i915_utils.h from
>> intel_display_types.h"
>> Revert "FIXME: drm/i915: revert the earlier mmio_offset change"
>> Revert "FIXME: drm/i915/display: Prefer i915->uncore over plain
>> uncore"
>> Revert "FIXME: drm/i915/display: Set DISPLAY_MMIO_BASE to 0 for xe"
>
> I honestly confess that I got a bit lost here, but the end result
> makes sense, so I just force-pushed the removal of these 6 patches.
Thanks. So I sent these as reverts to get CI results, and the branch was
just the reverted patches removed altogether.
BR,
Jani.
>
>>
>> drivers/gpu/drm/i915/display/intel_bios.c | 13 ++++++-------
>> drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++-
>> 2 files changed, 8 insertions(+), 8 deletions(-)
>>
>> --
>> 2.39.2
>>
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2023-09-11 14:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 14:13 [Intel-xe] [PATCH 0/5] drm/xe: drop unnecessary i915 display commits Jani Nikula
2023-09-05 14:13 ` [Intel-xe] [PATCH 1/5] Revert "FIXME: drm/i915: display/intel_display_types.h random whitespace changes" Jani Nikula
2023-09-05 14:13 ` [Intel-xe] [PATCH 2/5] Revert "FIXME: drm/i915: include i915_utils.h from intel_display_types.h" Jani Nikula
2023-09-05 14:13 ` [Intel-xe] [PATCH 3/5] Revert "FIXME: drm/i915: revert the earlier mmio_offset change" Jani Nikula
2023-09-05 14:13 ` [Intel-xe] [PATCH 4/5] Revert "FIXME: drm/i915/display: Prefer i915->uncore over plain uncore" Jani Nikula
2023-09-05 14:13 ` [Intel-xe] [PATCH 5/5] Revert "FIXME: drm/i915/display: Set DISPLAY_MMIO_BASE to 0 for xe" Jani Nikula
2023-09-05 14:34 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: drop unnecessary i915 display commits Patchwork
2023-09-05 14:34 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-05 14:35 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-05 14:42 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-05 14:42 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-09-05 14:43 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-06 17:29 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: drop unnecessary i915 display commits (rev2) Patchwork
2023-09-06 17:29 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-06 17:30 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-06 17:37 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-06 17:38 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-06 17:39 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-07 14:54 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: drop unnecessary i915 display commits (rev3) Patchwork
2023-09-07 14:54 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-07 14:55 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-07 15:02 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-07 15:03 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-07 15:04 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-07 15:36 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-09-08 21:28 ` [Intel-xe] [PATCH 0/5] drm/xe: drop unnecessary i915 display commits Rodrigo Vivi
2023-09-11 14:35 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg1seq1w.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox