Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com
Subject: Re: [PATCH 2/2] drm/xe/display: drop unused rawclk_freq and RUNTIME_INFO()
Date: Tue, 20 Aug 2024 16:11:01 +0200	[thread overview]
Message-ID: <8a84e375-a015-4da3-aa4c-7aff4c7b6f1d@linux.intel.com> (raw)
In-Reply-To: <9f09274bddc14f555c0102f37af6df23b4433102.1724144570.git.jani.nikula@intel.com>

Excellent, for both patches:

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Den 2024-08-20 kl. 11:07, skrev Jani Nikula:
> With rawclk_freq moved to display runtime info, xe has no users left for
> them.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 -
>  drivers/gpu/drm/xe/xe_device_types.h              | 6 ------
>  2 files changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> index 2feedddf1e40..182c38905626 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> @@ -116,7 +116,6 @@ struct i915_sched_attr {
>  #define i915_gem_fence_wait_priority(fence, attr) do { (void) attr; } while (0)
>  
>  #define pdev_to_i915 pdev_to_xe_device
> -#define RUNTIME_INFO(xe)		(&(xe)->info.i915_runtime)
>  
>  #define FORCEWAKE_ALL XE_FORCEWAKE_ALL
>  
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index cb60bc5ec21b..5ed6f5434f42 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -305,12 +305,6 @@ struct xe_device {
>  		u8 has_atomic_enable_pte_bit:1;
>  		/** @info.has_device_atomics_on_smem: Supports device atomics on SMEM */
>  		u8 has_device_atomics_on_smem:1;
> -
> -#if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
> -		struct {
> -			u32 rawclk_freq;
> -		} i915_runtime;
> -#endif
>  	} info;
>  
>  	/** @irq: device interrupt state */

  reply	other threads:[~2024-08-20 14:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20  9:07 [PATCH 0/2] drm/i915 & drm/xe: rawclk freq cleanups Jani Nikula
2024-08-20  9:07 ` [PATCH 1/2] drm/i915: move rawclk from runtime to display runtime info Jani Nikula
2024-08-20  9:07 ` [PATCH 2/2] drm/xe/display: drop unused rawclk_freq and RUNTIME_INFO() Jani Nikula
2024-08-20 14:11   ` Maarten Lankhorst [this message]
2024-08-21  8:29     ` Jani Nikula
2024-08-20 10:24 ` ✓ CI.Patch_applied: success for drm/i915 & drm/xe: rawclk freq cleanups Patchwork
2024-08-20 10:24 ` ✓ CI.checkpatch: " Patchwork
2024-08-20 10:25 ` ✓ CI.KUnit: " Patchwork
2024-08-20 10:37 ` ✓ CI.Build: " Patchwork
2024-08-20 10:39 ` ✓ CI.Hooks: " Patchwork
2024-08-20 10:41 ` ✗ CI.checksparse: warning " Patchwork
2024-08-20 17:03 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a84e375-a015-4da3-aa4c-7aff4c7b6f1d@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox